vfs_fruit: move check in ad_convert() to ad_convert_*() subfunctions

Currently the whole conversion is skipped if the FinderInfo entry in the
AppleDouble file is of the default size (ie not containing xattrs).

That also means we never converted FinderInfo from the AppleDouble file
to stream format. This change finally fixes this.

Note that this keeps failing with streams_depot, much like the existing
known-fail of "samba3.vfs.fruit streams_depot.OS X AppleDouble file
conversion". Fixing the conversion to work with vfs_streams_depot is a
task for another day.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
21 jobs for slow-autobuild in 126 minutes and 9 seconds (queued for 1 second)
Status Name Job ID Coverage
  Build
passed build_ctdb #106119230
docker shared

00:19:40

passed build_others #106119232
docker shared

00:13:17

canceled build_samba #106119233
docker private

02:06:08

passed build_samba_ad_dc #106119241
docker private

01:10:56

passed build_samba_ad_dc_2 #106119225
docker shared

00:40:30

passed build_samba_ad_dc_2_py3 #106119226
docker shared

00:24:26

passed build_samba_ad_dc_py3 #106119244
docker private

00:18:06

passed build_samba_ctdb #106119231
docker shared

00:36:26

passed build_samba_fileserver #106119238
docker private

00:18:05

passed build_samba_libs #106119227
docker shared

00:34:39

passed build_samba_libs_py3 #106119228
docker shared

00:36:12

passed build_samba_none_env #106119219
docker shared

00:46:45

passed build_samba_none_env_py3 #106119220
docker shared

00:22:38

passed build_samba_nopython #106119221
docker shared

00:29:24

failed build_samba_nt4 #106119235
docker private

00:44:55

passed build_samba_nt4_py3 #106119236
docker private

00:11:23

passed build_samba_o3 #106119224
docker shared

00:32:19

passed build_samba_py3 #106119234
docker private

00:20:52

passed build_samba_static #106119229
docker shared

00:43:28

passed build_samba_systemkrb5 #106119222
docker shared

00:15:55

passed build_samba_xc #106119223
docker shared

00:06:31

 
Name Stage Failure
failed
build_samba_nt4 Build
/dev/xvda1        317594  3660    313918   2% /builds/samba-team/devel


### df -m /tmp/samba-testbase/b14
Filesystem 1M-blocks Used Available Use% Mounted on
/dev/mapper/docker-202:1-258568-5e727450fcb6073596cf1b2e0516a053a7c5d8088b63cd42b0e8f2407abb924b 10229 1795 8435 18% /


ERROR: Job failed: exit code 1