vfs_fruit: move check in ad_convert() to ad_convert_*() subfunctions

Currently the whole conversion is skipped if the FinderInfo entry in the
AppleDouble file is of the default size (ie not containing xattrs).

That also means we never converted FinderInfo from the AppleDouble file
to stream format. This change finally fixes this.

Note that this keeps failing with streams_depot, much like the existing
known-fail of "samba3.vfs.fruit streams_depot.OS X AppleDouble file
conversion". Fixing the conversion to work with vfs_streams_depot is a
task for another day.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13649

Signed-off-by: Ralph Boehme <slow@samba.org>
21 jobs for slow-autobuild in 148 minutes and 33 seconds (queued for 1 second)
Status Name Job ID Coverage
  Build
passed build_ctdb #106046984
docker shared

00:19:44

passed build_others #106046986
docker shared

00:13:24

canceled build_samba #106046988
docker private

02:28:32

passed build_samba_ad_dc #106046995
docker private

01:11:14

passed build_samba_ad_dc_2 #106046976
docker shared

00:33:03

passed build_samba_ad_dc_2_py3 #106046977
docker shared

00:25:00

passed build_samba_ad_dc_py3 #106046996
docker private

00:17:24

passed build_samba_ctdb #106046985
docker shared

00:35:19

passed build_samba_fileserver #106046993
docker private

00:19:10

passed build_samba_libs #106046978
docker shared

00:33:30

passed build_samba_libs_py3 #106046980
docker shared

00:35:43

passed build_samba_none_env #106046970
docker shared

00:45:10

passed build_samba_none_env_py3 #106046971
docker shared

00:24:15

passed build_samba_nopython #106046972
docker shared

00:28:00

failed build_samba_nt4 #106046991
docker private

00:45:00

passed build_samba_nt4_py3 #106046992
docker private

00:10:45

passed build_samba_o3 #106046975
docker shared

00:31:32

passed build_samba_py3 #106046990
docker private

00:20:20

passed build_samba_static #106046982
docker shared

00:45:00

passed build_samba_systemkrb5 #106046973
docker shared

00:16:16

passed build_samba_xc #106046974
docker shared

00:06:40

 
Name Stage Failure
failed
build_samba_nt4 Build
/dev/xvda1        317594  3659    313920   2% /builds/samba-team/devel


### df -m /tmp/samba-testbase/b15
Filesystem 1M-blocks Used Available Use% Mounted on
/dev/mapper/docker-202:1-258568-856ac906798df13029bbb41b2f87b195f1f64cc3256424a590cc2521b9f66f82 10229 1796 8434 18% /


ERROR: Job failed: exit code 1