The test seems to work for PY2/PY3 however there is an issue with
the test being run the second time e.g. the test run with either PY2 or
PY3 works ok. Problem actually is wiht the test being run more than
once (regardless or py2 or py3)

Test fails
 in python/samba/netcmd/domain.py:998 (in class cmd_domain_demote(Command) )
where
 drsuapiBind.DsRemoveDSServer(drsuapi_handle, 1, req1)

ends up in source4/rpc_server/drsuapi/dcesrv_drsuapi.c:570

=>   ret = dsdb_delete(b_state->sam_ctx, ntds_dn, DSDB_TREE_DELETE);

Either we need to repromote DC or add stuff to the db on test tearDown

My initial attempts failed to do that (e.g. tried to run "domain",
"dcpromo" with a runsubcmd in tearDown)

<sigh> this resulted in

"  File "bin/python/samba/join.py", line 332, in promote_possible
    raise Exception("Account '%s' appears to be an active DC, use 'samba-tool domain join' if you must re-create this account" % ctx.samname)
]: "

various attempts to get this going failed.
Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

various messages are lists of ints that need converting to str or bytes
depending on py2/py3, others are str/bytes that need modification and
are converted to lists or string char or ints for modificate (and then
reconstructed as str/bytes again)
Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

the cmp function and the cmp paramater (e.g. to sort functions)
no longer exist in python3.

cmp_fn is provides the missing functionality of the py2 cmp builtin
function.

cmp_to_key_fn allows the key paramater (e.g. for sort) to use the
old py2 cmp function for sorting. Note: the cmp_to_key is present in
since 2.7 (hence the inclusion of the source code for this function pre
that version)
Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>

Signed-off-by: Noel Power <noel.power@suse.com>