Commits · master · The Samba Team / Upstream Samba Development / samba

This project is mirrored from https://gitlab.com/samba-team/samba.git. Pull mirroring updated Dec 01, 2020.

01 Dec, 2020 15 commits

vfs_zfsacl: add missing inherited flag on hidden "magic" [email protected] ACE · 936f74da

Ralph Böhme authored Nov 30, 2020

This was an omission in the fixes for bug 14470.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14587Signed-off-by: Ralph Boehme <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

Autobuild-User(master): Jeremy Allison <[email protected]>
Autobuild-Date(master): Tue Dec 1 20:29:34 UTC 2020 on sn-devel-184

936f74da

vfs_zfsacl: reformatting · a8457ac3

Ralph Böhme authored Nov 30, 2020

No change in behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14587Signed-off-by: Ralph Boehme <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

a8457ac3

selftest: Remove samba3.blackbox.smbclient_tar from flapping tests · 89e2d68b

Noel Power authored Nov 30, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

89e2d68b

clitar: Use do_list()'s recursion in clitar.c · 20e0ce50

VL authored Dec 01, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Aurelien Aptel <[email protected]>
Reviewed-by: Noel Power <[email protected]>

20e0ce50

s3/script/tests: Ensure all remote test files are removed · 16ffa17e

Jeremy Allison authored Nov 30, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Jeremy Allison <[email protected]>
Reviewed-by: Noel Power <[email protected]>

16ffa17e

s3/script/tests: call smbclient deltree to remove remote files · 6c7dc495

Noel Power authored Nov 30, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

6c7dc495

s3/script/tests: Make smb_client 'die' behaviour configurable · 363bfa4e

Noel Power authored Nov 30, 2020

smb_client behaviour is to die if there is an error. This is
a little heavy handed and make it impossible for example to
use smb_client to run a command that might fail (where such
a failure isn't really an error) E.G. Calling deltree and
the directory doesn't exist

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

363bfa4e

s3/script/tests: Remove make_path (for remote dir) · 99ffa4a9

Noel Power authored Nov 30, 2020

LOCALPATH is actually the local path to the share, we should
not need to create the share path (it should already exist)

Note: When we remove the tree located at LOCALPATH we keep the root
so the share path should always be there

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

99ffa4a9

selftest: make samba3.blackbox.smbclient_tar runnable (even manually) · 6f246658

Noel Power authored Nov 30, 2020

samba3.blackbox.smbclient_tar is marked as flapping so it
seems we have missed that it has stopped working. The local path
passed to script/tests/test_smbclient_tarmode.pl must point to a
valid share

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

6f246658

s3/script/tests: Fix samba3.blackbox.smbclient_tarmode cleanup · 4bb3bffa

Noel Power authored Nov 30, 2020

Make sure samba3.blackbox.smbclient_tarmode removes data files
not just before running the test but also after

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

4bb3bffa

s3/script: Use smbclient deltree to clean up smbclient_tarmode subdir · fec1f8fa

Noel Power authored Nov 27, 2020

Replace rm -rf of local dir (that is hosted remotely)
with smbclient deltree

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

fec1f8fa

s3/script/tests: Use tarmode share for samba3.blackbox.smbclient_tar* · be8dca68

Noel Power authored Nov 27, 2020

After this change both samba3.blackbox.smbclient_tar &
samba3.blackbox.smbclient_tarmode now use the same dedicated share

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

be8dca68

s3/script/test: Use different testdir for samba3.blackbox.smbclient_tarmode · 6cb0a00f

Noel Power authored Nov 27, 2020

The other tarmode torture test samba3.blackbox.smbclient_tar now uses a share
'tarmode' which uses the same source path as samba3.blackbox.smbclient_tarmode

Avoid conflicting paths and use a new subdir (of the test share) called
'smbclient_tarmode'

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

6cb0a00f

selftest: Add a new tarmode shares · a250f733

Noel Power authored Nov 26, 2020

samba3.blackbox.smbclient_tar & samba3.blackbox.smbclient_tar
need separate shares with own xattr tdb(s)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

a250f733

s3/script/tests: Fix 'Unrecognized option(s) passed to mkpath()' error · 4f5a7f11

Noel Power authored Nov 27, 2020

'keep_root' is an unrecognised option for make_path/mkpath

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14581Signed-off-by: Noel Power <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

4f5a7f11

30 Nov, 2020 21 commits

test: Fix the FreeBSD build · b09f0bb4

VL authored Nov 26, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

Autobuild-User(master): Jeremy Allison <[email protected]>
Autobuild-Date(master): Mon Nov 30 23:48:02 UTC 2020 on sn-devel-184

b09f0bb4

smbd: Fix the 32-bit build on FreeBSD · efb3c742

VL authored Nov 26, 2020

log->rec_index is not size_t, it's uint64_t
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

efb3c742

wbinfo: Align some integer types · cff22bcc

VL authored Nov 26, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

cff22bcc

lib: Change make_file_id_from_itime() prototype · 05f7558b

VL authored Nov 23, 2020

SMB_STRUCT_STAT is defined in includes.h. This way including file_id.h
is possible without including includes.h
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

05f7558b

torture: Align integer types · 7bd51217

VL authored Nov 23, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

7bd51217

libsmb: Slightly beautify internal_resolve_name() · f0311358

VL authored Nov 24, 2020

We have "goto done;" at the end of every if-branch, we don't need
else.
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

f0311358

libsmb: Move a variable closer to its use in internal_resolve_name() · d82cd10f
VL authored Nov 24, 2020
```
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
```
d82cd10f

samldb: Align two integer types · d1be9eee

VL authored Nov 25, 2020

ARRAY_SIZE is size_t
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

d1be9eee

test: smbtorture3's OPLOCK5 test only available with kernel oplocks · e098610d
VL authored Nov 26, 2020
```
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
```
e098610d

libsmb: Align integer types · 7fc62fd1

VL authored Nov 23, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

7fc62fd1

libsmb: Fix a typo · f85adfb2

VL authored Nov 21, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

f85adfb2

winbind: Align integer types · 5a0baf49

VL authored Nov 21, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

5a0baf49

libcli: Align integer types · fce49f4a

VL authored Nov 14, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

fce49f4a

librpc: talloc_stackframe() panics on failure · 38a0724f

VL authored Nov 14, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

38a0724f

librpc: Make ep_register a bit easier to understand · fd124648

VL authored Nov 14, 2020

I found the pointer dereference a bit confusing
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

fd124648

librpc: Fix a talloc_stackframe() leak · f53117e0

VL authored Nov 14, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

f53117e0

libcli: Align a few integer types · a41112fc

VL authored Nov 29, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

a41112fc

docs: Fix "async dns timeout" manpage entry · 5c81a5a0

VL authored Nov 29, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

5c81a5a0

loadparm: Simplify lp_get_async_dns_timeout() · ccb7d444

VL authored Nov 29, 2020

Use MAX, and per README.Coding we don't need the intermediate
variable. This can be inspected in the debugger directly.
Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

ccb7d444

dsgetdcname: Fix talloc hierarchy · a613ebc0

VL authored Nov 27, 2020

Signed-off-by: Volker Lendecke <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

a613ebc0

tests python krb5: Extra canonicalization tests · 7f7e2b0e

Gary Lockyer authored Nov 18, 2020

Add tests that set the server name to the client name for the machine
account in the kerberos AS_REQ.  This replicates the TEST_AS_REQ_SELF
test phase in source4/torture/krb5/kdc-canon-heimdal.c.
Signed-off-by: Gary Lockyer <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>

Autobuild-User(master): Andrew Bartlett <[email protected]>
Autobuild-Date(master): Mon Nov 30 05:21:42 UTC 2020 on sn-devel-184

7f7e2b0e

27 Nov, 2020 3 commits

vfs_glusterfs: print exact cmdline for disabling write-behind translator · 369c1d53

Günther Deschner authored Nov 24, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486

Guenther
Signed-off-by: Guenther Deschner <[email protected]>
Reviewed-by: Anoop C S <[email protected]>

Autobuild-User(master): Günther Deschner <[email protected]>
Autobuild-Date(master): Fri Nov 27 17:15:07 UTC 2020 on sn-devel-184

369c1d53

docs-xml: Add a section about weak crypto in testparm manpage · 5c27740a

Andreas Schneider authored Nov 27, 2020

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14583Signed-off-by: Andreas Schneider <[email protected]>
Reviewed-by: Alexander Bokovoy <[email protected]>

Autobuild-User(master): Andreas Schneider <[email protected]>
Autobuild-Date(master): Fri Nov 27 13:48:20 UTC 2020 on sn-devel-184

5c27740a

s4: rename source4/smbd/ to source4/samba/ · 4142bde7

Ralph Böhme authored Nov 20, 2020

Signed-off-by: Ralph Boehme <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>

Autobuild-User(master): Ralph Böhme <[email protected]>
Autobuild-Date(master): Fri Nov 27 10:07:18 UTC 2020 on sn-devel-184

4142bde7

26 Nov, 2020 1 commit

samba-tool: Give better error information when the 'domain backup restore'... · 8ad82ae6

Andrew Bartlett authored Nov 13, 2020

samba-tool: Give better error information when the 'domain backup restore' fails with a duplicate SID

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14575Signed-off-by: Andrew Bartlett <[email protected]>
Reviewed-by: Gary Lockyer <[email protected]>

Autobuild-User(master): Gary Lockyer <[email protected]>
Autobuild-Date(master): Thu Nov 26 21:15:40 UTC 2020 on sn-devel-184

8ad82ae6