Commits · master · The Samba Team / Upstream Samba Development / samba

This project is mirrored from https://gitlab.com/samba-team/samba.git. Pull mirroring updated Feb 06, 2023.

03 Feb, 2023 10 commits

pidl: avoid py compile issues with --pidl-developer · e26a01a4

Douglas Bagnall authored Dec 09, 2022 and

Andrew Bartlett committed Feb 03, 2023

We get these warnings-as-errors:

librpc/gen_ndr/py_netlogon.c:61903:53: error: stray ‘\’ in program
61903 | PyErr_Format(PyExc_TypeError, "Expected type %s",\ //<PIDL> Parse::Pidl::Samba4::Python::ConvertObjectFromPythonData lib/Parse/Pidl/Samba4/Python.pm:2005

but the '\' is unnecessary and unconventional anyway, since we're in a
function argument list.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb 3 03:27:54 UTC 2023 on atb-devel-224

e26a01a4

tevent/pytevent: remove no-op define · b2a2eeb6
Douglas Bagnall authored Feb 01, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
b2a2eeb6
tevent/pytevent: remove py2 ifdefs · 8f2f3b00
Douglas Bagnall authored Feb 01, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
8f2f3b00
tdb/pytdb: remove useless HAVE_ITER non-flag · c0ef6ca9
Douglas Bagnall authored Feb 01, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
c0ef6ca9

tdb/pytdb: remove py ifdefs · f5555e0e

Douglas Bagnall authored Feb 01, 2023 and

Andrew Bartlett committed Feb 03, 2023



This already would not compile with Python 2, because Py_TPFLAGS_HAVE_ITER
is not defined

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

f5555e0e

s4/ndr/py_security: remove python 2 ifdefs · 310eafdb
Douglas Bagnall authored Feb 01, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
310eafdb
s4/ndr/py_misc: remove python 2 ifdefs · ddbe69af
Douglas Bagnall authored Feb 01, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
ddbe69af

ldb/pyldb: remove py2 ifdefs · 38d0147f

Douglas Bagnall authored Feb 01, 2023 and

Andrew Bartlett committed Feb 03, 2023



Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

38d0147f

gp: Test samba-tool gpo cse register/unregister/list · 5723737e
David Mulder authored Jan 13, 2023 and Andrew Bartlett committed Feb 03, 2023
```
Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
```
5723737e

gp: samba-tool gpo cse register/unregister/list · 3eee4415

David Mulder authored Jan 13, 2023 and

Andrew Bartlett committed Feb 03, 2023



Add samba-tool commands for managing registration
of Client Side Extensions.

Signed-off-by: David Mulder <dmulder@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

3eee4415

02 Feb, 2023 8 commits

Python: remove pydoctor · 851127f5

Rob van der Linde authored Jan 30, 2023 and

Jeremy Allison committed Feb 02, 2023



Removes:

* waf pydoctor
* waf wafdocs
* make pydoctor

There is no "make wafdocs" it only appears to be in wscript.

The reasoning being is these are broken and appear to not have been run for some time.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb  2 21:15:54 UTC 2023 on atb-devel-224

851127f5

mdssvc: fix kMDScopeArray parsing · 1dd0cd2f

Ralph Böhme authored Jan 18, 2023 and

Jeremy Allison committed Feb 02, 2023

In macOS Ventura marshalling of kMDScopeArray in the "openQueryWithParams"
request has changed from

  string: kMDScopeArray
  sl_array_t(#1): {
    string: /foo/bar
  }

to:

  string: kMDScopeArray
  sl_array_t(#1): {
    sl_array_t(#1): {
      string: /foo/bar
    }
  }

With this patch we check both encodings. Bug fixed according to user feedback.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15299


RN: Spotlight doesn't work with latest macOS Ventura

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

1dd0cd2f

tevent: version 0.14.1 · d80f28b0

Stefan Metzmacher authored Feb 01, 2023 and

Jeremy Allison committed Feb 02, 2023



- Build fix for GNU/Hurd
- Build fix for Solaris, after removal
  of ports backend (bug #15298)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb  2 18:27:08 UTC 2023 on atb-devel-224

d80f28b0

tevent: remove the already removed tevent_port.c also from the build · ae77854a

Stefan Metzmacher authored Feb 01, 2023 and

Jeremy Allison committed Feb 02, 2023

This fixes a regression introduced by 147a317b.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15298



Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

ae77854a

replace: remove unused configure checks for port_create() · 488aa227

Stefan Metzmacher authored Feb 01, 2023 and

Jeremy Allison committed Feb 02, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15298



Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

488aa227

replace: provide PIPE_BUF on GNU/Hurd · 15b1afc9

Samuel Thibault authored Aug 02, 2020 and

Jeremy Allison committed Feb 02, 2023



There is no hardcoded PIPE_BUF pipe limitation on GNU/Hurd, but POSIX
provides a minimum value that we can use.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

15b1afc9

s3:utils: Fix UNUSED_VALUE · 65e9b409

Pavel Filipenský authored Feb 02, 2023 and

Ralph Böhme committed Feb 02, 2023

Reported by RedHat internal Covscan

Since cb8a0d9a

 we no longer stop traversing the list if encryption_flag
or signing_flags are unknown.

Assignment "result = -1;" is always overwritten by
"result = traverse_connections_*()" and is a dead code.

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Feb  2 15:46:52 UTC 2023 on atb-devel-224

65e9b409

s3:utils: Fix trailing whitespaces · 4d83e9fc
Pavel Filipenský authored Feb 02, 2023 and Ralph Böhme committed Feb 02, 2023
```
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
```
4d83e9fc

31 Jan, 2023 22 commits

s4-drsuapi: Give an error that matches windows on destination_dsa_guid lookup failure · 0f2978bb

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jan 31 13:43:54 UTC 2023 on atb-devel-224

0f2978bb

s4-drsuapi: Clarify role of drs_security_access_check_nc_root() · 1838f349

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

1838f349

s4-rpc_server: Pre-check destination_dsa_guid in GetNCChanges for validity · 115a3a10

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This allows our new tests to pass as these need to be checked first.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

115a3a10

s4-drsuapi: Use samdb_get_ntds_obj_by_guid() to find RODC in REPL_SECRET · 09ec6a1d

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

We need to find the RODC per the destination_dsa_guid to mark the secrets as
having been replicated, and by using samdb_get_ntds_obj_by_guid() we are stricter
in the checks, as the RODC has to be the right objectClass (nTDSDSA) and under
the CN=Configuration partition.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

09ec6a1d

s4-dsdb: Require that the NTDS object is an nTDSDSA objectclass · adb77614

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This should avoid a user being able to specify the GUID of a different
type of object.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

adb77614

s4-dsdb: Split samdb_get_ntds_obj_by_guid() out of samdb_is_rodc() · d5a2af3f

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This will allow the logic here to be tighened up and shared
in the next few commits.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d5a2af3f

s4-rpc_server/drsuapi: Return correct error code for an invalid DN to EXOP_REPL_OBJ/EXOP_REPL_OBJ · cbe18353
Andrew Bartlett authored Dec 16, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
cbe18353

s4-drs: Make drs_ObjectIdentifier_to_dn() safer and able to cope with DummyDN values · 73f3ece8

Andrew Bartlett authored Jan 31, 2023 and

Stefan Metzmacher committed Jan 31, 2023

We want to totally ignore the string DN if there is a GUID,
as clients like "Microsoft Azure AD connect cloud sync" will
set a literal "DummyDN" string.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

73f3ece8

s4-dsdb: rework drs_ObjectIdentifier_to_dn() into drs_ObjectIdentifier_to_dn_and_nc_root() · aee2039e

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This make this funciton the gatekeeper between the wire format and the
internal struct ldb_dn, checking if the DN exists and which NC
it belongs to along the way, and presenting only a DB-returned
DN for internal processing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

aee2039e

s4-rpc_server/drsuapi: Use dsdb_normalise_dn_and_find_nc_root() · e96dfc74

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This reuses the search done for dsdb_find_nc_root() to normalise the DN.

This will allow a GUID-input DN to be compared safely with a RID Manager DN
or Naming Context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

e96dfc74

s4-dsdb: Add dsdb_normalise_dn_and_find_nc_root() around dsdb_find_nc_root() · 8e112242

Andrew Bartlett authored Dec 12, 2022 and

Stefan Metzmacher committed Jan 31, 2023

Reuse the search done for dsdb_find_nc_root() to normalise the DN.

This will allow a GUID-input DN to be compared safely with a RID Manager DN
or Naming Context.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

8e112242

s4-dsdb: Add better debugging to dsdb_objects_have_same_nc() · 0f501b23

Andrew Bartlett authored Dec 15, 2022 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

0f501b23

s4-dsdb: Make dsdb_find_nc_root() first try and use DSDB_CONTROL_CURRENT_PARTITION_OID · d0444be4

Andrew Bartlett authored Dec 05, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This allows lookup of a DN with a GUID only or GUID and string,
possibly not yet in the database, yet still getting the correct result.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d0444be4

s4-dsdb: Schedule SD propegation only after successful rename · 7032b86c

Andrew Bartlett authored Jan 26, 2023 and

Stefan Metzmacher committed Jan 31, 2023

This avoids needing to anticipate errors that the rename might give
while allowing the dsdb_find_nc_root() routine to become stricter.

The problem is that dsdb_find_nc_root() will soon do a real search and
so fail more often, but these failures will give "wrong" error codes.

We do not need to do this work if the operation fails, so put this in
the callback.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

7032b86c

s4-selftest/drs: Confirm GetNCChanges REPL_SECRET works with a DummyDN and real GUID · 7c433885
Andrew Bartlett authored Dec 15, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
7c433885
s4-selftest/drs: Confirm GetNCChanges full replication works with a DummyDN and real GUID · 539221dd
Andrew Bartlett authored Dec 15, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
539221dd
s4-selftest/drs: Confirm GetNCChanges REPL_OBJ works with a DummyDN and real GUID · 70faccae
Andrew Bartlett authored Dec 02, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
70faccae

s4-selftest/drs Allow re-run of DRS tests after failed cleanup · 3204d135

Andrew Bartlett authored Dec 02, 2022 and

Stefan Metzmacher committed Jan 31, 2023

Using a random base is a useful start, even if the better solution also includes a self.AddCleanup()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

3204d135

s4-selftest/drs Allow some DRS tests to operate against an IP · a150a2dc

Andrew Bartlett authored Dec 02, 2022 and

Stefan Metzmacher committed Jan 31, 2023

This is not comprehensive, but makes some manual test runs easier by
avoiding the need for DNS names to resolve.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

a150a2dc

s4-selftest/drs Add test of expected return code for invaid DNs in GetNCChanges · bee45e6b
Andrew Bartlett authored Dec 02, 2022 and Stefan Metzmacher committed Jan 31, 2023
```
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
```
bee45e6b

s4-dsdb: Add tests of SamDB.get_nc_root() · 2c7bb587

Andrew Bartlett authored Dec 15, 2022 and

Stefan Metzmacher committed Jan 31, 2023

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10635



Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

2c7bb587

s4-dsdb: Rework dsdb_find_dn_by_guid() to use GUID_buf_string() · d43adae8

Andrew Bartlett authored Jan 25, 2023 and

Stefan Metzmacher committed Jan 31, 2023



This avoids a talloc_strdup() and so a failure path.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

d43adae8