This project is mirrored from https://gitlab.com/samba-team/samba.git.
Pull mirroring updated .
- 30 Jun, 2020 3 commits
-
-
Andrew authored
Add check for failure to resolve the OID array for the schema mode into names. Signed-off-by:Andrew <awalker@ixsystems.com>
-
Isaac Boukris authored
detected by covscan: source3/locking/share_mode_lock.c:1563:6: warning: Branch condition evaluates to a garbage value Signed-off-by:
Isaac Boukris <iboukris@samba.org> Reviewed-by:
David Mulder <dmulder@suse.com> Autobuild-User(master): Isaac Boukris <iboukris@samba.org> Autobuild-Date(master): Tue Jun 30 09:42:33 UTC 2020 on sn-devel-184
-
Guenther Signed-off-by:
Guenther Deschner <gd@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org> Autobuild-User(master): Anoop C S <anoopcs@samba.org> Autobuild-Date(master): Tue Jun 30 07:51:48 UTC 2020 on sn-devel-184
-
- 29 Jun, 2020 1 commit
-
-
Björn Jacke authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14422 Signed-off-by:
Bjoern Jacke <bjacke@samba.org> Reviewed-by:
Ralph Boehme <slow@samba.org> Autobuild-User(master): Björn Jacke <bjacke@samba.org> Autobuild-Date(master): Mon Jun 29 18:19:04 UTC 2020 on sn-devel-184
-
- 27 Jun, 2020 12 commits
-
-
Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: 
Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jun 27 05:42:05 UTC 2020 on sn-devel-184 -
Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This test doesn't need multi-channel. But we need to force using the channel_sequence, as our client libraries only use them for multi-channel connections or persistent handles. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This means we can test the lock sequence checking via the 'samba3.smb2.lock aio(nt4_dc)' test. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
While windows enables it only for resilient and persistent handles a SMB server SHOULD (according to MS-SMB2 section 3.3.5.14 ) activate processing of lock sequence numbers: ... if Open.IsResilient or Open.IsDurable or Open.IsPersistent is TRUE or if Connection.Dialect belongs to the SMB 3.x dialect family and Connection.ServerCapabilities includes SMB2_GLOBAL_CAP_MULTI_CHANNEL ... We only support durable handles or multichannel, so we only implement these according to the specification. But we have 'smb2 disable lock sequence checking = yes' to force to match the Windows Server bahavior, which only supports this for resilient and persistent handles. Pair-Programmed-With: Michael Adam <obnox@samba.org> Pair-Programmed-With: Guenther Deschner <gd@samba.org> Signed-off-by:
Michael Adam <obnox@samba.org> Signed-off-by:
Guenther Deschner <gd@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
Take the value from the client if the dialect is SMB2_10 or higher, otherwise default to 0. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This is way to mark an entry as invalid (.valid = false). Pair-Programmed-With: Michael Adam <obnox@samba.org> Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This is needed for lock replay detection. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This implements a test that checks for the specified behaviour. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
This test checks the SMB 2.1.0 behaviour of lock sequence checking, which is only turned on for resilient handles. Even Windows Server 2019 only implements lock sequence checking only for resilient and persistent handles as a server. While its client side uses lock sequence checking if it negotiated multichannel with the server. Hopefully this will be fixed in future Windows versions. Make it clear that this test is supposed to pass against the legacy Windows servers which violate the specification: [MS-SMB2] 3.3.5.14 Receiving an SMB2 LOCK Request ... ... if Open.IsResilient or Open.IsDurable or Open.IsPersistent is TRUE or if Connection.Dialect belongs to the SMB 3.x dialect family and Connection.ServerCapabilities includes SMB2_GLOBAL_CAP_MULTI_CHANNEL bit, the server SHOULD<314> perform lock sequence verification ... ... <314> Section 3.3.5.14: Windows 7 and Windows Server 2008 R2 perform lock sequence verification only when Open.IsResilient is TRUE. Windows 8 through Windows 10 v1909 and Windows Server 2012 through Windows Server v1909 perform lock sequence verification only when Open.IsResilient or Open.IsPersistent is TRUE. Note <314> also applies to all versions (at least) up to Windows Server v2004. Hopefully this will be fixed in future Windows versions and they will avoid Note <314>. Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org> -
The test was wrong in that it used an invalid lock sequence bucket (65) where it actually wanted to use a valid on (64), and hence the test results (which were adapted to the real responses) were not quite logical. This patch fixes this and also improves some of the comments so that the flow of the patch becomes a little more obvious. Pair-Programmed-With: Günther Deschner <gd@samba.org> Signed-off-by:
Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
-
- 24 Jun, 2020 7 commits
-
-
Because this test returned true, it would always succeed, despite failures in the test. Make it return false if there are failures. Also, removed a stray CHECK_MAX_FAILURES introduced by commit 8773e743 that caused the test to *always* fail (but always be ignored). Signed-off-by:
-
Signed-off-by:
Noel Power <noel.power@suse.com>
-
Signed-off-by:
-
Signed-off-by:
-
Jeremy Allison authoreds3: smbd: Allow a SHUTDOWN_CLOSE on a file with outstanding aio if there are no client connections alive. The process is exiting now so pthreads will never complete to cause problems. Remove the knownfail.d/aio_outstanding entry. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by:
Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Jun 24 20:14:15 UTC 2020 on sn-devel-184
-
Jeremy Allison authored
We will need to this ensure our client connections are terminated in close_file before exiting with outstanding aio. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by:
Jeremy Allison <jra@samba.org>
Reviewed-by: -
Jeremy Allison authored
Shows smbd panics if connection is terminated (torn down) by killing the client with outstanding aio requests in the queue. As we're closing smbd we should cope with this. Followup-bugfix for: BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by:
Jeremy Allison <jra@samba.org>
Reviewed-by:
-
- 23 Jun, 2020 11 commits
-
-
Signed-off-by:
Alexander Bokovoy <ab@samba.org> Autobuild-User(master): David Mulder <dmulder@samba.org> Autobuild-Date(master): Tue Jun 23 17:53:22 UTC 2020 on sn-devel-184
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Create a parent class for parsing Registry.pol files by group policy extensions. Signed-off-by:
-
Openpam will log an error message when it receives an unexpected response. On servers using openpam, convert an unexpected response into PAM_SERVICE_ERR and log what we're doing so that logging behavior is more user-configurable. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14416 Signed-off-by:
Andreas Schneider <asn@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Jun 23 08:08:29 UTC 2020 on sn-devel-184
-
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11897 Signed-off-by:
Stefan Metzmacher <metze@samba.org>
Reviewed-by: -
The current code attempts a SAMR based password set for all errors, we want to continue on LDAP or local LDB (in the restore case) unless we really got the specific error given by Windows 2000. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14414 Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by:
-
libcli/ldap/tests/ldap_message_test.c defines a zero length array (uint8_t buf[0]), which is a GCC extension and breaks the build with some strict compilers like xlc. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14387 Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jun 23 02:15:35 UTC 2020 on sn-devel-184 -
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406 Signed-off-by:
Andrew Bartlett <abartlet@samba.org>
-
- 22 Jun, 2020 6 commits
-
-
Signed-off-by:
-
Signed-off-by:
-
https://bugs.centos.org/view.php?id=16549 Signed-off-by:
-
The auto-generated define NT_STATUS_EA_LIST_INCONSISTENT is still available. Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
-
The auto-generated define NT_STATUS_STOPPED_ON_SYMLINK is still available. Signed-off-by:
-
The auto-generated define NT_STATUS_PENDING is still available. Signed-off-by:
-
