1. 20 Aug, 2018 1 commit
  2. 05 Aug, 2018 4 commits
    • Volker Braun's avatar
      Updated SageMath version to 8.4.beta0 · ada43b34
      Volker Braun authored
    • Release Manager's avatar
      Trac #25897: Incorrect Comparison of embedding index in projective_embedding · 5a9630a7
      Release Manager authored
      Consider this example:
      sage: A.<x,y> = AffineSpace(ZZ, 2)
      sage: A.projective_embedding(4)
            1 A = AffineSpace(ZZ, Integer(2), names=('x', 'y',)); (x, y,) =
      ----> 2 A.projective_embedding(Integer(3))
      packages/sage/schemes/affine/affine_space.pyc in
      projective_embedding(self, i, PP)
          724         self.__projective_embedding[i] = phi
          725         #make affine patch and projective embedding match
      --> 726         PP.affine_patch(i,self)
          727         return phi
      packages/sage/schemes/projective/projective_space.pyc in
      affine_patch(self, i, AA)
          978         n = self.dimension_relative()
          979         if i < 0 or i > n:
      --> 980             raise ValueError("argument i (= %s) must be between
      0 and %s"%(i, n))
          981         try:
          982             A = self.__affine_patches[i]
      ValueError: argument i (= 3) must be between 0 and 2
      This however returns a `ValueError`, but only when the affine patch is
      generated for corresponding `ProjectiveSpace`. It simply skips the check
      for index in projective_embedding().
      Following line in projective_embedding needs to be corrected:
              if n < 0 or n >self.dimension_relative():
                  raise ValueError("argument i (=%s) must be betwzzeen 0 and
      %s, inclusive"%(i,n))
      URL: https://trac.sagemath.org/25897
      Reported by: raghukul01
      Ticket author(s): Raghukul Raman
      Reviewer(s): Ben Hutz
    • Release Manager's avatar
      Trac #25895: LatticePoset, optimize congruence-related functions for trivial cases · 2220712b
      Release Manager authored
      This patch adds an internal function to find "double-double
      -irreducible". To be used for counting out trivial cases for
      `is_isoform` etc.
      URL: https://trac.sagemath.org/25895
      Reported by: jmantysalo
      Ticket author(s): Jori Mäntysalo
      Reviewer(s): Travis Scrimshaw
    • Release Manager's avatar
      Trac #25893: some care for sphinx warnings · 7a3b5b69
      Release Manager authored
      but not all of them..
      URL: https://trac.sagemath.org/25893
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
  3. 03 Aug, 2018 35 commits