1. 29 Jan, 2019 1 commit
  2. 26 Jan, 2019 25 commits
    • Volker Braun's avatar
      Updated SageMath version to 8.7.beta1 · 0cb49428
      Volker Braun authored
      0cb49428
    • Release Manager's avatar
      Trac #12908: unnecessary blank in latex expression of multivariate polynomial · 2b5a07f5
      Release Manager authored
      In the LaTeX representation of a multivariate polynomial is an
      unnecessary blank when variable is concatenated with a {{{-}}}, see
      {{{
      sage: R.<X,Y> = ZZ[]
      sage: latex(X-Y)
      X -  Y
      sage: latex(X^2-X)
      X^{2} -  X
      }}}
      It does not happen with {{{+}}}
      {{{
      sage: latex(X+Y)
      X + Y
      }}}
      or with a constant
      {{{
      sage: latex(X-1)
      X - 1
      }}}
      In the univarate case the problem does not appear.
      
      Note that this "wrong" output is no problem (i.e. a correct input for
      LaTeX)
      
      URL: https://trac.sagemath.org/12908
      Reported by: dkrenn
      Ticket author(s): André Apitzsch
      Reviewer(s): Debbie Matthews, Erik Bray, Emmanuel Charpentier
      2b5a07f5
    • Release Manager's avatar
      Trac #27077: enable conversion of Matrix from maple to sage · 27fe4f14
      Release Manager authored
      URL: https://trac.sagemath.org/27077
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      27fe4f14
    • Release Manager's avatar
      Trac #27068: Fix a typo in doc of Lascoux-Schützenberger action · 3897fef6
      Release Manager authored
      The doc of the `symmetric_group_action_on_values` method on `Tableau`
      has a "left" that should be a "right".
      
      While at that, I've documented the helper functions too, since I found
      myself using them. If I had more time, I'd also expose the
      `symmetric_group_action_on_values` through the `Word` class.
      
      URL: https://trac.sagemath.org/27068
      Reported by: gh-darijgr
      Ticket author(s): Darij Grinberg
      Reviewer(s): Travis Scrimshaw
      3897fef6
    • Release Manager's avatar
      Trac #27061: Fix sage.misc.inline_fortran with Numpy 1.16 · a05b6b03
      Release Manager authored
      Numpy 1.16 introduced a slight backwards incompatibility such that the
      way we were calling f2py.compile() would no longer work for capturing a
      log of the f2py output.
      
      It turns out f2py.compile() doesn't do anything very interesting anyways
      and has many redundancies with what we do here: It's easy to call f2py
      in a subprocess ourselves with the correct arguments and handle the
      output.
      
      URL: https://trac.sagemath.org/27061
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Jeroen Demeyer
      a05b6b03
    • Release Manager's avatar
      Trac #26989: some cleanup around if statements · d75becd6
      Release Manager authored
      There are a few places with code like
      {{{
      if(something):
      }}}
      This is turned into more pythonic shape.
      
      URL: https://trac.sagemath.org/26989
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jeroen Demeyer
      d75becd6
    • Release Manager's avatar
      Trac #26984: fix invalid escape sequences (once again) · 3715387a
      Release Manager authored
      URL: https://trac.sagemath.org/26984
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jori Mäntysalo
      3715387a
    • Release Manager's avatar
      Trac #26926: Add to the reviewer's checklist: look at the built documentation · 6ed6c98e
      Release Manager authored
      Reviewers should look at the built documentation to catch reST errors
      that don't stop the build but cause the docs to looks bad. One example:
      using {{{`some_code`}}} for source code instead of {{{``some_code``}}} –
      single quotes cause the contents to be set in math mode, and then the
      underscore will cause a subscript, which is probably not what was
      intended.
      
      URL: https://trac.sagemath.org/26926
      Reported by: jhpalmieri
      Ticket author(s): John Palmieri
      Reviewer(s): Jeroen Demeyer
      6ed6c98e
    • Release Manager's avatar
      Trac #26710: interact `text_control` should use HTMLMath not HTML · dd746828
      Release Manager authored
      `text_control` in the following does not typeset `$A$` in
      `text_control`.
      {{{
      @interact
      def _(a=text_control("Put a matrix $A$"), b=input_grid(2,2,
      default=[[1,2],[3,4]], label='')):
          m = matrix(b)
          print(m)
      }}}
      
      Sage in jupyter use `HTML` widget to render `text_control`. The widget
      `HTML` does not typeset maths. We should switch to `HTMLMath`.
      
      By the way,  the above example reveals abother defect. `label` with
      empty string does not make the label of the `input_grid` blank, unlike
      as expected.
      
      URL: https://trac.sagemath.org/26710
      Reported by: klee
      Ticket author(s): Kwankyu Lee
      Reviewer(s): Jeroen Demeyer
      dd746828
    • Release Manager's avatar
      Trac #26706: Document how to build Sage with Python3 · 2ffb8c18
      Release Manager authored
      In the README.md, we could have 2 lines for explaining how to build with
      Python 3, like (for instance):
      
      instead of just:
      {{{
      To start the build, type make.
      }}}
      
      have:
      {{{
      To start the build, type `make`.
      
      In case you want to run Sage on Python 3 -- WARNING:
      for beta-testing purpose --, you can then type:
      `make configure && ./configure --with-python=3 && make`.
      }}}
      
      URL: https://trac.sagemath.org/26706
      Reported by: zerline
      Ticket author(s): Samuel Lelièvre
      Reviewer(s): Odile Bénassy
      2ffb8c18
    • Release Manager's avatar
      Trac #26655: Convert PARI matrices over finite fields into Sage matrix spaces · 2c5001a1
      Release Manager authored
      It should be possible to convert PARI matrices over finite fields into a
      Sage matrix space:
      {{{
      sage: F.<a> = GF(9)
      sage: M = MatrixSpace(F, 2, 2)
      sage: A = M.random_element()
      sage: M(A.__pari__())
      Traceback (most recent call last):
      ...
      NameError: name 'a' is not defined
      }}}
      
      This ticket deliberately does not attempt to fix conversion of PARI
      `t_VEC`/`t_COL` etc. to Sage matrices.  Maybe this should even be
      deprecated (there is a risk of confusion since Sage uses row-major order
      and PARI uses column-major order).
      
      URL: https://trac.sagemath.org/26655
      Reported by: pbruin
      Ticket author(s): Peter Bruin
      Reviewer(s): Jeroen Demeyer
      2c5001a1
    • Release Manager's avatar
      Trac #25629: Bad latex translation of output · c2cdf7c6
      Release Manager authored
      sage 8.3 beta 6.
      
      {{{
          sage: var('t')
          sage: anti=integrate(exp(t)*log(1+t),t)
          sage: anti
          e^(-1)*exp_integral_e(1, -t - 1) + e^t*log(t + 1)
      
          sage: latex(anti)
          e^{\left(-1\right)} exp_integral_e\left(1, -t - 1\right) + e^{t}
      \log\left(t + 1\right)
      
      }}}
      
      The latex above is not good at all. It renders as (do not know how to
      inser images here).
      
      Which is not good. May be sage needs to use a `\DeclareMathOperator` on
      `exp_integral_e`
      
      URL: https://trac.sagemath.org/25629
      Reported by: gh-nasser1
      Ticket author(s): Durgesh Agrawal
      Reviewer(s): Alex J. Best
      c2cdf7c6
    • Release Manager's avatar
      Trac #27105: fix tiny details in build/pkgs · 6a68d03c
      Release Manager authored
      found by lgtm
      
      URL: https://trac.sagemath.org/27105
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Erik Bray
      6a68d03c
    • Release Manager's avatar
      Trac #27104: remove useless pass commands · 5268d999
      Release Manager authored
      found by lgtm
      
      URL: https://trac.sagemath.org/27104
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      5268d999
    • Release Manager's avatar
      Trac #27101: fix minor details in hyperbolic space and hyperplane arrangement · fb43dca7
      Release Manager authored
      found using **lgtm**
      
      URL: https://trac.sagemath.org/27101
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      fb43dca7
    • Release Manager's avatar
      Trac #27100: remove some self imports in quivers · fabc3fc9
      Release Manager authored
      found by lgtm
      
      https://lgtm.com/projects/g/sagemath/sage/latest/
      
      URL: https://trac.sagemath.org/27100
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      fabc3fc9
    • Release Manager's avatar
      Trac #27097: Remove IndexedFreeModuleElement._coefficient_fast · 506d8140
      Release Manager authored
      The method `IndexedFreeModuleElement._coefficient_fast` serves no
      purpose at all:
      
      1. It actually makes `__getitem__` slower because of the extra
      indirection.
      
      2. Special methods like `__getitem__` in extension classes are very fast
      already, as fast as Cython `cdef` functions.
      
      3. When called from Python (not Cython), a special method is much faster
      than a method.
      
      4. It is called in only one place (namely `__getitem__`), so even if it
      would be faster, its usage is dubious.
      
      Since this is a private underscored method, we can just remove it
      without deprecation.
      
      Furthermore, the implementation of `__getitem__` can be improved by only
      computing `self.base_ring().zero()` if needed.
      
      Finally, in the category `ModulesWithBasis`, I am also removing
      `ElementMethods.__getitem__` because it doesn't seem to be used anywhere
      (to be checked by the patchbot).
      
      URL: https://trac.sagemath.org/27097
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      506d8140
    • Release Manager's avatar
      Trac #27093: type_debug: support subtype_dealloc, subtype_clear, subtype_traverse · 37f7465e
      Release Manager authored
      Support the default `tp_dealloc`, `tp_clear`, `tp_traverse` functions
      for heap types (a.k.a. Python classes). This is not exported by Python,
      but we can dynamically determine it.
      
      With this patch, one has for example
      {{{
      sage: class X(object): pass
      sage: type_debug(X)
      <class '__main__.X'> (0x7fe42bfc3a80)
        ob_refcnt: 5
        ob_type: <type 'type'>
        tp_name: X
        tp_basicsize: 32
        tp_itemsize: 0
        tp_dictoffset: 16
        tp_weaklistoffset: 24
        tp_base (__base__): <type 'object'>
        tp_bases (__bases__): tuple:
          <type 'object'>
        tp_mro (__mro__): tuple:
          <class '__main__.X'>
          <type 'object'>
        tp_dict (__dict__): dict:
          '__dict__': <attribute '__dict__' of 'X' objects>
          '__module__': '__main__'
          '__weakref__': <attribute '__weakref__' of 'X' objects>
          '__doc__': None
        tp_alloc: PyType_GenericAlloc
        tp_new (__new__): == object
        tp_init (__init__): == object
        tp_dealloc (__dealloc__): subtype_dealloc
        tp_del (__del__): NULL
        tp_free: PyObject_GC_Del
        tp_repr (__repr__): == object
        tp_print: NULL
        tp_hash (__hash__): _Py_HashPointer
        tp_call (__call__): NULL
        tp_str (__str__): == object
        tp_compare (cmp): NULL
        tp_richcompare (__richcmp__): NULL
        tp_getattr (__getattribute__): NULL
        tp_setattr (__setattribute__): NULL
        tp_getattro (__getattribute__): PyObject_GenericGetAttr
        tp_setattro (__setattribute__): PyObject_GenericSetAttr
        tp_iter (__iter__): NULL
        tp_iternext (__next__): 0x7fe426a40150
        tp_descr_get (__get__): NULL
        tp_descr_set (__set__): NULL
        tp_cache: NULL
        tp_weaklist: <weakref at 0x7fe36b81e050; to 'type' at 0x7fe42bfc3a80
      (X)>
        tp_traverse: subtype_traverse
        tp_clear: subtype_clear
        tp_is_gc: NULL
        tp_as_number: 0x7fe42bfc3c08
          nb_add (__add__): NULL
          nb_subtract (__sub__): NULL
          nb_multiply (__mul__): NULL
          nb_divide (__div__): NULL
          nb_floor_divide (__floordiv__): NULL
          nb_true_divide (__truediv__): NULL
          nb_remainder (__mod__): NULL
          nb_divmod (__divmod__): NULL
          nb_power (__pow__): NULL
          nb_negative (__neg__): NULL
          nb_positive (__pos__): NULL
          nb_absolute (__abs__): NULL
          nb_nonzero (__nonzero__): NULL
          nb_invert (__invert__): NULL
          nb_lshift (__lshift__): NULL
          nb_rshift (__rshift__): NULL
          nb_and (__and__): NULL
          nb_or (__or__): NULL
          nb_xor (__xor__): NULL
          nb_int (__int__): NULL
          nb_long (__long__): NULL
          nb_index (__index__): NULL
          nb_float (__float__): NULL
          nb_oct (__oct__): NULL
          nb_hex (__hex__): NULL
          nb_coerce: NULL
          nb_inplace_add (__iadd__): NULL
          nb_inplace_subtract (__isub__): NULL
          nb_inplace_multiply (__imul__): NULL
          nb_inplace_divide (__idiv__): NULL
          nb_inplace_floor_divide (__ifloordiv__): NULL
          nb_inplace_true_divide (__itruediv__): NULL
          nb_inplace_remainder (__imod__): NULL
          nb_inplace_power (__ipow__): NULL
          nb_inplace_lshift (__ilshift__): NULL
          nb_inplace_rshift (__irshift__): NULL
          nb_inplace_and (__iand__): NULL
          nb_inplace_or (__ior__): NULL
          nb_inplace_xor (__ixor__): NULL
        tp_as_sequence: 0x7fe42bfc3d58
          sq_length (__len__): NULL
          sq_concat (__add__): NULL
          sq_inplace_concat (__iadd__): NULL
          sq_repeat (__mul__): NULL
          sq_inplace_repeat (__imul__): NULL
          sq_item (__getitem__): NULL
          sq_ass_item (__setitem__): NULL
          sq_contains (__contains__): NULL
        tp_as_mapping: 0x7fe42bfc3d40
          mp_length (__len__): NULL
          mp_subscript (__getitem__): NULL
          mp_ass_subscript (__setitem__): NULL
        tp_as_buffer: 0x7fe42bfc3da8
          bf_getreadbuffer: NULL
          bf_getwritebuffer: NULL
          bf_getsegcount: NULL
          bf_getcharbuffer: NULL
        tp_flags:
          HEAPTYPE
          BASETYPE
          READY
          HAVE_GC
          CHECKTYPES
          HAVE_VERSION_TAG
          VALID_VERSION_TAG
        tp_version_tag: 10759
      }}}
      
      Note the lines `tp_dealloc`, `tp_traverse` and `tp_clear` which are more
      interesting than the hexadecimal constants before this patch.
      
      URL: https://trac.sagemath.org/27093
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      37f7465e
    • Release Manager's avatar
      Trac #27088: better conversion of univariate polynomials from Fricas · cbedc8f2
      Release Manager authored
      URL: https://trac.sagemath.org/27088
      Reported by: chapoton
      Ticket author(s): Martin Rubey, Frédéric Chapoton
      Reviewer(s): Martin Rubey, Frédéric Chapoton
      cbedc8f2
    • Release Manager's avatar
      Trac #27084: simplify and clean the list_plot3d file · 71d3e897
      Release Manager authored
      in particular removing ad-hoc keyword "texture", where "color" works
      
      URL: https://trac.sagemath.org/27084
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      71d3e897
    • Release Manager's avatar
      Trac #27082: turn lrskew into an iterator · d0f39a9f
      Release Manager authored
      as suggested in the code itself
      
      URL: https://trac.sagemath.org/27082
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      d0f39a9f
    • Release Manager's avatar
      Trac #27079: acyclic_edge_coloring(Graph(3), k=None, value_only=True) should not be 2, should it? · c40b0525
      Release Manager authored
      I think that the correct value for
      {{{
      acyclic_edge_coloring(Graph(3), k=None, value_only=True)
      }}}
      should be 0, since there is nothing to color.
      
      URL: https://trac.sagemath.org/27079
      Reported by: mantepse
      Ticket author(s): David Coudert
      Reviewer(s): Martin Rubey
      c40b0525
    • Release Manager's avatar
      Trac #27075: py3: fix all tests in sage_setup · d6e3539b
      Release Manager authored
      This fixes all tests in `src/sage_setup/*.py`
      
      #27073 fixes the tests in `src/sage_setup/docbuild/`
      
      URL: https://trac.sagemath.org/27075
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Frédéric Chapoton
      d6e3539b
    • Release Manager's avatar
      Trac #27073: py3: fix artificial exception test in sphinxbuild.py · 092cb1fa
      Release Manager authored
      This test is raising an exception and then it tries to display the
      traceback, long after the exception has been handled by the doctest
      framework. In Python 3 (and also after #24986), exceptions do not stay
      alive forever. The solution is fixing the test to construct the
      traceback in an `except Exception` block.
      
      {{{
      sage -t src/sage_setup/docbuild/sphinxbuild.py
      **********************************************************************
      File "src/sage_setup/docbuild/sphinxbuild.py", line 212, in
      sage_setup.docbuild.sphinxbuild.SageSphinxLogger._log_line
      Failed example:
          for line in traceback.format_exc().split('\n'):
              logger._log_line(line)
      Expected:
          [#25160   ] Traceback (most recent call last):
          [#25160   ]   File ...
          [#25160   ]     self.compile_and_execute(example, compiler,
      test.globs)
          [#25160   ]   File ...
          [#25160   ]     exec(compiled, globs)
          [#25160   ]   File ...
          [#25160   ]     raise Exception("artificial exception")
          [#25160   ] Exception: artificial exception
      Got:
          [#25160   ] NoneType: None
      **********************************************************************
      }}}
      
      While I was at it, I fixed one more trivial doctest failure. All tests
      in `src/sage_setup/docbuild` now pass on Python 3.
      
      URL: https://trac.sagemath.org/27073
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Erik Bray
      092cb1fa
    • Release Manager's avatar
      Trac #27064: Regression in .divides() for generic polynomials · e00d2d58
      Release Manager authored
      This used to work prior to #19171:
      
      {{{
      sage: R.<t> = GF(5)[]
      sage: K = R.fraction_field()
      sage: A.<x> = K[]
      sage: x.divides(x)
      True
      }}}
      
      Now it gives
      
      {{{
      ------------------------------------------------------------------------
      ---
      AttributeError                            Traceback (most recent call
      last)
      <ipython-input-14-cd2656325e62> in <module>()
      ----> 1 x.divides(x)
      
      /data/dfl/sage/local/lib/python2.7/site-
      packages/sage/structure/element.pyx in
      sage.structure.element.coerce_binop.new_method (build/cy
      thonized/sage/structure/element.c:28683)()
         4269     def new_method(self, other, *args, **kwargs):
         4270         if have_same_parent(self, other):
      -> 4271             return method(self, other, *args, **kwargs)
         4272         else:
         4273             a, b = coercion_model.canonical_coercion(self,
      other)
      
      /data/dfl/sage/local/lib/python2.7/site-
      packages/sage/rings/polynomial/polynomial_element.pyx in
      sage.rings.polynomial.polynomial_elem$
      nt.Polynomial.divides
      (build/cythonized/sage/rings/polynomial/polynomial_element.c:93668)()
        10088             return False
        10089
      > 10090         if not
      self.leading_coefficient().divides(p.leading_coefficient()):
        10091             return False
        10092
      
      /data/dfl/sage/local/lib/python2.7/site-
      packages/sage/structure/element.pyx in
      sage.structure.element.Element.__getattr__ (build/cytho$
      ized/sage/structure/element.c:4550)()
          491             AttributeError:
      'LeftZeroSemigroup_with_category.element_class' object has no attribute
      'blah_blah'
          492         """
      --> 493         return self.getattr_from_category(name)
          494
          495     cdef getattr_from_category(self, name):
      
      /data/dfl/sage/local/lib/python2.7/site-
      packages/sage/structure/element.pyx in
      sage.structure.element.Element.getattr_from_category (bu
      ild/cythonized/sage/structure/element.c:4659)()
          504         else:
          505             cls = P._abstract_element_class
      --> 506         return getattr_from_other_class(self, cls, name)
          507
          508     def __dir__(self):
      
      /data/dfl/sage/local/lib/python2.7/site-
      packages/sage/cpython/getattr.pyx in
      sage.cpython.getattr.getattr_from_other_class (build/cytho
      nized/sage/cpython/getattr.c:2536)()
          392         dummy_error_message.cls = type(self)
          393         dummy_error_message.name = name
      --> 394         raise AttributeError(dummy_error_message)
          395     attribute = <object>attr
          396     # Check for a descriptor (__get__ in Python)
      
      AttributeError: 'sage.rings.fraction_field_FpT.FpTElement' object has no
      attribute 'divides'
      }}}
      
      This is failing because the fraction field elements have no `.divides()`
      method.
      
      URL: https://trac.sagemath.org/27064
      Reported by: defeo
      Ticket author(s): Luca De Feo
      Reviewer(s): Jeroen Demeyer
      e00d2d58
  3. 25 Jan, 2019 3 commits
  4. 24 Jan, 2019 3 commits
  5. 23 Jan, 2019 8 commits
    • Release Manager's avatar
      Trac #27052: Drop XML_RESULTS · 8b3971cb
      Release Manager authored
      ...which was introduced in #9828 but nobody seems to remember why.
      
      URL: https://trac.sagemath.org/27052
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Erik Bray
      8b3971cb
    • Release Manager's avatar
      Trac #27050: speed up Schur to fundamental · 2328130f
      Release Manager authored
      Old:
      {{{
      sage: s = SymmetricFunctions(QQ).schur()
      sage: F = QuasiSymmetricFunctions(QQ).Fundamental()
      sage: %timeit [F(s(la)) for la in Partitions(7)]
      1 loop, best of 3: 2.04 s per loop
      sage: %timeit [F(s(la)) for la in Partitions(8)]
      1 loop, best of 3: 8.8 s per loop
      }}}
      
      New:
      {{{
      sage: s = SymmetricFunctions(QQ).schur()
      sage: F = QuasiSymmetricFunctions(QQ).Fundamental()
      sage: %timeit [F(s(la)) for la in Partitions(7)]
      10 loops, best of 3: 97.9 ms per loop
      sage: %timeit [F(s(la)) for la in Partitions(8)]
      1 loop, best of 3: 331 ms per loop
      }}}
      
      URL: https://trac.sagemath.org/27050
      Reported by: mantepse
      Ticket author(s): Martin Rubey
      Reviewer(s): Travis Scrimshaw
      2328130f
    • Release Manager's avatar
      Trac #27049: py3: some fix in Riemann surfaces · d5d5fc74
      Release Manager authored
      only partial, there remains 4 failing doctests out of 36
      
      URL: https://trac.sagemath.org/27049
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton, Nils Bruin
      Reviewer(s): Travis Scrimshaw
      d5d5fc74
    • Release Manager's avatar
      Trac #27048: py3: one fix in invariant_theory · a0bc031f
      Release Manager authored
      inside a private method used only in this file
      
      plus a few pep8 modifications
      
      URL: https://trac.sagemath.org/27048
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      a0bc031f
    • Release Manager's avatar
      Trac #27042: adding method is_sperner for posets · d674fa23
      Release Manager authored
      naive method to check if some poset is Sperner
      
      URL: https://trac.sagemath.org/27042
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jori Mäntysalo
      d674fa23
    • Release Manager's avatar
      Trac #27039: Add DESTDIR support for optional packages that use autotools · b2a9ff76
      Release Manager authored
      All these packages have standard autotools builds, so their
      transformation was mostly mechanical and trivial.  Only two slight
      exceptions:
      
      * The `configure` script for deformation is not actually generated by
      autoconf and does not support all the standard options (e.g.
      `--libdir`).  However, the rest of it is straightforward.
      
      * For mpfrcx we also add an `spkg-legacy-uninstall` script.
      
      I've tested all of these and confirmed that they still build properly,
      and that the files listed in their file manifests look logical, and
      doctests pass for me on Linux. There should really be no difference for
      these packages compared to how they were previously built and installed.
      
      URL: https://trac.sagemath.org/27039
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Frédéric Chapoton
      b2a9ff76
    • Release Manager's avatar
      Trac #27038: pyflakes cleanup in schemes · 7921d064
      Release Manager authored
      including one bug fixed in `base_extend` for affine schemes
      
      URL: https://trac.sagemath.org/27038
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      7921d064
    • Release Manager's avatar
      Trac #27033: Make relabel() of DynkinDiagram more compatible with GenericGraph · ceac6a41
      Release Manager authored
      `DynkinDiagram_class` is a derived class of `GenericGraph`. It
      specializes the `relabel()` method of `GenericGraph`, but it changes the
      interface. Generally, it is expected that a method in a derived class
      keeps (possibly extends) the API of the base class.
      
      Concretely, we fix the following issues:
      
      1. A permutation is required to be given. This is in contrast to
      `GenericGraph.relabel()` which allows no permutation (in that case,
      vertices will be relabelled to `range(G.order())`)
      
      2. `return_map` is not supported.
      
      URL: https://trac.sagemath.org/27033
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      ceac6a41