1. 25 Feb, 2019 1 commit
  2. 24 Feb, 2019 2 commits
  3. 22 Feb, 2019 25 commits
    • Release Manager's avatar
      Trac #16564: Derivations for inseparable function fields · 1c17893e
      Release Manager authored
      This ticket implements derivations for inseparable extensions of
      function fields.
      
      URL: https://trac.sagemath.org/16564
      Reported by: saraedum
      Ticket author(s): Julian Rüth, Jeroen Sijsling
      Reviewer(s): Jeroen Sijsling, Julian Rüth, Stefan Wewers
      1c17893e
    • Release Manager's avatar
      Trac #27334: Proper pickling for Sequences · 5a98af28
      Release Manager authored
      So far, we always relied on the default Python pickling implementation
      for instances of `Sequence_generic`. This just happened to work, but
      it's broken in Python 3.7. The proper solution seems to be to just
      implement a proper `__reduce__`.
      
      URL: https://trac.sagemath.org/27334
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      5a98af28
    • Release Manager's avatar
      Trac #27331: more cardinalities for restricted partitions · 1326ae2b
      Release Manager authored
      For various restrictions it is faster to count the number of partitions
      than to explicitely enumerate them.
      
      URL: https://trac.sagemath.org/27331
      Reported by: mantepse
      Ticket author(s): Martin Rubey
      Reviewer(s): Travis Scrimshaw
      1326ae2b
    • Release Manager's avatar
      Trac #27327: some pyflakes cleanup in geometry/triangulation · 96b42fe8
      Release Manager authored
      and also not using range(0,n) but range(n)
      
      URL: https://trac.sagemath.org/27327
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      96b42fe8
    • Release Manager's avatar
      Trac #27326: avoiding some lists inside all · dfc2cbab
      Release Manager authored
      URL: https://trac.sagemath.org/27326
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      dfc2cbab
    • Release Manager's avatar
      Trac #27324: some basic work on matrix_gap · f6f5ce71
      Release Manager authored
      adding a few methods, correcting some doctests, nothing complicated
      
      URL: https://trac.sagemath.org/27324
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Vincent Delecroix
      f6f5ce71
    • Release Manager's avatar
      Trac #27321: remove some deprecated aliases in rings and schemes · 450611c5
      Release Manager authored
      URL: https://trac.sagemath.org/27321
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      450611c5
    • Release Manager's avatar
      Trac #27320: remove some deprecated aliases in categories · 9e3de667
      Release Manager authored
      URL: https://trac.sagemath.org/27320
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): John Palmieri
      9e3de667
    • Release Manager's avatar
      Trac #27317: py3: partial care for matrix/ · b83b2ef1
      Release Manager authored
      inluding fixing one bad range
      
      URL: https://trac.sagemath.org/27317
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): David Coudert
      b83b2ef1
    • Release Manager's avatar
      Trac #27316: Fix invalid uses of sig_on() in modular.modsym.heilbronn · e25ef05a
      Release Manager authored
      {{{
      sage -t --long src/sage/structure/factorization.py
      **********************************************************************
      File "src/sage/structure/factorization.py", line 776, in
      sage.structure.factorization.Factorization._cr
      Failed example:
          F = ModularSymbols(11).factor(); F
      Exception raised:
          Traceback (most recent call last):
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 671, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1095, in compile_and_execute
              exec(compiled, globs)
            File "<doctest
      sage.structure.factorization.Factorization._cr[5]>", line 1, in <module>
              F = ModularSymbols(Integer(11)).factor(); F
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/modsym/ambient.py", line 1784, in factorization
              N = M.new_submodule().cuspidal_submodule().decomposition()
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/hecke/module.py", line 1017, in decomposition
              t = T.hecke_operator(p).matrix()
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/hecke/hecke_operator.py", line 751, in matrix
              self.__matrix = self.parent().hecke_matrix(self.__n, *args,
      **kwds)
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/hecke/algebra.py", line 528, in hecke_matrix
              return self.__M.hecke_matrix(n, *args, **kwds)
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/hecke/module.py", line 1400, in hecke_matrix
              T = self._compute_hecke_matrix(n)
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/hecke/module.py", line 215, in
      _compute_hecke_matrix
              return self._compute_hecke_matrix_prime(n, **kwds)
            File "/home/kevin/sage-patchbot/local/lib/python2.7/site-
      packages/sage/modular/modsym/ambient.py", line 2872, in
      _compute_hecke_matrix_prime
              v = H.apply(c,d, N)
            File "sage/modular/modsym/heilbronn.pyx", line 262, in
      sage.modular.modsym.heilbronn.Heilbronn.apply
      (build/cythonized/sage/modular/modsym/heilbronn.c:4764)
              sig_on()
          SystemError: calling remove_from_pari_stack() inside sig_on()
      **********************************************************************
      }}}
      
      URL: https://trac.sagemath.org/27316
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Frédéric Chapoton
      e25ef05a
    • Release Manager's avatar
      Trac #27292: aligned_malloc and realloc for MemoryAllocator · 7d1fd18a
      Release Manager authored
      Adding realloc and aligned_alloc to `MemoryAllocator`.
      
      `realloc` is available in `cysignals.memory` anyway, so we might as well
      have it in `MemoryAllocator`.
      
      `aligned_malloc` is useful for intrinsics, when memory up to 64-byte
      aligned is required. There are also similar functions in C, but its nice
      to have the memory taken care of by `MemoryAllocator`.
      
      URL: https://trac.sagemath.org/27292
      Reported by: gh-kliem
      Ticket author(s): Jonathan Kliem, Jeroen Demeyer
      Reviewer(s): Jeroen Demeyer, Jonathan Kliem, Nils Bruin
      7d1fd18a
    • Release Manager's avatar
      Trac #27275: py3: fix sage.libs.readline.pyx for python3 · 1b90e313
      Release Manager authored
      fix doctests failures : sage -t --long src/sage/libs/readline.pyx # 10
      doctests failed
      
      URL: https://trac.sagemath.org/27275
      Reported by: vklein
      Ticket author(s): Vincent Klein
      Reviewer(s): Erik Bray, Frédéric Chapoton
      1b90e313
    • Release Manager's avatar
      Trac #27222: Proper powering in CDF · f38f0cdf
      Release Manager authored
      Fix the Cython warning
      {{{
      warning: sage/rings/complex_double.pyx:1590:4: Overriding cdef method
      with def method.
      }}}
      
      URL: https://trac.sagemath.org/27222
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      f38f0cdf
    • Release Manager's avatar
      Trac #27160: py3: fix doctests in hyperbolicity and graph_coloring · 171b7bc9
      Release Manager authored
      - `hyperbolicity`: we avoid sorting vertex ids before returning the
      certificate, and we sort these ids in the doctests.
      - `graph_coloring`: we sort the output of some doctests
      
      URL: https://trac.sagemath.org/27160
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Jean-Florent Raymond
      171b7bc9
    • Release Manager's avatar
      Trac #25979: py3: pynac bug with logb on int · acfe807d
      Release Manager authored
      On Python 2:
      
      {{{
      sage: from sage.functions.log import logb
      sage: logb(7, 2)
      log(7)/log2
      sage: logb(int(7), 2)
      log(7)/log(2)
      }}}
      
      On Python 3:
      
      {{{
      sage: from sage.functions.log import logb
      sage: logb(7, 2)
      log(7)/log(2)
      sage: logb(int(7), 2)
      1
      }}}
      
      This was causing quite a few confusing bugs before I realized the subtle
      difference of `Integer` vs `int` that was causing the bug.  I'm not sure
      if it affect other functions too.
      
      '''Upstream PR:''' https://github.com/pynac/pynac/pull/336 (for pynac)
      
      Though we should also still fix conversion of integer types to
      expressions on Python 3.
      
      URL: https://trac.sagemath.org/25979
      Reported by: embray
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      acfe807d
    • Release Manager's avatar
      Trac #26881: py3: make doctest pass in repl module · 3bdf67f9
      Release Manager authored
      Fix the failling doctests in the sage.repl module :
      
      {{{
      sage -t --long src/sage/repl/configuration.py  # 2 doctests failed
      sage -t --long src/sage/repl/ipython_tests.py  # 5 doctests failed
      sage -t --long src/sage/repl/interpreter.py  # 1 doctest failed
      sage -t --long src/sage/repl/ipython_kernel/widgets_sagenb.py  # 2
      doctests failed
      sage -t --long src/sage/repl/ipython_kernel/interact.py  # 1 doctest
      failed
      }}}
      
      URL: https://trac.sagemath.org/26881
      Reported by: vklein
      Ticket author(s): Vincent Klein
      Reviewer(s): Frédéric Chapoton
      3bdf67f9
    • Release Manager's avatar
      Trac #26495: Py3 : Fix doctests in module tests/french_book · 28c07fcd
      Release Manager authored
      For frenchbook doctests errors, I chose to use doctest flag {{{# py2}}}
      instead of rewriting the examples.
      
      As the tests are supposed to be the examples of the book i think it's
      more consistent to just skip them in python 3 rather than rewrite them
      and have examples which differ form the book.
      
      The remaining doctests errors does not depends on this "module".
      
      URL: https://trac.sagemath.org/26495
      Reported by: vklein
      Ticket author(s): Vincent Klein, Frédéric Chapoton
      Reviewer(s): Vincent Klein
      28c07fcd
    • Release Manager's avatar
      Trac #27218: Ensure that GAP's package build toolchain is fully available for... · a0743513
      Release Manager authored
      Trac #27218: Ensure that GAP's package build toolchain is fully available for building compiled package
      
      crypting makes use of GAP's compiler (aka `gac`), and other tooling,
      namely, `libtool`.
      
      `gac` is installed with broken information about various paths and
      `sysinfo.gap` location, and `libtool` isn't installed at all, it seems.
      
      Here is how gac's entries should be corrected:
      {{{
      abs_top_srcdir="${SAGE_LOCAL}/share/gap/src"
      abs_top_builddir="${abs_top_srcdir}" # obsolete naming...
      }}}
      and one should source `sysinfo.gap` as
      {{{
      . "${abs_top_builddir}/../sysinfo.gap"
      }}}
      
      `libtool` should be installed along with `gac`.
      
      URL: https://trac.sagemath.org/27218
      Reported by: dimpase
      Ticket author(s): Erik Bray
      Reviewer(s): Dima Pasechnik
      a0743513
    • Release Manager's avatar
      Trac #27333: _get_shared_lib_filename broken on Cygwin · d353d194
      Release Manager authored
      In the course making last minute tweaks to #27230 I apparently still
      broke its functionality on Cygwin without testing it.
      
      URL: https://trac.sagemath.org/27333
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Erik Bray, Travis Scrimshaw
      d353d194
    • Release Manager's avatar
      Trac #27306: Since 8.7.beta3, giacpy_sage fails some groebner bases-related testdocs. · 8894f02b
      Release Manager authored
      {{{
      **********************************************************************
      File "src/sage/libs/giac.py", line 187, in sage.libs.giac.?
      Failed example:
          B.is_groebner() # optional - giacpy_sage
      Expected:
          True
      Got:
          False
      **********************************************************************
      File "src/sage/libs/giac.py", line 197, in sage.libs.giac.?
      Failed example:
          B.is_groebner()                                             #
      optional - giacpy_sage
      Expected:
          True
      Got:
          False
      **********************************************************************
      File "src/sage/libs/giac.py", line 199, in sage.libs.giac.?
      Failed example:
          B.ideal() == I.elimination_ideal([P.gen(0), P.gen(2)])      #
      optional - giacpy_sage
      Expected:
          True
      Got:
          False
      **********************************************************************
      }}}
      
      Reported [https://groups.google.com/d/msg/sage-
      release/0QvdNonpGEg/SfQHQ6ejAQAJ here], no further details (I'm out of
      my zone of competence).
      
      * New upstream giacpy_sage tarball to put in upstream:
      [http://webusers.imj-
      prg.fr/~frederic.han/xcas/giacpy/sage/giacpy_sage-0.6.7.tar.gz]
      
      URL: https://trac.sagemath.org/27306
      Reported by: charpent
      Ticket author(s): Frederic Han
      Reviewer(s): Travis Scrimshaw, Jeroen Demeyer
      8894f02b
    • Frédéric Chapoton's avatar
      add one doctest for logb · f96cd531
      Frédéric Chapoton authored
      f96cd531
    • Vincent Klein's avatar
      Trac #26881: py3 Fix repl module for python3 · 13b9f224
      Vincent Klein authored
      Fix the failling doctests:
      sage -t --long src/sage/repl/configuration.py  # 2 doctests failed
      sage -t --long src/sage/repl/ipython_tests.py  # 5 doctests failed
      sage -t --long src/sage/repl/interpreter.py  # 1 doctest failed
      sage -t --long src/sage/repl/ipython_kernel/widgets_sagenb.py  # 2
      sage -t --long src/sage/repl/ipython_kernel/interact.py  # 1
      13b9f224
    • Vincent Klein's avatar
      Trac #27275: Enhance doctest syntax. · 7ccd2a55
      Vincent Klein authored
      7ccd2a55
    • Vincent Klein's avatar
      Trac #27275: wrap copy_text result with a bytes_to_str ... · a291512d
      Vincent Klein authored
      ... call and modify doctest accordingly.
      a291512d
    • Vincent Klein's avatar
      Trac #27275: Fix readline.pyx for python3 · f21acf81
      Vincent Klein authored
      f21acf81
  4. 21 Feb, 2019 6 commits
  5. 20 Feb, 2019 6 commits
    • Release Manager's avatar
      Trac #27016: DESTDIR support for gcc, improvements to gfortran · 6117baa4
      Release Manager authored
      This does a few things:
      
      * Updates the gcc SPKG to support DESTDIR installation so that it can
      now be uninstalled as well
      
      * This includes a patch (adapted from Debian) to make gcc install
      libraries to `${prefix}/lib` instead of `${prefix}/lib64` on Linux (this
      does not appear to be a problem on Cygwin, macOS, or FreeBSD that I'm
      aware of).
      
      * Additional refactoring to reduce duplication between the gcc and
      gfortran SPKGs: This includes the patches from gcc as the can also be
      relevant to gfortran.
      
      I've tested this a good bit on Linux (being able to uninstall gcc now is
      nice), but it needs more testing on other platforms, particularly macOS
      since it's the primary case for installing this package in the first
      place, and involves additional workarounds.
      
      This would also fix #26996 for the case of installing gfortran on Linux.
      
      URL: https://trac.sagemath.org/27016
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Dima Pasechnik
      6117baa4
    • Release Manager's avatar
      Trac #26792: py3: Stop to use sort on KeyConvertingDict object · 78cdb4cd
      Release Manager authored
      With python3 we currently have 40 failures of type
      {{{
      TypeError: '<' not supported between instances of 'KeyConvertingDict'
      and 'KeyConvertingDict'
      }}}
      These errors comes from the call of {{{V.sort()}}} in
      multi_polynomial_ideal.py", line 2381, {{{variety}}} function.
      
      The root reason for calling {{{sort}}} is for doctest displaying :
      >commit 17f42824
      >Author: Carl Witty <cwitty@newtonlabs.com>
      >Date:   Wed Oct 24 18:36:37 2007 -0700
      >
      >    Sort results of variety(), for better cross-architecture doctest
      compatibility.
      >    This compensates for the fact that the results of Singular's
      triangular
      >    decomposition algorithm triangLfak appear in a different order on
      >    different architectures.  (It would be better to fix this in
      >    triangular_decomposition(), but the obvious approach of sorting its
      >    result failed due to TRAC #991.)
      
      As it will not make a lot of sense to implement comparison operators for
      KeyConvertingDict this ticket aim at solving the sorting problems at
      doctests level rather than at python source code level.
      
      URL: https://trac.sagemath.org/26792
      Reported by: vklein
      Ticket author(s): Vincent Klein
      Reviewer(s): Frédéric Chapoton
      78cdb4cd
    • Release Manager's avatar
      Trac #23313: Add more conversions from giac II · 0ee400d8
      Release Manager authored
      Ticket #22706 was about adding special function `conversions` for the
      Giac interface.
      
      In this ticket we add two more conversions: `ln` and `euler_gamma`.
      
      URL: https://trac.sagemath.org/23313
      Reported by: mforets
      Ticket author(s): Marcelo Forets
      Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
      0ee400d8
    • Frédéric Chapoton's avatar
      7e1615ed
    • Frédéric Chapoton's avatar
      avoiding some lists inside all() · b0591b04
      Frédéric Chapoton authored
      b0591b04
    • Frédéric Chapoton's avatar
      some details in matrix_gap · eb59de7f
      Frédéric Chapoton authored
      eb59de7f