1. 23 Oct, 2018 1 commit
  2. 20 Oct, 2018 39 commits
    • Volker Braun's avatar
      Updated SageMath version to 8.5.beta0 · a0a5f599
      Volker Braun authored
      a0a5f599
    • Release Manager's avatar
      Trac #26500: Add is_derangements method to Permutation · b9222fdd
      Release Manager authored
      It is useful to check if a permutation is a derangement for, e.g., the
      Tsetlin library steady state distribution.
      
      URL: https://trac.sagemath.org/26500
      Reported by: tscrim
      Ticket author(s): Travis Scrimshaw
      Reviewer(s): UC Davis Math 165 class, Anne Schilling
      b9222fdd
    • Release Manager's avatar
      Trac #26464: some cleanup in fan.py · 2dd4022b
      Release Manager authored
      mostly pep8, also including one division fix
      
      URL: https://trac.sagemath.org/26464
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      2dd4022b
    • Release Manager's avatar
      Trac #26461: adding new Catalan semilattices · db47d3d6
      Release Manager authored
      very recently introduced
      
      URL: https://trac.sagemath.org/26461
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      db47d3d6
    • Release Manager's avatar
      Trac #26415: py3: use sage_getargspec more consistently · 4d560d88
      Release Manager authored
      Using `sage_getargspec` instead of `inspect.getargspec` is a nice,
      consistent way to smooth over some Python 2/3 differences, and in
      particular `DeprecationWarning`s that come up from using
      `inspect.getargspec`.  As a bonus it will work better on more inputs,
      though I don't think that particularly matters in the specific cases
      changed here.
      
      Went ahead and rebased this on #26380 which is already closed as of
      writing, but which I hadn't seen.  Nevertheless I still had this change
      done a few weeks ago; my bad for not posting sooner.
      
      URL: https://trac.sagemath.org/26415
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Travis Scrimshaw
      4d560d88
    • Release Manager's avatar
      Trac #26175: another typo ticket (2018-09) · f1b42506
      Release Manager authored
      URL: https://trac.sagemath.org/26175
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jori Mäntysalo
      f1b42506
    • Release Manager's avatar
      Trac #26099: trim lattices · 6eec37dd
      Release Manager authored
      This patch adds `is_trim()` to finite lattices.
      
      URL: https://trac.sagemath.org/26099
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jori Mäntysalo
      6eec37dd
    • Release Manager's avatar
      Trac #25270: Add option to only run short doctests · f0981653
      Release Manager authored
      The attached picture shows how many modules (horizontal) you can run in
      how many CPU minutes (vertical). So, for example, in 40 CPU minutes
      (i.e., 10 wall minutes on my laptop) I can run all the doctests in 80%
      of all Sage modules. In 4 CPU minutes, I can doctest 50% of all Sage
      modules.
      
      [[Image(bar.png,width=80%,center)]]
      
      This ticket implements a `--short [SECONDS]` switch which runs as many
      doctests as possible (from the top of each module) in SECONDS (default
      300).
      
      This gives us a quick way to check that a change did not break things
      too terribly. For example, when I work on p-adics, I would probably do:
      `sage -tp --short 30 src/sage/rings/padics` frequently. Once I am happy
      with my changes, I could do `sage -tp --short src/sage/rings`  and a
      final `sage -tp --short --all` before I leave the rest to the patchbot.
      
      Here is an example:
      {{{
      > sage -tp --short 5 src/sage/rings/padics/*.py
      Doctesting 19 files using 4 threads.
      sage -t src/sage/rings/padics/padic_base_leaves.py
          [14% of tests run, 1.31 s]
      sage -t src/sage/rings/padics/factory.py
          [29% of tests run, 1.31 s]
      sage -t src/sage/rings/padics/lattice_precision.py
          [43% of tests run, 1.00 s]
      sage -t src/sage/rings/padics/padic_valuation.py
          [4% of tests run, 2.80 s]
      sage -t src/sage/rings/padics/padic_base_generic.py
          [95% of tests run, 1.72 s]
      sage -t src/sage/rings/padics/local_generic.py
          [1% of tests run, 0.73 s]
      sage -t src/sage/rings/padics/padic_extension_generic.py
          [5% of tests run, 0.77 s]
      sage -t src/sage/rings/padics/padic_lattice_element.py
          [2% of tests run, 0.78 s]
      sage -t src/sage/rings/padics/generic_nodes.py
          [1% of tests run, 0.75 s]
      sage -t src/sage/rings/padics/padic_generic.py
          [1% of tests run, 0.73 s]
      sage -t src/sage/rings/padics/unramified_extension_generic.py
          [2% of tests run, 0.43 s]
      sage -t src/sage/rings/padics/tutorial.py
          [4% of tests run, 0.70 s]
      sage -t src/sage/rings/padics/tests.py
          [0% of tests run, 0.00 s]
      sage -t src/sage/rings/padics/eisenstein_extension_generic.py
          [7% of tests run, 0.80 s]
      sage -t src/sage/rings/padics/misc.py
          [6% of tests run, 0.78 s]
      sage -t src/sage/rings/padics/precision_error.py
          [0 tests, 0.00 s]
      sage -t src/sage/rings/padics/all.py
          [0 tests, 0.00 s]
      sage -t src/sage/rings/padics/__init__.py
          [0 tests, 0.00 s]
      sage -t src/sage/rings/padics/padic_extension_leaves.py
          [10% of tests run, 6.54 s]
      ----------------------------------------------------------------------
      All tests passed!
      ----------------------------------------------------------------------
      Total time for all tests: 6.6 seconds
          cpu time: 20.0 seconds
          cumulative wall time: 21.1 seconds
      }}}
      
      URL: https://trac.sagemath.org/25270
      Reported by: saraedum
      Ticket author(s): Julian Rüth
      Reviewer(s): Erik Bray
      f0981653
    • Release Manager's avatar
      Trac #26502: failing optional internet doctests in sage/combinat/designs · 205c4fb1
      Release Manager authored
      The math databases and papers of CCR La Jolla have moved from
      http://www.ccrwest.org to https://math.ccrwest.org.
      
      As a result, in Sage 8.4, the command
      {{{
      sage -t --long --optional=sage,internet
      src/sage/combinat/designs/covering_design.py
      src/sage/combinat/designs/design_catalog.py
      }}}
      gives
      {{{
      ----------------------------------------------------------------------
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/covering_design.py  # 2 doctests failed
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/design_catalog.py  # 3 doctests failed
      ----------------------------------------------------------------------
      }}}
      
      Complete log below
      {{{
      Running doctests with ID 2018-10-18-11-57-37-ce10c176.
      Git branch: develop
      Using --optional=internet,memlimit,sage
      Doctesting 2 files.
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/covering_design.py
      **********************************************************************
      File "src/sage/combinat/designs/covering_design.py", line 473, in
      sage.combinat.designs.covering_design.best_known_covering_design_www
      Failed example:
          C = best_known_covering_design_www(7, 3, 2)   # optional - internet
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.designs.covering_design.best_known_co
      vering_design_www[1]>", line 1, in <module>
              C = best_known_covering_design_www(Integer(7), Integer(3),
      Integer(2))   # optional - internet
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/combinat/designs/covering_design.py", line 503, in
      best_known_covering_design_www
              f = urlopen(url)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 154, in urlopen
              return opener.open(url, data, timeout)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 435, in open
              response = meth(req, response)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 548, in http_response
              'http', request, response, code, msg, hdrs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 467, in error
              result = self._call_chain(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 407, in _call_chain
              result = func(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 654, in http_error_302
              return self.parent.open(new, timeout=req.timeout)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 435, in open
              response = meth(req, response)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 548, in http_response
              'http', request, response, code, msg, hdrs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 473, in error
              return self._call_chain(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 407, in _call_chain
              result = func(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 556, in http_error_default
              raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
          HTTPError: HTTP Error 404: Not Found
      **********************************************************************
      File "src/sage/combinat/designs/covering_design.py", line 474, in
      sage.combinat.designs.covering_design.best_known_covering_design_www
      Failed example:
          print(C)                                     # optional - internet
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.designs.covering_design.best_known_co
      vering_design_www[2]>", line 1, in <module>
              print(C)                                     # optional -
      internet
          NameError: name 'C' is not defined
      **********************************************************************
      1 item had failures:
         2 of   4 in
      sage.combinat.designs.covering_design.best_known_covering_design_www
          [49 tests, 2 failures, 0.42 s]
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/design_catalog.py
      **********************************************************************
      File "src/sage/combinat/designs/design_catalog.py", line 22, in
      sage.combinat.designs.design_catalog
      Failed example:
          C = designs.best_known_covering_design_from_LJCR(7, 3, 2)   #
      optional - internet
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.designs.design_catalog[1]>", line 1,
      in <module>
              C = designs.best_known_covering_design_from_LJCR(Integer(7),
      Integer(3), Integer(2))   # optional - internet
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/combinat/designs/covering_design.py", line 503, in
      best_known_covering_design_www
              f = urlopen(url)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 154, in urlopen
              return opener.open(url, data, timeout)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 435, in open
              response = meth(req, response)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 548, in http_response
              'http', request, response, code, msg, hdrs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 467, in error
              result = self._call_chain(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 407, in _call_chain
              result = func(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 654, in http_error_302
              return self.parent.open(new, timeout=req.timeout)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 435, in open
              response = meth(req, response)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 548, in http_response
              'http', request, response, code, msg, hdrs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 473, in error
              return self._call_chain(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 407, in _call_chain
              result = func(*args)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/urllib2.py",
      line 556, in http_error_default
              raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
          HTTPError: HTTP Error 404: Not Found
      **********************************************************************
      File "src/sage/combinat/designs/design_catalog.py", line 23, in
      sage.combinat.designs.design_catalog
      Failed example:
          C                            # optional - internet
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.designs.design_catalog[2]>", line 1,
      in <module>
              C                            # optional - internet
          NameError: name 'C' is not defined
      **********************************************************************
      File "src/sage/combinat/designs/design_catalog.py", line 28, in
      sage.combinat.designs.design_catalog
      Failed example:
          C.incidence_structure()      # optional - internet
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage/local/lib/python2.7/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.designs.design_catalog[3]>", line 1,
      in <module>
              C.incidence_structure()      # optional - internet
          NameError: name 'C' is not defined
      **********************************************************************
      1 item had failures:
         3 of   5 in sage.combinat.designs.design_catalog
          [4 tests, 3 failures, 0.25 s]
      ----------------------------------------------------------------------
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/covering_design.py  # 2 doctests failed
      sage -t --long --warn-long 80.6
      src/sage/combinat/designs/design_catalog.py  # 3 doctests failed
      ----------------------------------------------------------------------
      Total time for all tests: 0.8 seconds
          cpu time: 0.1 seconds
          cumulative wall time: 0.7 seconds
      }}}
      
      URL: https://trac.sagemath.org/26502
      Reported by: slabbe
      Ticket author(s): Samuel Lelièvre
      Reviewer(s): Frédéric Chapoton
      205c4fb1
    • Release Manager's avatar
      Trac #26494: faster f-polynomial and zeta-polynomial for posets · b0b15788
      Release Manager authored
      URL: https://trac.sagemath.org/26494
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      b0b15788
    • Release Manager's avatar
      Trac #26493: element_pari_ffelt: use PARI clones instead of deepcopy_to_python_heap() · e9313096
      Release Manager authored
      The PARI "clone" functionality is pretty close to what
      `deepcopy_to_python_heap()` does. Since it's handling PARI objects
      anyway, it makes sense to use the PARI `gclone()` functionality too.
      
      That is what cypari2 will do starting from version 2.0, so for
      consistency `element_pari_ffelt` should do that too.
      
      We also add a few minor unrelated changes:
      
      - The signature of `construct_from` is changed from `void ... except *`
      to `int ... except -1` to have more efficient error checking.
      
      - Redundant Cython typing such as `FiniteFieldElement_pari_ffelt self`
      is removed.
      
      - The `__pari__` and `_repr_` methods no longer call `sig_on()`.
      
      URL: https://trac.sagemath.org/26493
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Peter Bruin
      e9313096
    • Release Manager's avatar
      Trac #26488: Remove one usage of SAGE_ROOT in doctests · 2335e0cb
      Release Manager authored
      SAGE_ROOT doesn't really make sense in distributions. Remove one usage
      of it in sage_ostools.pyx, which causes a doctest failure in
      distributions and it doesn't look that useful in sage-the-distribution.
      
      URL: https://trac.sagemath.org/26488
      Reported by: arojas
      Ticket author(s): Antonio Rojas
      Reviewer(s): François Bissey
      2335e0cb
    • Release Manager's avatar
      Trac #26486: clean distances_all_pairs.pyx · 171909a5
      Release Manager authored
      Clean `distances_all_pairs.pyx`, mostly PEP8.
      
      URL: https://trac.sagemath.org/26486
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Sébastien Labbé
      171909a5
    • Release Manager's avatar
      Trac #26485: clean genus.pyx · de42c3e7
      Release Manager authored
      PEP8 cleaning and use of `MemoryAllocator`.
      
      URL: https://trac.sagemath.org/26485
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      de42c3e7
    • Release Manager's avatar
      Trac #26484: clean graph_coloring.py · ec6372f0
      Release Manager authored
      Clean `graph_coloring.py` and avoid comparison of vertex labels.
      
      URL: https://trac.sagemath.org/26484
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      ec6372f0
    • Release Manager's avatar
      Trac #26483: clean graph_database.py · 9978e85d
      Release Manager authored
      Clean the file and in particular the documentation of the module,
      classes and methods to improve html output.
      
      URL: https://trac.sagemath.org/26483
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      9978e85d
    • Release Manager's avatar
      Trac #26477: remove deprecated stuff in polynomial_element · d8fdcc6b
      Release Manager authored
      plus small-scale partial pep8 cleanup
      
      after #17518 and #18420
      
      URL: https://trac.sagemath.org/26477
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      d8fdcc6b
    • Release Manager's avatar
      Trac #26476: refine the category of Symmetric groups · 2fbf0a88
      Release Manager authored
      as they are irreducible as reflection groups
      
      URL: https://trac.sagemath.org/26476
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      2fbf0a88
    • Release Manager's avatar
      Trac #26469: avoid sorting vertex labels in graph_plot.py · faafb175
      Release Manager authored
      We avoid sorting vertex labels in method `set_edges` of `graph_plot.py`.
      
      URL: https://trac.sagemath.org/26469
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      faafb175
    • Release Manager's avatar
      Trac #26431: py3: not sorting vertices on some graph functions · f54d861f
      Release Manager authored
      URL: https://trac.sagemath.org/26431
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw, David Coudert
      f54d861f
    • Release Manager's avatar
      Trac #26475: py3: make all tests in manifolds passed · a0584129
      Release Manager authored
      This fixes all doctest errors with python3 in `src/sage/manifolds`.
      
      URL: https://trac.sagemath.org/26475
      Reported by: egourgoulhon
      Ticket author(s): Eric Gourgoulhon
      Reviewer(s): Frédéric Chapoton
      a0584129
    • Release Manager's avatar
      Trac #26473: py3: fix doctests failures of sage/combinat/words/word_*datatype* · 2b14ffc7
      Release Manager authored
      with 8.4.rc0, the python 3 failures in `sage/combinat/words` are:
      
      {{{
      ----------------------------------------------------------------------
      sage -t abstract_word.py  # 13 doctests failed
      sage -t word_char.pyx  # 3 doctests failed
      sage -t word_generators.py  # 23 doctests failed
      sage -t word_infinite_datatypes.py  # 22 doctests failed
      sage -t words.py  # 7 doctests failed
      sage -t word.py  # 8 doctests failed
      sage -t word_datatypes.pyx  # 1 doctest failed
      sage -t suffix_trees.py  # 2 doctests failed
      sage -t morphism.py  # 16 doctests failed
      sage -t finite_word.py  # 73 doctests failed
      sage -t paths.py  # 15 doctests failed
      ----------------------------------------------------------------------
      }}}
      
      often of the following form due to `word_infinite_datatypes.py`:
      
      {{{
      **********************************************************************
      File "word_infinite_datatypes.py", line 1035, in sage.combinat.words.wor
      d_infinite_datatypes.WordDatatype_iter_with_caching.__getitem__
      Failed example:
          w[::2]
      Exception raised:
          Traceback (most recent call last):
            File "/home/slabbe/GitBox/sage3/local/lib/python3.6/site-
      packages/sage/doctest/forker.py", line 659, in _run
              self.compile_and_execute(example, compiler, test.globs)
            File "/home/slabbe/GitBox/sage3/local/lib/python3.6/site-
      packages/sage/doctest/forker.py", line 1070, in compile_and_execute
              exec(compiled, globs)
            File "<doctest sage.combinat.words.word_infinite_datatypes.WordDat
      atype_iter_with_caching.__getitem__[17]>", line 1, in <module>
              w[::Integer(2)]
            File "/home/slabbe/GitBox/sage3/local/lib/python3.6/site-
      packages/sage/combinat/words/word_infinite_datatypes.py", line 1161, in
      __getitem__
              return
      super(WordDatatype_iter_with_caching,self).__getitem__(key)
            File "/home/slabbe/GitBox/sage3/local/lib/python3.6/site-
      packages/sage/combinat/words/word_infinite_datatypes.py", line 874, in
      __getitem__
              data = itertools.islice(self, key.start, stop, key.step)
          ValueError: Step for islice() must be a positive integer or None.
      **********************************************************************
      }}}
      
      We fix issues in `word_infinite_datatypes.py` and `word_datatype.py` and
      now with this ticket, there are a lot less failing doctests in
      `sage/combinat/words`:
      
      {{{
      ----------------------------------------------------------------------
      sage -t abstract_word.py  # 4 doctests failed
      sage -t word_generators.py  # 2 doctests failed
      sage -t word.py  # 1 doctest failed
      sage -t morphism.py  # 9 doctests failed
      sage -t finite_word.py  # 7 doctests failed
      ----------------------------------------------------------------------
      }}}
      
      URL: https://trac.sagemath.org/26473
      Reported by: slabbe
      Ticket author(s): Sébastien Labbé
      Reviewer(s): Vincent Klein
      2b14ffc7
    • Release Manager's avatar
      Trac #26467: clean hypergraph_generators.py · c928023e
      Release Manager authored
      Some PEP8 corrections and better documentation (for html).
      
      URL: https://trac.sagemath.org/26467
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      c928023e
    • Release Manager's avatar
      Trac #26466: Py3: Fix DeprecationWarning: generator X raised StopIteration · 9a0815d6
      Release Manager authored
      Following #26458 this ticket aim at fixing the remaining cases of
      {{{DeprecationWarning: generator X raised StopIteration}}} in sage.
      
      URL: https://trac.sagemath.org/26466
      Reported by: vklein
      Ticket author(s): Vincent Klein
      Reviewer(s): Frédéric Chapoton
      9a0815d6
    • Release Manager's avatar
      Trac #26465: remove deprecated stuff in polyhedron/plot · 0a2e9748
      Release Manager authored
      after #16625
      
      URL: https://trac.sagemath.org/26465
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      0a2e9748
    • Release Manager's avatar
      Trac #26463: gen_to_sage: make imports global · d5d317fb
      Release Manager authored
      This speeds up `gen_to_sage()` significantly.
      
      URL: https://trac.sagemath.org/26463
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): John Cremona, Travis Scrimshaw
      d5d317fb
    • Release Manager's avatar
      Trac #26458: Py3: Fix DeprecationWarning: generator X raised StopIteration for combinat/words · 1f7f4e6d
      Release Manager authored
      URL: https://trac.sagemath.org/26458
      Reported by: vklein
      Ticket author(s): Vincent Klein
      Reviewer(s): Frédéric Chapoton
      1f7f4e6d
    • Release Manager's avatar
      Trac #26456: remove deprecated zero_element · 91cd66d5
      Release Manager authored
      after #17694
      
      URL: https://trac.sagemath.org/26456
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      91cd66d5
    • Release Manager's avatar
      Trac #26455: remove deprecated call method for symbolic matrices · 482abec8
      Release Manager authored
      after #5413
      
      plus small-scale cleanup of doc and pep8
      
      URL: https://trac.sagemath.org/26455
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Travis Scrimshaw
      482abec8
    • Release Manager's avatar
      Trac #26452: cartesian products of MonomialGrowthGroup related to number fields · 61590414
      Release Manager authored
      {{{
      sage: from sage.rings.asymptotic.growth_group import MonomialGrowthGroup
      sage: R = QQ.extension(x^2+1, 'i')
      sage: P = MonomialGrowthGroup(R, 'w')
      sage: L = MonomialGrowthGroup(ZZ, 'log(w)')
      sage: cartesian_product([P, L])
      }}}
      results in
      {{{
      ValueError: The name "in" is not a valid Python identifier.
      }}}
      
      URL: https://trac.sagemath.org/26452
      Reported by: dkrenn
      Ticket author(s): Daniel Krenn
      Reviewer(s): Clemens Heuberger
      61590414
    • Release Manager's avatar
      Trac #26448: clean hyperbolicity.pyx · 22c1d92f
      Release Manager authored
      Various PEP8 corrections and fix `sorted` statements.
      
      URL: https://trac.sagemath.org/26448
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      22c1d92f
    • Release Manager's avatar
      Trac #26447: py3: do not sort vertices in static graphs · 75808093
      Release Manager authored
      as this may help to fix the posets
      
      URL: https://trac.sagemath.org/26447
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): David Coudert
      75808093
    • Release Manager's avatar
      Trac #26444: Use maximal cliques iterator for line graph · f18560e8
      Release Manager authored
      Use a maximal cliques iterator in method `root_graph`, and use
      `root_graph` instead of line graph forbidden subgraph search in method
      `is_line_graph`. This was a long standing request to speed up the
      method.
      
      URL: https://trac.sagemath.org/26444
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      f18560e8
    • Release Manager's avatar
      Trac #26439: clean matchpoly.pyx · 30649e23
      Release Manager authored
      Clean the file, remove useless variables, and add `key` argument to a
      `sort`.
      
      URL: https://trac.sagemath.org/26439
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      30649e23
    • Release Manager's avatar
      Trac #26437: clean partial_cube.py · dcd7851c
      Release Manager authored
      Clean the file and add `key` argument to a `max`.
      
      URL: https://trac.sagemath.org/26437
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Frédéric Chapoton
      dcd7851c
    • Release Manager's avatar
      Trac #26436: Force input of affine permutation groups to be elements of ZZ · f936bdfe
      Release Manager authored
      When given user input, we should also enforce that every element belongs
      to `ZZ`. Otherwise, this can lead to subtle problems:
      {{{
      sage: A = AffinePermutationGroup(['A',3,1])
      sage: p = A([-3/1,2/1,3/1,8/1])
      sage: p
      Type A affine permutation with window [-3, 2, 3, 8]
      sage: q = ~p
      sage: q
      Type A affine permutation with window [5, 2, 3, 0]
      sage: q * p
      Type A affine permutation with window [1, 3, 5, 7]
      }}}
      contrast with
      {{{
      sage: p = A([-3,2,3,8])
      sage: q = ~p
      sage: q
      Type A affine permutation with window [5, 2, 3, 0]
      sage: q * p
      Type A affine permutation with window [1, 2, 3, 4]
      }}}
      
      URL: https://trac.sagemath.org/26436
      Reported by: tscrim
      Ticket author(s): Travis Scrimshaw
      Reviewer(s): Andrew Mathas
      f936bdfe
    • Release Manager's avatar
      Trac #26435: polytopes.simplex: Add base_ring keyword, allow exact computation with project=True · 391c379a
      Release Manager authored
      This enables setting up a regular simplex with `project=True` in
      algebraic reals
      {{{
                  sage: s3 = polytopes.simplex(3, project=True, base_ring=AA)
                  sage: s3.volume() == sqrt(3+1) / factorial(3)
                  True
      }}}
      
      URL: https://trac.sagemath.org/26435
      Reported by: mkoeppe
      Ticket author(s): Matthias Koeppe
      Reviewer(s): Travis Scrimshaw
      391c379a
    • Release Manager's avatar
      Trac #26433: Slowness in generic quo_rem · 7a3157fe
      Release Manager authored
      While working on #26405, I noticed that the generic implementation of
      `quo_rem` is very slow. Indeed, compare:
      
      {{{
      sage: R.<a> = Zq(2^3)
      sage: S.<x> = R[]
      sage: P = S.random_element(degree=100)
      sage: t = R.random_element()
      
      sage: %timeit _ = P(t)
      10000 loops, best of 3: 145 µs per loop
      
      sage: Q = x - t
      sage: %timeit _ = P % Q
      1000 loops, best of 3: 1.06 ms per loop
      }}}
      
      URL: https://trac.sagemath.org/26433
      Reported by: caruso
      Ticket author(s): Xavier Caruso, Travis Scrimshaw
      Reviewer(s): Travis Scrimshaw
      7a3157fe
    • Release Manager's avatar
      Trac #26432: clean graph.py · 519c614d
      Release Manager authored
      We do as much cleaning as possible: alignments, PEP8, avoid many vertex
      comparisons or sorting, etc.
      
      URL: https://trac.sagemath.org/26432
      Reported by: dcoudert
      Ticket author(s): David Coudert
      Reviewer(s): Travis Scrimshaw
      519c614d