1. 09 Apr, 2017 1 commit
  2. 06 Apr, 2017 1 commit
  3. 05 Apr, 2017 19 commits
    • Release Manager's avatar
      Trac #22662: Fold farey.pxd into farey_symbol.pyx · 6f6a0869
      Release Manager authored
      Unlike other `.pxd` files, the file `farey.pxd` is ''not'' meant as
      public header. For this reason, we move its contents to the file
      `farey_symbol.pyx`, which is the only place where it is used.
      
      We also fix a typo `__deallocpp__` causing a memory leak.
      
      URL: https://trac.sagemath.org/22662
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Frédéric Chapoton
      6f6a0869
    • Release Manager's avatar
      Trac #22622: Inconsistency in the .is_lattice_polytope() method · d232cd22
      Release Manager authored
      The `.is_lattice_polytope()` method states that it requires the
      polyhedron object to be compact, but it still returns `True` if it is
      not.
      
      {{{
      
      sage: P1 = Polyhedron(vertices = [[1, 0], [0, 1]], rays = [[1, 1]])
      sage: P1.is_compact()
      False
      sage: P1.is_lattice_polytope??
      Signature: P1.is_lattice_polytope()
      Source:
          def is_lattice_polytope(self):
              r"""
              Return whether the polyhedron is a lattice polytope.
      
              OUTPUT:
      
              ``True`` if the polyhedron is compact and has only integral
              vertices, ``False`` otherwise.
      
              EXAMPLES::
      
                  sage: polytopes.cross_polytope(3).is_lattice_polytope()
                  True
                  sage: polytopes.regular_polygon(5).is_lattice_polytope()
                  False
              """
              return True
      File:      ~SAGE_ROOT/local/lib/python2.7/site-
      packages/sage/geometry/polyhedron/base_ZZ.py
      Type:      instancemethod
      sage: P1.is_lattice_polytope()
      True
      
      }}}
      
      URL: https://trac.sagemath.org/22622
      Reported by: jipilab
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jean-Philippe Labbé
      d232cd22
    • Release Manager's avatar
      Trac #22546: Improve combinatorial_automorphism_group in polyhedra class · 62881496
      Release Manager authored
      Currently, the `combinatorial_automorphism_group` method in the
      polyhedron class returns a group isomorphic to the automorphism group of
      the vertex-edge graph of the polyhedron. I propose to changes two the
      method:
      
       (1) don't return a permutation group on the number `1, 2,..
      self.n_vertices()`, but rather a permutation group on the actual objects
      (vertices of the polyhedron)
      
       (2) wide the functionality to not only return the automorphism group of
      the vertex-edge graph, but also of the vertex-facet graph.
      
      The second improvement has the advantage that the automorphism group of
      the vertex-facet graph is the same as the automorphism of the face
      lattice.
      
      Since the vertex-facet graph is also used in the related
      `.is_combinatorially_isomorphic` method (see #22500) and it might be
      useful on its own, it is now a seperate function.
      
      URL: https://trac.sagemath.org/22546
      Reported by: moritz
      Ticket author(s): Moritz Firsching
      Reviewer(s): Jean-Philippe Labbé
      62881496
    • Release Manager's avatar
      Trac #22736: Don't export SAGE_SCRIPTS_DIR · fab799bf
      Release Manager authored
      The variable `SAGE_SCRIPTS_DIR` is only meant to be used in `sage-env`
      to find `sage-env-config` for example. It is not meant to be used
      externally, so it should not be exported.
      
      URL: https://trac.sagemath.org/22736
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Matthias Koeppe
      fab799bf
    • Release Manager's avatar
      Trac #22735: From Poincare to Poincaré · b6414392
      Release Manager authored
      This patch will change Poincare to Poincaré in docstrings. This does not
      change class names, as Python allows only ascii in identifiers, and does
      not change object names as it may later break doctesting. (Exception:
      one place is already handled in #22734.)
      
      I have prefilled reviewer name by a man with `é` in his name. `:=)`.
      
      URL: https://trac.sagemath.org/22735
      Reported by: jmantysalo
      Ticket author(s): Jori Mäntysalo
      Reviewer(s): Frédéric Chapoton
      b6414392
    • Release Manager's avatar
      Trac #22741: use svg logo in html documentation · 1f284ab2
      Release Manager authored
      In the top-left and bottom-left corner of html documentation, there is
      currently a png "sage" icon.
      
      See for example http://doc.sagemath.org/html/en/reference/index.html
      
      I propose to use instead an svg file.
      
      The look of the svg logo is not quite the same as the png file.
      
      URL: https://trac.sagemath.org/22741
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Asutosh Hota
      1f284ab2
    • Release Manager's avatar
      Trac #22738: Remove deprecated code · c8dbc309
      Release Manager authored
      Remove code deprecated in #10668, #18108, #18109, #19167, #19415,
      #19675, #19818, #19941, #20002, #20011, #20094, #20135, #20158, #20334.
      
      We also remove the `__doc_exclude` globals from various files since
      these are not used by anything.
      
      URL: https://trac.sagemath.org/22738
      Reported by: jdemeyer
      Ticket author(s): Jeroen Demeyer
      Reviewer(s): Travis Scrimshaw
      c8dbc309
    • Release Manager's avatar
      Trac #22732: Catalog of posets, minor documentation changes · 32be2bc1
      Release Manager authored
      Minor tweaks only.
      
      URL: https://trac.sagemath.org/22732
      Reported by: jmantysalo
      Ticket author(s): Jori Mäntysalo
      Reviewer(s): Travis Scrimshaw
      32be2bc1
    • Release Manager's avatar
      Trac #22716: Faster Posets.SetPartitions() · 7bd7ff5f
      Release Manager authored
      Before this one-line patch:
      
      {{{
      sage: timeit("L = Posets.SetPartitions(4)")
      5 loops, best of 3: 482 ms per loop
      sage: timeit("L = Posets.SetPartitions(5)")
      5 loops, best of 3: 5.63 s per loop
      }}}
      
      and after
      
      {{{
      sage: timeit("L = Posets.SetPartitions(4)")
      5 loops, best of 3: 175 ms per loop
      sage: timeit("L = Posets.SetPartitions(5)")
      5 loops, best of 3: 1.04 s per loop
      }}}
      
      URL: https://trac.sagemath.org/22716
      Reported by: jmantysalo
      Ticket author(s): Jori Mäntysalo, Travis Scrimshaw
      Reviewer(s): Travis Scrimshaw, Jori Mäntysalo
      7bd7ff5f
    • Release Manager's avatar
      Trac #22624: little cleanup of Dokchister lfunction file · 8871671b
      Release Manager authored
      plus one added example : Dedekind zeta of a number field
      
      URL: https://trac.sagemath.org/22624
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Jori Mäntysalo
      8871671b
    • Release Manager's avatar
      Trac #22608: Remove PYTHONPATH environment variable from sage · 6281da03
      Release Manager authored
      Following sage-devel PYTHONPATH breaks
      Python3[https://groups.google.com/forum/#!topic/sage-devel/ITtF1vWIxIk]
      
      Having PYTHONPATH sets as an environment variable is reported to be
      incompatible with the installation of both Python2 and Python3 and with
      the use of gdb to debug.
      
      We should remove the setting of the PYTHONPATH environment variable
      
      URL: https://trac.sagemath.org/22608
      Reported by: vklein
      Ticket author(s): Vincent Klein, Volker Braun
      Reviewer(s): Vincent Delecroix
      6281da03
    • Release Manager's avatar
      Trac #13517: Voronoi diagrams · 78bfe756
      Release Manager authored
      a feature request:  Voronoi diagrams, see
      [https://groups.google.com/d/topic/sage-devel/JgqyInSu8S8/discussion]
      
      A list of things that could be included in an implementation of Voronoi
      diagrams could be:
      
       * the graph structure of the Voronoi diagram and it's dual, the
      Delaunay triangulation
       * generalizations
         * Voronoi diagrams with weights (possibly empty regions!)
         * Voronoi diagrams with respect to other metrics (regions not
      necessary convex Polyhedra anymore)
         * farthest points Voronoi diagrams
       * a closest pair method for the list of points/ nearest neighbor
       * a plotting routine in 2d and 3d
      
      Perhaps in the file sage/geometry/triangulation/point_configuration.py
      
      URL: https://trac.sagemath.org/13517
      Reported by: moritz
      Ticket author(s): Moritz Firsching
      Reviewer(s): Jean-Philippe Labbé
      78bfe756
    • Release Manager's avatar
      Trac #22743: little cleanup of Wehler K3 · 001535f7
      Release Manager authored
      in particular to make that all elements of orbits belong to the K3
      itself.
      
      plus a general pyflakes cleanup
      
      URL: https://trac.sagemath.org/22743
      Reported by: chapoton
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Ben Hutz
      001535f7
    • Release Manager's avatar
      Trac #22723: backend_polymake: Work around polymake bug with zero inequalities... · 87addfba
      Release Manager authored
      Trac #22723: backend_polymake: Work around polymake bug with zero inequalities over quadratic extensions
      
      Following up on #22683:
      
      Easy workaround for a segfault, as discussed and suggested at
      https://forum.polymake.org/viewtopic.php?f=8&t=547
      
      See also: #22710: Meta-ticket: polymake
      
      URL: https://trac.sagemath.org/22723
      Reported by: mkoeppe
      Ticket author(s): Matthias Koeppe
      Reviewer(s): Travis Scrimshaw
      87addfba
    • Release Manager's avatar
      Trac #22683: backend_polymake for Polyhedron · 4262c41c
      Release Manager authored
      Building upon #22658 (Support interface coercion `polymake(X)` for
      `Polyhedron`), we provide a backend in `backend_polymake.py` that does
      all `Polyhedron` computations using polymake (in particular, the initial
      computation of the double description).
      
      For quadratic field extensions of the rationals, this backend should be
      faster than the generic implementation in Python (unless the pexpect
      overhead dominates).
      
      URL: https://trac.sagemath.org/22683
      Reported by: mkoeppe
      Ticket author(s): Matthias Koeppe
      Reviewer(s): Travis Scrimshaw
      4262c41c
    • Release Manager's avatar
      Trac #22681: needless quadratic time code in number_field.py · 58dd945b
      Release Manager authored
      {{{sage/src/sage/rings/number_field}}} contains the following loop:
      
      {{{
         7292             if both_maps and K.degree() == self.degree():
         7293                 g = K['x'](self.polynomial())
         7294                 v = g.roots()
         7295                 a = from_K(K.gen())
         7296                 for i in range(len(v)):
         7297                     r = g.roots()[i][0]
         7298                     to_K = self.hom([r])    # check=False here
      ??
         7299                     if to_K(a) == K.gen():
         7300                         break
      }}}
      
      Line 7297 should read {{{r = v[i][0]}}} .
      
      This actually leads to a huge speed-up.
      
      URL: https://trac.sagemath.org/22681
      Reported by: culler
      Ticket author(s): Frédéric Chapoton
      Reviewer(s): Vincent Delecroix
      58dd945b
    • Release Manager's avatar
      Trac #22139: Poset: Add certificate to is_[meet|join]_semilattice · de87bba5
      Release Manager authored
      This patch will add a `certificate`-option to functions checking finite
      poset is a semilattice.
      
      I also suggest removing deprecated `meet_matrix()` and `join_matrix()`
      for posets (they are not at lattices).
      
      URL: https://trac.sagemath.org/22139
      Reported by: jmantysalo
      Ticket author(s): Jori Mäntysalo
      Reviewer(s): Travis Scrimshaw
      de87bba5
    • Release Manager's avatar
      Trac #21682: Add a separate "build_cython" command to setup.py · f8cfd68d
      Release Manager authored
      This is a follow-on to #21600.  It adds a new `cythonize` command to the
      `setup.py`, and moves most of the logic for running `cythonize()`
      (previously in the customized `build_ext`) command, into this new
      command.
      
      The new `cythonize` command is run always from `build_ext` anyways, but
      this has a couple advantages:
      
      1) It is possible to run ''just'' `cythonize`, without compiling
      extension modules.  This maybe isn't that common, but can be useful for
      development, especially when testing issues with Cython itself.  It will
      also be useful for generating source distributions, where we might want
      to ship Cythonized sources in the source tarball, and hence would need
      to generate them as part of the process of building the tarball (without
      necessarily compiling).
      
      This also allows passing options directly from the command-line to
      `cythonize`.  This isn't much taken advantage of currently but the
      possibility is there.
      
      2) Code is clearer and more modular.  Specific details for compiling
      cython code are kept separate from details for compiling C/C++ code.
      
      See also upstream discussion of a "generic" implementation:
      https://github.com/cython/cython/issues/1514
      
      URL: https://trac.sagemath.org/21682
      Reported by: embray
      Ticket author(s): Erik Bray
      Reviewer(s): Jeroen Demeyer
      f8cfd68d
    • Release Manager's avatar
      Trac #21270: Polyhedron RDF face lattice bug / intersection of polyhedra · 30033d75
      Release Manager authored
      As noted first on #20570, current Sage is not able to plot some LPs with
      irrational data. This appears to be due to a bug in the Sage polyhedron
      code for RDF data (which InteractiveLP uses when the data are not
      rational).
      {{{
                  sage: poly = polytopes.regular_polygon(7)
                  sage: lp, x = poly.to_linear_program(solver='InteractiveLP',
      return_variable=True)
                  sage: lp.set_objective(x[0] + x[1])
                  sage: b = lp.get_backend()
                  sage: P = b.interactive_lp_problem()
                  sage: p = P.plot() ### ERROR
                  sage: p.show()
      }}}
      
      URL: https://trac.sagemath.org/21270
      Reported by: mkoeppe
      Ticket author(s): Moritz Firsching
      Reviewer(s): Jean-Philippe Labbé
      30033d75
  4. 04 Apr, 2017 1 commit
  5. 03 Apr, 2017 5 commits
  6. 02 Apr, 2017 13 commits