GitLab

https://en.wiktionary.org/wiki/explicitly

URL: https://trac.sagemath.org/28843
Reported by: mantepse
Ticket author(s): Martin Rubey
Reviewer(s): Travis Scrimshaw

and add the last missing ; in javascript

URL: https://trac.sagemath.org/28841
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

This will tell LGTM to use Python3 during its code analysis.

as suggested here:

https://lgtm.com/help/lgtm/analysis-faqs#how-python-version-identified

URL: https://trac.sagemath.org/28839
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Erik Bray

As the summary says

URL: https://trac.sagemath.org/28835
Reported by: jhpalmieri
Ticket author(s): John Palmieri
Reviewer(s): Dima Pasechnik

doc, pep8 and some little code changes

URL: https://trac.sagemath.org/28830
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

Currently starting SageNB fails with `"ImportError: cannot import name
'smtp' from 'twisted.mail'`. Add some nice message instead of that, like
"SageNB has been removed starting from SageMath 9.0."

URL: https://trac.sagemath.org/28792
Reported by: jmantysalo
Ticket author(s): Frédéric Chapoton
Reviewer(s): Jori Mäntysalo

​https://pari.math.u-bordeaux.fr/pub/pari/unix/pari-2.11.2.tar.gz

see also #28424 for pari 2.12 (more complicated upgrade)

URL: https://trac.sagemath.org/28840
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): François Bissey

Python 3 now emits a !ResourceWarning if you use the quick'n dirty
`open(...).read()` to read (or write) a file instead of a with context.
This leads to lots and lots of test failures of the form:
{{{
File "src/doc/en/prep/Symbolics-and-Basic-Plotting.rst", line 487, in
doc.en.prep.Symbolics-and-Basic-Plotting
Failed example:
    implicit_plot3d(p, (x, -r, r), (y, -r, r), (z, -r, r),
plot_points=50, color='yellow')
Expected:
    Graphics3d Object
Got:
    doctest:warning
      File "/home/buildbot-sage/slave/sage_git/build/src/bin/sage-
runtests", line 179, in <module>
        err = DC.run()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/control.py", line 1238, in run
        self.run_doctests()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/control.py", line 939, in run_do
ctests
        self.dispatcher.dispatch()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 2033, in dispat
ch
        self.parallel_dispatch()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 1925, in parall
el_dispatch
        w.start()  # This might take some time
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 2200, in start
        super(DocTestWorker, self).start()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/process.py", line 112, in start
        self._popen = self._Popen(self)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/context.py", line 223, in _Popen
        return
_default_context.get_context().Process._Popen(process_obj)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/context.py", line 277, in _Popen
        return Popen(process_obj)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/popen_fork.py", line 20, in __init__
        self._launch(process_obj)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/popen_fork.py", line 74, in _launch
        code = process_obj._bootstrap()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/multiprocessing/process.py", line 297, in _bootstrap
        self.run()
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 2172, in run
        task(self.options, self.outtmpfile, msgpipe, self.result_queue)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 2504, in __call
__
        doctests, extras = self._run(runner, options, results)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 2553, in _run
        result = runner.run(test)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 897, in run
        return self._run(test, compileflags, out)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/doctest/forker.py", line 1123, in compil
e_and_execute
        exec(compiled, globs)
      File "<doctest doc.en.prep.Symbolics-and-Basic-Plotting[45]>",
line 1, in <module>
        implicit_plot3d(p, (x, -r, r), (y, -r, r), (z, -r, r),
plot_points=Integer(50), color='yellow')
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/repl/rich_output/display_manager.py", line 811, in
displayhook
        plain_text, rich_output = self._rich_output_formatter(obj,
dict())
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/repl/rich_output/display_manager.py", line 625, in
_rich_output_formatter
        rich_output = self._call_rich_repr(obj, rich_repr_kwds)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/repl/rich_output/display_manager.py", line 585, in
_call_rich_repr
        return obj._rich_repr_(self)
      File "/home/buildbot-sage/slave/sage_git/build/local/lib/python3.7
/site-packages/sage/interfaces/tachyon.py", line 138, in __call__
        open(modelfile,'w').write(model)
      File "/home/buildbot-
sage/slave/sage_git/build/local/lib/python3.7/warnings.py", line 110, in
_showwarnmsg
        msg.file, msg.line)
    :
    ResourceWarning: unclosed file <_io.TextIOWrapper name='/home
/buildbot-
sage/slave/sage_git/dot_sage/temp/zen/3222347/tmp_j8lfc7ax.dat' mode='w'
encoding='UTF-8'>
    Graphics3d Object
}}}

URL: https://trac.sagemath.org/28833
Reported by: vbraun
Ticket author(s): Frédéric Chapoton
Reviewer(s): Volker Braun

remove the last use of GAP pexpect in that file;

remove no longer needed #optional tags in some tests

URL: https://trac.sagemath.org/28818
Reported by: dimpase
Ticket author(s): Dima Pasechnik
Reviewer(s): David Coudert

This ticket implements a method to initialize a cone from vertices,
rays, inequations and equalities.

More precisely
- we outsource a new method `_cone_from_normaliz_data` from the existing
method `_init_from_normaliz_data`.
- Then we add a method `_cone_from_Vrepresentation_and_Hrepresentation`,
which returns a cone form `vertices`, `rays`, `ieqs` and `eqns`.

Note that lines must be recomputed, hence the cone might reorder them.

The trivial cases of neither rays nor lines or without inequalities are
not covered by this method. In either case `None` is returned.

As a follow up we
- fix `Polyhedron_normaliz.save` in #26363,
- we allow converting to `'normaliz'` backend with both Vrep and Hrep in
the spirit of #22701.

URL: https://trac.sagemath.org/28639
Reported by: gh-kliem
Ticket author(s): Jonathan Kliem
Reviewer(s): Travis Scrimshaw

Since `SageNB` is now an optional package, we should detect whether it's
present before doctesting its files via `make ptestlong` and similar
commands.

URL: https://trac.sagemath.org/28834
Reported by: jhpalmieri
Ticket author(s): John Palmieri
Reviewer(s): Frédéric Chapoton

This allows to specify the python version,
and to exclude some of the most common errors that are specific to sage

see https://trac.sagemath.org/ticket/28839

Dima Pasechnik authored Nov 28, 2019 and Dima Pasechnik committed Dec 04, 2019

also, use libgap.load_package rather than LoadPackage
to automatically silence too noisy GAP

convert HJ graph construction to libgap

When creating an order, the function field code searches for an element
in the order (an integral element) that also generates the function
field.  It does so by looping over the order's basis elements to find
one whose minimal polynomial has the same degree as the field extension.
If none of the basis elements meet this condition, the code currently
detects this with an `if` statement, but will probably throw an
exception when it tries to access an attribute (`_kummer_places`) that
never got assigned because it was in the `if` block.

The condition is always met for all of our test cases, and I suspect
that it will always be met, though I don't have a proof for this right
now.  If it is possible that the condition might not be met, then the
current code would trigger an eventual exception.

This ticket replaces the `if` block with an `assert`, which I think is
more in the spirit of what this code is doing.

URL: https://trac.sagemath.org/28822
Reported by: gh-BrentBaccala
Ticket author(s): Brent Baccala
Reviewer(s): Markus Wageringel

URL: https://trac.sagemath.org/28826
Reported by: gh-mwageringel
Ticket author(s): Markus Wageringel
Reviewer(s): Frédéric Chapoton

with Sage 8.8:
{{{
sage: R.<y> = QQ[]
sage: T.<z> = R.quotient(y+1)
sage: u = T(91/131)
sage: w = T(-1)
sage: w.norm()
-1
}}}
How can it be the norm of a polynomial can be negative?

URL: https://trac.sagemath.org/28476
Reported by: zimmerma
Ticket author(s): Dave Morris
Reviewer(s): Markus Wageringel

For example, I modify
`~/.sage/ipython-5.0.0/profile_default/ipython_config.py` to set the
`c.TerminalInteractiveShell.colors` to a different value, and get test
failures in REPL tests where different terminal color codes are output
than expected.

There's all kinds of other ways, I'm sure, that different
ipython_config.py settings could cause tests to fail.

Loading this file should be prevented when running the tests.

It occurs to me now that this is the cause of some of the failures
reported in #25361, since the Windows installer sets some specific
defaults in ipython_config.py.

URL: https://trac.sagemath.org/28289
Reported by: embray
Ticket author(s): Erik Bray
Reviewer(s): Markus Wageringel

replacing the old CombinatorialClass by EnumeratedSet

URL: https://trac.sagemath.org/28825
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

using list comprehension instead

URL: https://trac.sagemath.org/28821
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

and remove the corresponding parts of the Makefile.

and don't try to doctest it if it's not.

This is a follow-up to #25129 which attempted to fix script paths in the
ThreeJS template on Windows.

It works in Chrome, however as reported on [https://github.com/sagemath
/sage-windows/issues/38 GitHub] it does not work on Firefox for Windows,
which is a bit fussier about how file paths are formatted in script
tags.

URL: https://trac.sagemath.org/28801
Reported by: embray
Ticket author(s): Erik Bray
Reviewer(s): Travis Scrimshaw

The method `change_ring` is not always working when we pass in a
morphism.

{{{
sage: K = GF(5^2)
sage: S.<x> = K[]
sage: P = S.random_element()
sage: P.change_ring(K.frobenius_endomorphism())
Traceback (most recent call last):
...
TypeError:
}}}

The current code is weird: it calls the method `hom` with a morphism as
first argument (instead of the list the images of generators). Instead,
I propose to fall back to `map_coefficients`.

URL: https://trac.sagemath.org/28541
Reported by: caruso
Ticket author(s): Xavier Caruso
Reviewer(s): Marc Mezzarobba, Markus Wageringel

The classes in `symbolic/function.pyx` need better docs, esp. the
parameters.

URL: https://trac.sagemath.org/24398
Reported by: rws
Ticket author(s): Ralf Stephan
Reviewer(s): Markus Wageringel, Dima Pasechnik

a routine update incorporating several PRs since 1.1.2

tarball: https://github.com/sagemath/sagenb/releases/download/1.1.3/sage
nb-1.1.3.tar.bz2

URL: https://trac.sagemath.org/28710
Reported by: dimpase
Ticket author(s): Dima Pasechnik
Reviewer(s): Markus Wageringel

I've seen fork-related problems in the tests of this module before,
although this is the first time it's come up again in a while.

They seem to occur because the temporarily generated DLL modules output
by `cython()` can end up in an address space that overlaps with some
other modules, and then any subsequent `fork()` will fail.

The problem tends to manifest itself, in the test failures, in the form
of an error like:

{{{
EnvironmentError: pkg-config is probably not installed. Could not run
pkg-config: OSError(11, 'Resource temporarily unavailable')
}}}

This is because Python is trying to `fork()` to run the `pkg-config`
program, and that fails.  The problem isn't really anything to do with
`pkg-config` itself.

Two strange observations:

* It works ''most of the time'' if I run
  {{{
  ./sage -t --serial --long src/sage/misc/cython.py
  }}}
  Which means the tests are not running from a forked process to begin
with.  It's still strange though, because running `pkg-config` in the
tests still means `fork()` is being called during the serial test run,
and not failing.

* It works ''some of the time'', or sometimes with at least fewer
failures, if I run:
  {{{
  ./sage -t --verbose --long src/sage/misc/cython.py
  }}}
  This implies to me that there might be some kind of race condition
involved, since merely running with the verbose output seems to decrease
the chances of failure.

URL: https://trac.sagemath.org/28258
Reported by: embray
Ticket author(s): Erik Bray
Reviewer(s): Volker Braun