Commit 9177a7a1 authored by Tomasz Maczukin's avatar Tomasz Maczukin Committed by Tomasz Maczukin

Merge branch...

Merge branch '4108-follow-up-from-use-delayed-variable-expansion-for-error-check-in-cmd' into 'master'

Unexport common.RepoRemoteURL

Closes #4108

See merge request gitlab-org/gitlab-runner!1276
parent 6a6841bf
......@@ -20,7 +20,7 @@ import (
)
const (
RepoRemoteURL = "https://gitlab.com/gitlab-org/ci-cd/tests/gitlab-test.git"
repoRemoteURL = "https://gitlab.com/gitlab-org/ci-cd/tests/gitlab-test.git"
repoRefType = RefTypeBranch
......@@ -76,7 +76,7 @@ func GetRemoteSuccessfulBuild() (JobResponse, error) {
func GetRemoteSuccessfulLFSBuild() (JobResponse, error) {
response, err := GetRemoteBuildResponse("echo Hello World")
response.GitInfo = GetLFSGitInfo(RepoRemoteURL)
response.GitInfo = GetLFSGitInfo(repoRemoteURL)
return response, err
}
......@@ -187,7 +187,7 @@ func getBuildResponse(repoURL string, commands []string) JobResponse {
}
func GetRemoteBuildResponse(commands ...string) (JobResponse, error) {
return getBuildResponse(RepoRemoteURL, commands), nil
return getBuildResponse(repoRemoteURL, commands), nil
}
func GetLocalBuildResponse(commands ...string) (JobResponse, error) {
......
......@@ -868,7 +868,7 @@ func TestBuildChangesBranchesWhenFetchingRepo(t *testing.T) {
assert.Contains(t, out, "Created fresh repository")
// Another build using the same repo but different branch.
build.GitInfo = common.GetLFSGitInfo(common.RepoRemoteURL)
build.GitInfo = common.GetLFSGitInfo(build.GitInfo.RepoURL)
out, err = runBuildReturningOutput(t, build)
assert.NoError(t, err)
assert.Contains(t, out, "Checking out 2371dd05 as add-lfs-object...")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment