False experience and progress info shown at times
Outline of bug / Description du bug
Although not quite a translation-issue, it's a text-issue still...
False EXP-info will be shown at times when the phrase progress_death_penalty_payback is shown, this as it doesn't adjust to cases where skill level is master (250) or when EXP (i) is 0.
https://gitlab.com/search?search=progress_death_penalty_payback&group_id=5948958&project_id=14243422&scope=&search_code=true&snippets=false&repository_ref=main%2Fgingo-test&nav_source=navbar
False subscribe to gain EXP shown at times when the phrase progress_free_trial_limit is shown, this as it doesn't check if progress is actually possible.
https://gitlab.com/search?search=progress_free_trial_limit&group_id=5948958&project_id=14243422&scope=&search_code=true&snippets=false&repository_ref=main%2Fgingo-test&nav_source=navbar
How to reproduce bug / Comment reproduire
Use a character with a death penalty:
- While subscribed, use a skill lv250 and kill any mob around lv250 and check system info, it'll claim the character would've gained more than 0 EXP which is an impossibility.
- While un-subscribed free-to-play, use a skill lv250 and kill any mob around lv250 and check system info, it'll claim the character would've gained more than 0 EXP if re-subscribed which is an impossibility too.
Expected behavior / Ce que vous attendiez
Second sentence only shown when EXP > 0 gained is for real.
A simple check like:
IF SKILL_LEVEL == 250 OR GAINED_EXP == 0
THEN DISPLAY SPLIT(progress_death_penalty_payback @ ". ")[0] (To display only first of the two sentences.)
AND DO_NOT_DISPLAY progress_free_trial_limit
...should do it perhaps? (Although at appropriate locations for each in the code of course.)
Actual result / Ce que vous avez obtenu
Currently it falsely claims, in both cases, that the player would've gotten EXP even though they wouldn't. Also claims they would've gained EXP if they payed up, which they wouldn't either.