JaSMIn crashes pretty frequently for me with an out of memory error. Have you ever seen that?
I took a heap snapshot in the Chrome dev tools (not in the case of the crash, the dev tools aren't accessible anymore after that). The Heap had 410 MB in this example, which seems a bit much? On YouTube, it's around 50 while viewing a video on 720p.
I would have attached the heap snapshot, but it has 146 MB itself.
Hey Jens,
overall I think there is no significant memory leak any longer. In Firefox I'm now down to 30MB of memory usage when playing a 3D replay file and this number is relatively constant while playing and reproducible even when playing multiple replays with the same monitor instance. Chrome for some reason still uses around 60MB of memory for doing the very same thing. I guess memory optimization remains a constant in this project.
Anyhow, all the best, Stefan
PS: Long time ago since we met last time. Hope you are fine!
Stefan Glaser (9b8e1d1a) at 03 Feb 20:20
Fixed stylesheet link in embedded-player.html.
Dear @tknrkb,
I'm happy to report that I finally pushed the 3rd version of JaSMIn. Apart from some minor updates it also fixes the reported issue. I'm really sorry for the delay. Hope you still enjoy it.
You'll find the current version hosted at archive.robocup.info.
Best Regards,
Stefan
Stefan Glaser (9b8e1d1a) at 03 Feb 19:52
Fixed stylesheet link in embedded-player.html.
Stefan Glaser (6ef46b4d) at 03 Feb 19:16
Fixed script link in embedded-player.html.
... and 10 more commits
Stefan Glaser (6ef46b4d) at 03 Feb 19:13
Fixed script link in embedded-player.html.
Dear @tknrkb,
thank you very much for reporting this issue!
Quoting my Professor: "The best bug reports are those that already contain the fix to the bug" ;) Great job!
Unfortunately, I have to say that I already know and even fixed this bug more than half a year ago in the 3rd Version of JaSMIn - that I never published. It's a shame that this bug still exists and totally my fault. Sorry for that.
I'll take care of this issue this weekend.
When I have played 2D logs at http://archive.robocup.info/ by Google Chrome.
There is a alert message Loading game log failed: TypeError: Cannot read property 'a' of undefined
.
a quick hack
src/js/model/logplayer/log_player.js
/**
* Update the upcoming and passed goal counts.
*/
JaSMIn.LogPlayer.prototype.updateGoalCounts = function() {
if (this.gameLog.states.length == 0) return; // <-- add this line
var idx = this.gameLog.gameScoreList.indexOf(this.gameLog.states[this.playIndex].score);
this.upcomingGoals = 0;
this.passedGoals = 0;
for (var i = 1; i < this.gameLog.gameScoreList.length; i++) {
if (i <= idx) {
this.passedGoals++;
} else {
this.upcomingGoals++;
}
}
};
Stefan Glaser (7d43ff9c) at 16 Oct 12:47
Added initial version of JaSMIn Gitlab page.