irg issueshttps://gitlab.com/robit.a/irg/-/issues2018-12-15T02:15:58Zhttps://gitlab.com/robit.a/irg/-/issues/19couple of workflow changes2018-12-15T02:15:58ZAlec L. Robitaillecouple of workflow changes## Changes:
Same up to `model_start`.
### `model_start`
* [x] Returns 'xmidS_start' and 'xmidA_start' instead of 'xmidS' and 'xmidA'
### `model_params` #13
* [x] Results are added to the DT if 'returns' is columns, else if models - returns models
* [x] Starting arguments either a column name for group level starts or numeric global
* [x] add to man that if NULL, didn't fit
### `model_ndvi` #14
* [x] if observed = TRUE, don't grow, just append to DT
* [x] if observed = FALSE, grows
* [x] ~~add flag to observed days if observed = FALSE?~~
### `calc_irg` #15
* [x] just calculates it with what you have
* [x] model_ndvi will realistically always be run, so no reason to add 'fitted' arg
* [x] ~~tempting to drop scaled too...~~
## Closed when:
* [x] tests passing
* [x] examples fixed throughout
* [x] vignette updated
* [x] CRAN checks passing## Changes:
Same up to `model_start`.
### `model_start`
* [x] Returns 'xmidS_start' and 'xmidA_start' instead of 'xmidS' and 'xmidA'
### `model_params` #13
* [x] Results are added to the DT if 'returns' is columns, else if models - returns models
* [x] Starting arguments either a column name for group level starts or numeric global
* [x] add to man that if NULL, didn't fit
### `model_ndvi` #14
* [x] if observed = TRUE, don't grow, just append to DT
* [x] if observed = FALSE, grows
* [x] ~~add flag to observed days if observed = FALSE?~~
### `calc_irg` #15
* [x] just calculates it with what you have
* [x] model_ndvi will realistically always be run, so no reason to add 'fitted' arg
* [x] ~~tempting to drop scaled too...~~
## Closed when:
* [x] tests passing
* [x] examples fixed throughout
* [x] vignette updated
* [x] CRAN checks passingv 0.1.0Alec L. RobitailleAlec L. Robitaillehttps://gitlab.com/robit.a/irg/-/issues/18option: observed?2018-12-15T02:17:40ZAlec L. Robitailleoption: observed?Instead of returning (with `irg::irg` or individual steps) the full year's worth of IRG values, should there be an option to simply calculate for the observed samples' julian day?
E.g.:
```r
library(data.table)
library(irg)
ndvi <- fread(system.file("extdata", "ndvi.csv", package = "irg"))
filter_ndvi(ndvi)
scale_doy(ndvi)
scale_ndvi(ndvi)
model_start(ndvi)
model_params(ndvi, observed = TRUE, ...)
```
...Returns appended ndvi with model params...
```r
model_ndvi(ndvi, observed = TRUE)
calc_ndvi(ndvi, observed = TRUE)
```
...Returns appended ndvi with observed "fitted" and observed "irg"...Instead of returning (with `irg::irg` or individual steps) the full year's worth of IRG values, should there be an option to simply calculate for the observed samples' julian day?
E.g.:
```r
library(data.table)
library(irg)
ndvi <- fread(system.file("extdata", "ndvi.csv", package = "irg"))
filter_ndvi(ndvi)
scale_doy(ndvi)
scale_ndvi(ndvi)
model_start(ndvi)
model_params(ndvi, observed = TRUE, ...)
```
...Returns appended ndvi with model params...
```r
model_ndvi(ndvi, observed = TRUE)
calc_ndvi(ndvi, observed = TRUE)
```
...Returns appended ndvi with observed "fitted" and observed "irg"...v 0.1.0Alec L. RobitailleAlec L. Robitaillehttps://gitlab.com/robit.a/irg/-/issues/6example data2018-12-14T19:28:20ZAlec L. Robitailleexample data* [x] min two individuals
* [x] all years
* [x] man* [x] min two individuals
* [x] all years
* [x] manv 0.1.0Alec L. RobitailleAlec L. Robitaille