Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
RedWarn Web
RedWarn Web
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • RedWarn
  • RedWarn WebRedWarn Web
  • Issues
  • #62

Closed
Open
Opened Jan 17, 2021 by Chlod Alejandro@ChlodAlejandro🐢Owner

Prevent stray clicks to rollback icons

Describe your suggestion

With great speed comes great capacity to make mistakes, and stray clicks are a common occurrence due to the way the DOM quickly flexes to make space for RedWarn. Additionally, RedWarn no longer displays a dialog for quick rollback buttons, making it easy to misclick. Thus, it may be important to implement a method to block stray clicks if the rollback icons have been inserted within a short enough period of time.

The plan is to block, or ask confirmation for, clicks to RedWarn rollback icons if the icon had only been inserted to the DOM less than 200ms prior. This should be enough time to avoid accidental stray clicks due to insertion.

An additional idea is to also block movement-based stray clicks, meaning asking for confirmation if the cursor was moving too fast prior to clicking (to a threshold to be determined sometime).

This should hopefully decrease the occurrence of stray clicks both due to DOM insertion or rapid mouse movement.

An alternative to (or possibly a better choice versus) this idea is providing a cancel button which prevents sending the edit API request. This wastes a bit of data (due to the earlier page content pull), however can prevent actions given enough reaction time. We can also just trout anyone who makes mistakes.

Settings

For both blocks, there should be an option to configure whether the action a) is blocked entirely, b) requires confirmation, or c) is permitted. Additionally, the threshold as to how early since DOM insertion and how fast the cursor is moving should also be configurable. Since this feature may be annoying to some users, the possibility of having this safety feature disabled by default should be considered.

Assignee
Assign to
RedWarn TypeScript Rewrite
Milestone
RedWarn TypeScript Rewrite
Assign milestone
Time tracking
None
Due date
None
Reference: redwarn/redwarn-web#62