Merge Request Required Information
Summary of Changes
Context of the pull-request:
Finalization of MR !15 (closed). The MR fixes issue of RDoc erroring when there is a comment on a multiline method chain such as this:
method1 #comment
.method2
The test included with the patch tests this behavior. Note that I had to adjust the test file path to the test in the upstream patch to apply it correctly to Ruby sources.
I have added a commit that fixes build failures. See commit message and related links in the specfile for more detailed explanation.
RPM scratch build: https://brew*****.redhat.com/brew/taskinfo?taskID=53405751
C8S scratch build: https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=2367557
Modular scratch build: https://mbs.stream.rdu2.redhat.com/module-build-service/2/module-builds/464
TODO:
-
Cleanup the repo from extra files. Similarly to the recent 2.7.8 upgrade in !14 (merged).Done. -
Check other gems in the Ruby 2.5 module that they have correct content.Done. rubygem-posgresql needs a fix for FTBFS (rubygem-pg!4 (merged)), other rubygems only have SHA512 introduction insourcesand changes in .gitignore. Nothing warranting a fix.
Pull-request or commit in Fedora Rawhide:
Not required for the RDoc issue, 2.6 upto 3.2 (didn't test further and upstream has test included), are not affected, and the rest are CVEs that are already fixed in Fedora versions.
Select priority:
-
urgent -
high -
medium -
low -
unspecified
Do you need someone's review?:
-
Yes Later when I clear the TODO items. -
No, because:
Approved Bugzilla Ticket
All submissions to CentOS Stream are required to have an approved Red Hat Bugzilla ticket in a commit message, except only changing dot or yaml files. Please follow the CentOS Stream contribution documentation.
rhbz#2210326