ceph_monitoring.py updates
Created by: mattt416
In the short term, we should make the following changes:
--type isn't marked as required, but the script fails to run if you don't specify it
--osd_ids says comma-separated, but needs to be space-separated and should indicate that this needs to be specified when --type osd
--host help information is not helpful, should indicate that this is a MON hostname and required --type mon
In the long, it'd be better to change --type to a positional argument and then have different subparsers for each type. This would allow us to make --osd_ids required when we specify osd as the positional argument, --host required when mon is the positional argument, etc.
Imported comments:
By mattt416 on 2015-10-01 13:36:55 UTC
Hi @git-harry , just close this off once you incorporate the minor changes into https://github.com/rcbops/rpc-openstack/pull/380. Thanks!
By git-harry on 2015-10-01 15:04:21 UTC
@mattt416 are you able to test this?
By git-harry on 2015-10-06 10:34:07 UTC
Addressed by #380