Skip to content

gnomeShellOverride: Avoid passing undefined className into replaceMethod

Daniel van Vugt requested to merge vanvugt/desktop-icons-ng:fix-lp1963756 into master

On Ubuntu 22.04 (preview) at the moment with the latest mozjs+gjs but an old gnome-shell (41.3), it's possible that DING will fail to start in Xorg sessions:

gnome-shell[25609]: Some code accessed the property 'WorkspaceGroup' on the
  module 'workspaceAnimation'. That property was defined with 'let' or
  'const' inside the module. This was previously supported, but is not
  correct according to the ES6 standard. Any symbols to be exported from a
  module must be defined with 'var'. The property access will work as
  previously for the time being, but please fix your code anyway.
gnome-shell[25609]: JS ERROR: TypeError: className is undefined
  replaceMethod@.../ding@rastersoft.com/gnomeShellOverride.js:84:49
  enable@.../ding@rastersoft.com/gnomeShellOverride.js:47:22

This has been fixed already in gnome-shell 42, but we should also ensure DING doesn't fail to load in gnome-shell 41 and older.

https://launchpad.net/bugs/1963756

Merge request reports