Commit 2811c75a authored by Radford Neal's avatar Radford Neal

Merge branch '88-fixes' into 91-gradient

parents 4ee15ef4 cbc944da
......@@ -33,6 +33,21 @@
to names (as had been intended) when the result had its
dimensions dropped, and only one dimension had names.
\item From R-3.1.1: For a formula with exactly 32 variables the 32nd variable
was aliased to the intercept in some C-level computations of
terms, so that for example attempting to remove it would remove
the intercept instead (and leave a corrupt internal structure).
[ Note: This also fixes problems with formulas
having zero variables, as manifested, for example, in
\preformatted{ update.formula (~1, ~. - y)
Thanks to Marduk Bolanos for this example (pqR issue #40). ]
Fixes immediately after pqR-2018-11-18.
Fixes after pqR-2018-11-18, and then after 2019-02-19.
Includes doc fixes for standard distributions.
Fix from R-3.1.1 for problem with update.formula(~1, ~. - y)
......@@ -827,7 +827,9 @@ static SEXP do_termsform(SEXP call, SEXP op, SEXP args, SEXP rho)
a = CDR(a);
nvar = length(varlist) - 1;
nwords = (nvar - 1) / WORDSIZE + 1;
/* In allocating words need to allow for intercept term */
nwords = (int) (nvar / WORDSIZE + 1);
/* Step 2: Recode the model terms in binary form */
/* and at the same time, expand the model formula. */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment