Skip to content

Hotfix: Update param after changing phase (#432)

Axel E. Anderssonrequested to merge
fix-phase-shift into main

Explanation of changes

ShiftClockPhase operation in a Schedule now also adds an upd_param to target Q1ASM program. As a consequence this increases the duration of the operation from 0 ns to 8 ns.

Motivation of changes

There was a bug when concatenating two operations which involve ShiftClockPhase.

Only the last ShiftClockPhase operation would be applied, since only the last value was cached.

This was fixed by calling upd_param after updating the phase.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md and AUTHORS.md have been updated (or N/A).
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Edited by Edgar Reehuis

Merge request reports