Skip to content

Resolve "Qblox backend does not support negative latencies"

Tobias Bonsenrequested to merge
379-qblox-backend-does-not-support-negative-latencies into main

Explanation of changes

Updates the extract_latencies(hw_cfg) method out of the zhinst backend to backends.corrections.determine_relative_latencies(hw_cfg). This method first finds all the port-clocks in the hw_cfg and sets a latency value for each of them in the latency_config dict (default 0). The minimum of all latencies is then subtracted from all latencies to ensure minimal wait times and to allow for negative latencies (#379 (closed)). This method is called in both the qblox and zhinst backends to find the latency_corrections dict that is used in their respective compilations.

Motivation of changes

Closes #379 (closed)

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md and AUTHORS.md have been updated (or N/A).
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Edgar Reehuis

Merge request reports