Skip to content

Fix issue with outputting real signals on even output paths (qblox hardware, QAE-173)

Explanation of changes

The odd output channels (1 and 3) of a pulsar/cluster module typically output purely real signal (I) and the even ones(2 and 4) typically output an imaginary signal (Q). To output a purely real signal (no Q component) on even output paths of a Pulsar/Cluster module, the signals are first converted to purely imaginary signal (only Q component) preserving the amplitude and then outputted accordingly. This is currently not possible due to a bug in The file quantify_scheduler/backends/qblox/operation_handling/pulses.py in line 116.

This MR corrects for the bug in line 116 in its first commit. The real signals coming out of even output paths to have a 90 degree phase shift which needs to be accounted for while using it.


Merge checklist

See also merge request guidelines

  • Merge request has been reviewed and approved by a project maintainer.
  • Merge request contains a clear description of the proposed changes and the issue it addresses.
  • Merge request made onto appropriate branch (main for most MRs).
  • New code is fully tested.
  • New code is documented and docstrings use numpydoc format.
  • CHANGELOG.rst and AUTHORS.rst have been updated (when applicable).
  • CI pipelines pass
    • pre-commit run --all-files --hook-stage commit passes (gitlab-ci),
    • test suite passes (gitlab-ci),
    • no degradation in code-coverage (codacy),
    • no (serious) new pylint code quality issues introduced (codacy),
    • documentation builds successfully (CI and readthedocs),
    • windows tests pass (manually triggered by maintainers before merging).

For reference, the issues workflow is described in the contribution guidelines.

Edited by Edgar Reehuis

Merge request reports

Loading