Fix for supplying negative NCO phase
Explanation of changes
@adamorangeqs was running into failure in supplying negative phase to ShiftClockPhase
.
This MR fixes that by taking phase_deg
modulo 360 to account for negative phase and phase larger than 360
(just before converting it to Q1ASM, done here:
https://gitlab.com/quantify-os/quantify-scheduler/blob/fix-negative-phase/quantify_scheduler/backends/qblox/operation_handling/virtual.py#L69-69)
Motivation of changes
ShiftClockPhase
is implemented as follows
if operation.name == "ShiftClockPhase":
return virtual.NcoPhaseShiftStrategy(operation)
so fixing the negative phase via NcoPhaseShiftStrategy
Merge checklist
See also merge request guidelines
-
Merge request has been reviewed and approved by a project maintainer. -
Merge request contains a clear description of the proposed changes and the issue it addresses. -
Merge request made onto appropriate branch (main for most MRs). -
New code is fully tested. -
New code is documented and docstrings use numpydoc format. -
CHANGELOG.rst
andAUTHORS.rst
have been updated (when applicable). -
CI pipelines pass -
pre-commit run --all-files --hook-stage commit
passes (gitlab-ci), - test suite passes (gitlab-ci),
- no degradation in code-coverage (codacy),
- no (serious) new pylint code quality issues introduced (codacy),
- documentation builds successfully (CI and readthedocs),
-
windows tests pass (manually triggered by maintainers before merging).
-
For reference, the issues workflow is described in the contribution guidelines.
Edited by Edgar Reehuis