mock_setup_basic_transmon in combination with set_standard_params_transmon should be replaced by the fixture mock_setup_basic_transmon_with_standard_params in tests
We have two fixtures `mock_setup_basic_transmon` and `mock_setup_basic_transmon_with_standard_params`. Currently, most tests that call the first fixture, also set the parameters of the underlying instruments using the function `set_standard_params_transmon` i.e.
``` python
def test_compile_cz_gate(
mock_setup_basic_transmon, hardware_cfg_two_qubit_gate, two_qubit_gate_schedule
):
# mock_setup_basic_transmon should arrange this but is not working here
tmp_dir = tempfile.TemporaryDirectory()
set_datadir(tmp_dir.name)
set_standard_params_transmon(mock_setup_basic_transmon)
```
and this should be replaced with
``` python
def test_compile_cz_gate(
mock_setup_basic_transmon_with_standard_params, hardware_cfg_two_qubit_gate, two_qubit_gate_schedule
):
# mock_setup_basic_transmon should arrange this but is not working here
tmp_dir = tempfile.TemporaryDirectory()
set_datadir(tmp_dir.name)
mock_setup = mock_setup_basic_transmon_with_standard_params
...
```
For the future developer that picks up this task: might be nice to read about pytest fixtures and yield fixtures: https://docs.pytest.org/en/7.1.x/how-to/fixtures.html#teardown-cleanup-aka-fixture-finalization
issue