Skip to content

QTFY-695/QTFY-696 Deal with QCoDeS DeprecationWarning

Fabio Grigolorequested to merge
QTFY-695-qcodes-deprecation-warnings into main

Explanation of changes

I'm fixing both QTFY-695 and QTFY-696 in one MR because the changes are very small.

Motivation of changes

In both cases (reference_source and clock_freqs) I keep the logic of "setting by function call".

There was an issue with test_prepare_rf and test_prepare_qtm because this assertion:

ic_cluster.instrument.reference_source.assert_called_once()

was incorrect: it was only counting 1 call because of the previous initialisation stage:

ic_cluster.instrument.reference_source("internal")  # Put it in a known state

Rather than deleting the assertion entirely, I've parametrised the call count. Now reference_source is called directly (instead of .set()) and thus increments the count, while lazy_set does some shenanigans that do not trigger the parameter's "callable" setter.

Merge checklist

See also merge request guidelines

  • Merge request has been reviewed (in-depth by a knowledgeable contributor), and is approved by a project maintainer.
  • New code is covered by unit tests (or N/A).
  • New code is documented and docstrings use numpydoc format (or N/A).
  • New functionality: considered making private instead of extending public API (or N/A).
  • Public API changed: added @deprecated and entry in deprecated code suggestions (or N/A).
  • Newly added/adjusted documentation and docstrings render properly (or N/A).
  • Pipeline fix or dependency update: post in #software-for-developers channel to merge main back in or update local packages (or N/A).
  • Tested on hardware (or N/A).
  • CHANGELOG.md for breaking changes and AUTHORS.md have been updated (or N/A).
  • Update Hardware backends documentation if backend interface change or N/A
  • Check whether performance is significantly affected by looking at the Performance metrics results.
  • Windows tests in CI pipeline pass (manually triggered by maintainers before merging).
    • Maintainers do not hit Auto-merge, we need to actively check as manual tests do not block pipeline

For reference, the issues workflow is described in the contribution guidelines.

Merge request reports