WeightedThresholdedAcquisition protocol requires an additional -45 degree rotation

  • Quantify-scheduler version:v0.23.0
  • Quantify-core version (or n/a):v.0.8.1

Description

Describe what you were trying to get done.

What I Did

Describe specifically the steps taken, including pasting any commands which were input.

What Was Expected

Describe what behaviour you expected to happen, what output was desired, etc.

What Actually Happened

WeightedThresholdedAcquisition inherits from NumericalSeparatedWeightedIntegration. In this case thresholding requires an acquisition rotation and threshold. The reason for this is that NumericalSeparatedWeightedIntegration returns a tuple. Setting the acquisition rotation to 360-45 degrees is equivalent to acquiring with NumericalWeightedIntegration. For details see #454.

Suggestion to make WeightedThresholdedAcquisition inherit from NumericalWeightedIntegration. This would be beneficial for a user, as the parameter measure.acq_rotation does not need to be set anymore. This is good, because it would always need to be set to the same value.

You can also find us on Slack. For reference, the issues workflow is described in the contribution guidelines.

Edited by Tim Vroomans