Some coding and build issues
Created by: elfps
I have worked a little bit with the Qualikiz/TCI build on the gateway (ETS sntallation) and noted some issues.
a) there is an odd mix of declared precisions in the code in general where constants often are in single precision (e.g., 0.) and sometime they are even assigned in mixing with double precision or different kinds as in (/0., 0., dbl_prec_vec(1:n)/) the build then becomes very dependent on the functioning of a -r8 flag. This is not very well defined in all compilers (and not standardized) and furthermore I think that there is a risk of loos of precision and possible also performance.
b) there are also some input variables that are explicitly declared as single precision in a way which also seem strange (sol in Make_QLflux (QLflux.f90) seem but ne place) - same issues as above
c) I had some issues with uninitialized variables in particular in calltrapQLInts.f90 and callpassQLints.f90 (the rfonc* variables - the logic of initializing these seem to be either broken or not granular enough - and to be honest it was not clear to me why not just initialize these at the top )
(pär strand = elfps --- not sure how to improve the handle)