• Stefan Hajnoczi's avatar
    qemu/atomic.h: rename atomic_ to qatomic_ · d73415a3
    Stefan Hajnoczi authored
    clang's C11 atomic_fetch_*() functions only take a C11 atomic type
    pointer argument. QEMU uses direct types (int, etc) and this causes a
    compiler error when a QEMU code calls these functions in a source file
    that also included <stdatomic.h> via a system header file:
      $ CC=clang CXX=clang++ ./configure ... && make
      ../util/async.c:79:17: error: address argument to atomic operation must be a pointer to _Atomic type ('unsigned int *' invalid)
    Avoid using atomic_*() names in QEMU's atomic.h since that namespace is
    used by <stdatomic.h>. Prefix QEMU's APIs with 'q' so that atomic.h
    and <stdatomic.h> can co-exist. I checked /usr/include on my machine and
    searched GitHub for existing "qatomic_" users but there seem to be none.
    This patch was generated using:
      $ git grep -h -o '\<atomic\(64\)\?_[a-z0-9_]\+' include/qemu/atomic.h | \
        sort -u >/tmp/changed_identifiers
      $ for identifier in $(</tmp/changed_identifiers); do
            sed -i "s%\<$identifier\>%q$ident...
atomics.rst 24.6 KB