Regression 9.1.0-rc1: Adventcalendar 2016, Day 14 crashes

Host environment

• Operating system: Linux
• OS/kernel version: Linux rodrigo 6.1.0-23-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.99-1 (2024-07-15) x86_64 GNU/Linux
• Architecture: x86_64
• QEMU flavor: qemu-system-x86_64
• QEMU version: QEMU emulator version 9.0.90 (v9.1.0-rc0-44-g64f75f57f9-dirty)
• QEMU command line:

  qemu-system-x86_64 -net nic,model=virtio -net user,hostfwd=tcp::8080-:80 -drive file=acorn/acorn.img,format=raw,if=ide -serial stdio

Emulated/Virtualized environment

• Operating system: IncludeOS v0.9.2-39-ga77eedb
• OS/kernel version: n/a
• Architecture: n/a

Description of problem

Crashes with

 **** PANIC: ****
terminating with uncaught exception of type hw::Device_not_found: Device of type NIC not found at position #0

see acorn.log for details

Steps to reproduce

1. Download https://www.qemu-advent-calendar.org/2016/download/day14.tar.xz
2. Execute

Additional information

git bisect determines:

64f75f57f9d2c8c12ac6d9355fa5d3a2af5879ca is the first bad commit
commit 64f75f57f9d2c8c12ac6d9355fa5d3a2af5879ca
Author: David Woodhouse <dwmw@amazon.co.uk>
Date:   Tue Jul 9 13:34:44 2024 +0100

 net: Reinstate '-net nic, model=help' output as documented in man page
 
 While refactoring the NIC initialization code, I broke '-net nic,model=help'
 which no longer outputs a list of available NIC models.
 
 Fixes: 2cdeca04adab ("net: report list of available models according to platform")
 Cc: qemu-stable@nongnu.org
 Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
 Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
 Signed-off-by: Jason Wang <jasowang@redhat.com>

net/net.c | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)