8.2.0rc0 Regression: '-display vnc' opens gtk display as well
Host environment
- Operating system: Operating system: Linux
- OS/kernel version: Linux rodrigo 6.1.0-13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.55-1 (2023-09-29) x86_64 GNU/Linux
- Architecture: x86_64
- QEMU flavor: qemu-system-x86_64
- QEMU version: QEMU emulator version 8.1.50 - git bisect identifies 484629fc as the first bad commit
- QEMU command line:
build/qemu-system-x86_64 -display vnc=:05 -k de
Emulated/Virtualized environment
- Operating system: n/a
- OS/kernel version: n/a
- Architecture: n/a
Description of problem
A VNC display is requested, but a GTK frontend is opened as well. A VNC client is able to connect.
Steps to reproduce
- /configure --enable-fdt=internal --target-list=x86_64-softmmu
- make
- build/qemu-system-x86_64 -display vnc=:05 -k de
Additional information
git bisect finally shows
484629fc8141eaa257f961b5e5e310a1bbd0f1a2 is the first bad commit
commit 484629fc8141eaa257f961b5e5e310a1bbd0f1a2
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Wed Oct 25 17:21:17 2023 +0400
vl: simplify display_remote logic
Bump the display_remote variable when the -vnc option is parsed, just
like -spice.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
system/vl.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)