Commit 9f22893a authored by Li Qiang's avatar Li Qiang Committed by Gerd Hoffmann
Browse files

vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset' (CVE-2021-3546)

If 'virgl_cmd_get_capset' set 'max_size' to 0,
the 'virgl_renderer_fill_caps' will write the data after the 'resp'.
This patch avoid this by checking the returned 'max_size'.

virtio-gpu fix: abd7f08b

 ("display: virtio-gpu-3d: check
virgl capabilities max_size")

Fixes: CVE-2021-3546
Reported-by: default avatarLi Qiang <>
Reviewed-by: default avatarPrasad J Pandit <>
Signed-off-by: default avatarLi Qiang <>
Reviewed-by: Marc-André Lureau's avatarMarc-André Lureau <>
Message-Id: <>
Signed-off-by: Gerd Hoffmann's avatarGerd Hoffmann <>
parent 63736af5
......@@ -177,6 +177,10 @@ virgl_cmd_get_capset(VuGpu *g,
virgl_renderer_get_cap_set(gc.capset_id, &max_ver,
if (!max_size) {
resp = g_malloc0(sizeof(*resp) + max_size);
resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment