Commit 8d1b247f authored by Stefano Garzarella's avatar Stefano Garzarella Committed by MST
Browse files

vhost-vsock: detach the virqueue element in case of error

In vhost_vsock_common_send_transport_reset(), if an element popped from
the virtqueue is invalid, we should call virtqueue_detach_element() to
detach it from the virtqueue before freeing its memory.

Fixes: fc0b9b0e

 ("vhost-vsock: add virtio sockets device")
Fixes: CVE-2022-26354
Reported-by: Tom Victor's avatarVictorV <>
Signed-off-by: Stefano Garzarella's avatarStefano Garzarella <>
Message-Id: <>
Reviewed-by: Stefan Hajnoczi's avatarStefan Hajnoczi <>
Reviewed-by: MST's avatarMichael S. Tsirkin <>
Signed-off-by: MST's avatarMichael S. Tsirkin <>
parent 4ccd5fe2
......@@ -153,19 +153,23 @@ static void vhost_vsock_common_send_transport_reset(VHostVSockCommon *vvc)
if (elem->out_num) {
error_report("invalid vhost-vsock event virtqueue element with "
"out buffers");
goto out;
goto err;
if (iov_from_buf(elem->in_sg, elem->in_num, 0,
&event, sizeof(event)) != sizeof(event)) {
error_report("vhost-vsock event virtqueue element is too short");
goto out;
goto err;
virtqueue_push(vq, elem, sizeof(event));
virtio_notify(VIRTIO_DEVICE(vvc), vq);
virtqueue_detach_element(vq, elem, 0);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment