Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • modus-themes modus-themes
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Protesilaos Stavrou
  • modus-themesmodus-themes
  • Merge requests
  • !50

Use common hl-line face for icomplete-selected-match

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged peniblec requested to merge peniblec/modus-themes:icomplete-selected-match into main Jul 30, 2021
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Hello!

Emacs 28 recently got built-in support for vertical display in icomplete-mode, distinct from the MELPA package "icomplete-vertical" that Modus already supports. This support comes with a new face, icomplete-selected-match, which by default inherits from highlight.

I find highlight's background a tad too bright; looking into Modus's base faces I find that modus-themes-hl-line yields a more legible result, in addition to making selection in ìcomplete-vertical-mode visually consistent with hl-line-mode.

before after

I don't necessarily think this MR is the best way to solve this problem; I can create an issue instead if more discussion is needed.

At any rate, thank you for your time.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: icomplete-selected-match