SEND FEEDBACK: diff-mode with fewer background colours (also check comments for MAGIT diff)

Currently the Modus themes style the diff-mode in the same way as the default Emacs theme. A red/green background for each line in the diff view.

These are the current styles:

Screenshot_at_2020-03-07_12-10-22

Screenshot_at_2020-03-07_12-10-31

While I am okay with what is currently in place, I find that the diff-mode is often used in contexts where we do not really need such an overwhelming use of colour.

Experimental new looks

Here is what I am working on:

Screenshot_at_2020-03-07_12-16-48

Screenshot_at_2020-03-07_12-16-58

I can actually tweak the specific colours used here. A slightly different red/green or whatnot. The idea is to use an added background to only highlight the differences on each line, but otherwise rely on just a different colour for the text on the affected line.

You can find the code in a separate branch: https://gitlab.com/protesilaos/modus-themes/-/tree/experimental-diff-mode

I wish to elicit feedback from as many users as possible before introducing such a major change.

Or this could be turned into a user-facing customisation option. The default would be to keep the looks as they currently are in master, otherwise switch to the new aesthetics. I would, however, need some help with designing a toggle of this sort…

What do you think?

Edited by Protesilaos Stavrou