today I was trying to get a more discrete fill-column-indicator here and noticed that
modus does not explicitly support the built-in
display-fill-column-indicator.el. It might be because the defaults are fine in this case, but it was somehow "tickling" me, and I thought I'd bring it to you.
By default, the
fill-column-indicator face inherits from
shadow (plus it explicitly disables any other face feature out there).
:foreground ,fg-alt for
shadow. This makes the fill-column-indicator stand out a little too much (to my taste...), in a color which is close to default foreground and probably even darker than the comments.
I, personally, wanted it more discrete, as I've mentioned, and went with:
`(fill-column-indicator ((,class :inherit shadow :weight normal :slant normal :underline nil :overline nil :strike-through nil :box nil :inverse-video nil :stipple nil :foreground ,bg-active)))
I understand this might well not satisfy the contrast requirements of
modus. But I think this is a grey area of this: against which color should this face be contrasting? foreground or background?
Anyway, this is a face that naturally stands out a lot for those who use the feature, and for this reason I think it deserves a deliberate choice and your usual thorough look. And it's just one single face. I do have a personal preference, which I shared, but I don't have an opinion on how this should be handled by
modus-themes. That's just a suggestion that you take a look. ;-)