Simplify Man and WoMan styles

* Removed the excess colouration.
* Removed faces whose default value is already what we want.

modus-themes.el

@@ -5,7 +5,7 @@
 ;; Author: Protesilaos Stavrou <info@protesilaos.com>
 ;; URL: https://gitlab.com/protesilaos/modus-themes
 ;; Version: 2.0.0
-;; Last-Modified: <2022-02-13 07:41:28 +0200>
+;; Last-Modified: <2022-02-13 09:26:33 +0200>
 ;; Package-Requires: ((emacs "27.1"))
 ;; Keywords: faces, theme, accessibility
 
@@ -6056,9 +6056,8 @@ by virtue of calling either of `modus-themes-load-operandi' and
     `(makefile-makepp-perl ((,class :background ,cyan-nuanced-bg)))
     `(makefile-space ((,class :background ,magenta-nuanced-bg)))
 ;;;;; man
-    `(Man-overstrike ((,class :inherit bold :foreground ,magenta)))
+    `(Man-overstrike ((,class :inherit bold)))
     `(Man-reverse ((,class :inherit modus-themes-subtle-magenta)))
-    `(Man-underline ((,class :foreground ,cyan :underline t)))
 ;;;;; marginalia
     `(marginalia-archive ((,class :foreground ,cyan-alt-other)))
     `(marginalia-char ((,class :foreground ,magenta)))
@@ -7359,9 +7358,7 @@ by virtue of calling either of `modus-themes-load-operandi' and
     `(writegood-weasels-face ((,class :inherit modus-themes-lang-error)))
 ;;;;; woman
     `(woman-addition ((,class :foreground ,magenta-alt-other)))
-    `(woman-bold ((,class :inherit bold :foreground ,magenta)))
-    `(woman-italic ((,class :inherit italic :foreground ,cyan)))
-    `(woman-unknown ((,class :inherit italic :foreground ,yellow)))
+    `(woman-unknown ((,class :foreground ,cyan)))
 ;;;;; xah-elisp-mode
     `(xah-elisp-at-symbol ((,class :inherit font-lock-warning-face)))
     `(xah-elisp-cap-variable ((,class :inherit font-lock-preprocessor-face)))

[Daniel Mendler]

Hmm, I kind of liked the "excess" colouration. Maybe the colors were indeed a bit too excessive, but in eww buffers you use nice and unobtrusive colors, which still prevent the buffer from looking boring. The woman/man buffers are entirely monochrome now, which is a bit too much for me. There are also monochrome themes around which people can use. I haven't tried monochrome themes so far, but I suspect that I won't like it. Modus just got the right and balanced amount of colorization for me.

[Protesilaos Stavrou]

Hmm, I kind of liked the "excess" colouration. Maybe the colors were indeed a bit too excessive, but in eww buffers you use nice and unobtrusive colors, which still prevent the buffer from looking boring. The woman/man buffers are entirely monochrome now, which is a bit too much for me. There are also monochrome themes around which people can use. I haven't tried monochrome themes so far, but I suspect that I won't like it. Modus just got the right and balanced amount of colorization for me.

Let's review this then. I will try a faint colour. Otherwise revert the change altogether.

[Daniel Mendler]

For comparison, on my system the shell man pager program also uses colours. So you didn't do anything extraordinary with the old colouration. But I believe that faint/subtle colors could be an improvement.

[Protesilaos Stavrou]

Let's try. Here we have the old style before this change:

And here a more faint one (it is a subtle change, I know):

What throws me off is the underline. In the old style they looked like links. They do look that may in my terminal as well, though I think we can improve things. Maybe not use an underline and apply italics instead? Or not use a shade of blue/cyan?

[Protesilaos Stavrou]

I'm thinking about reverting the overstike style, but changing the underlines:

I thought the cyan underlines were confusing: they look like links. But maybe this is not an improvement either?

[Daniel Mendler]

Yes, the underlines were not good in the old version. I like the faint version where the arguments with underline are not colored.

Regarding the colors, you could also give the colors of the shr-h* faces a try. They seem to be even less pronounced, e.g., shr-h5 or shr-h2. Even with the faint colors the coloring still stands out a lot.

[Protesilaos Stavrou]

I like the faint version where the arguments with underline are not colored.

Good!

They seem to be even less pronounced, e.g., shr-h5

This foreground fits better with what we had before (a more saturated magenta).

So the result:

NOTE: woman uses italics instead of underlines.

[Daniel Mendler]

Looks good!

[Protesilaos Stavrou]

Done!