Review Avy colours for better results

I tried various styles, such as:

    (setq avy-style 'pre)
    (setq avy-style 'at-full)

Also modified the 'avy-lead-faces' (which is a 'defconst', not a
'defcustom'):

    (setq avy-lead-faces
          '(avy-lead-face
            avy-lead-face-0
            avy-lead-face-2
            avy-lead-face
            avy-lead-face-0
            avy-lead-face-2))

    (setq avy-lead-faces
          '(avy-lead-face
            avy-lead-face-1
            avy-lead-face-1
            avy-lead-face-1
            avy-lead-face-1))

    (setq avy-lead-faces
          '(avy-lead-face
            avy-lead-face-2
            avy-lead-face-2
            avy-lead-face-2
            avy-lead-face-2))

I feel these new colour combinations work better than they did before.
Please let me know if this is not the case in your particular workflow
and I am willing to review things.

modus-themes.el

@@ -5,7 +5,7 @@
 ;; Author: Protesilaos Stavrou <info@protesilaos.com>
 ;; URL: https://gitlab.com/protesilaos/modus-themes
 ;; Version: 2.2.0
-;; Last-Modified: <2022-02-27 09:26:09 +0200>
+;; Last-Modified: <2022-02-27 09:47:49 +0200>
 ;; Package-Requires: ((emacs "27.1"))
 ;; Keywords: faces, theme, accessibility
 
@@ -4743,11 +4743,11 @@ by virtue of calling either of `modus-themes-load-operandi' and
     `(auto-dim-other-buffers-face ((,class :background ,bg-alt)))
 ;;;;; avy
     `(avy-background-face ((,class :background ,bg-dim :foreground ,fg-dim :extend t)))
-    `(avy-goto-char-timer-face ((,class :inherit (modus-themes-intense-yellow bold))))
-    `(avy-lead-face ((,class :inherit (modus-themes-intense-magenta bold modus-themes-reset-soft))))
-    `(avy-lead-face-0 ((,class :inherit (modus-themes-refine-cyan bold modus-themes-reset-soft))))
-    `(avy-lead-face-1 ((,class :inherit (modus-themes-special-cold modus-themes-reset-soft))))
-    `(avy-lead-face-2 ((,class :inherit (modus-themes-refine-red bold modus-themes-reset-soft))))
+    `(avy-goto-char-timer-face ((,class :inherit (modus-themes-intense-neutral bold))))
+    `(avy-lead-face ((,class :inherit (modus-themes-intense-blue bold modus-themes-reset-soft))))
+    `(avy-lead-face-0 ((,class :inherit (modus-themes-refine-magenta bold modus-themes-reset-soft))))
+    `(avy-lead-face-1 ((,class :inherit (modus-themes-special-warm modus-themes-reset-soft))))
+    `(avy-lead-face-2 ((,class :inherit (modus-themes-refine-green bold modus-themes-reset-soft))))
 ;;;;; aw (ace-window)
     `(aw-background-face ((,class :foreground ,fg-unfocused)))
     `(aw-key-face ((,class :inherit modus-themes-key-binding)))

[Daniel Mendler]

Hey Prot, I think these changes look good! Can you please adjust the vertico-quick faces accordingly, since vertico-quick is supposed to be used in a similar way as Avy?

[Protesilaos Stavrou]

Done!

[Daniel Mendler]

Thanks!