1. 08 Dec, 2019 3 commits
  2. 28 Nov, 2019 1 commit
  3. 12 Nov, 2019 1 commit
    • Craig Small's avatar
      docs: more Makefile updates · bfada70a
      Craig Small authored
      The install target was using the wrong directory and would throw
      some errors where a language couldn't translate man pages. This
      one should be hopefully more robust.
      bfada70a
  4. 11 Nov, 2019 2 commits
    • Craig Small's avatar
      docs: Update translations · 7bea203a
      Craig Small authored
      Downloaded the updated translations of the binaries and the manpages
      from translation project. Then fixed the typos that caused po4a to
      fail, mainly errant spaces.
      7bea203a
    • Craig Small's avatar
      build-sys: Use po4a for manpage translations · 2590e3be
      Craig Small authored
      Using the newer po4a tool for manpage translations. Also removing
      the manpage po file update from dist target because it should be
      something the is explicitly done.
      
      The git repository will hold the original man pages and the
      po translation files. The distribution tarball will hold those
      and the translated manpages. This means most people won't need po4a
      as the distribution fill will have these translated manpages.
      2590e3be
  5. 31 Oct, 2019 2 commits
  6. 28 Oct, 2019 2 commits
    • Craig Small's avatar
      nls: minor reference updates · bf26c683
      Craig Small authored
      bf26c683
    • Craig Small's avatar
      nls: Add all man pages to pot file · d5e3650f
      Craig Small authored
      The previous Makefile rule would only put the first required file
      into the pot file because it used $< Unfortunately, due to how
      po4a tools work, its not just a simple matter of changing it to $^
      and you're done, but needs a foreach loop to add -m to each manpage
      file.
      
      This is a temporary fix, after some more work looking into po4a the
      unified tool (called po4a) will be used.
      d5e3650f
  7. 27 Oct, 2019 1 commit
  8. 21 Oct, 2019 1 commit
    • Craig Small's avatar
      snice: Fix matching on PID · a2b71067
      Craig Small authored
      @MarsChan correctly pointed out that the read() always returns 128
      bytes, so skipping on >= 128 will always mean we skip. Their suggestion
      was to remove the equality, but read will never go past 128 bytes so
      I just removed that part of the check.
      
      References:
       !89
      a2b71067
  9. 21 Sep, 2019 8 commits
  10. 25 Aug, 2019 3 commits
  11. 04 Jul, 2019 2 commits
    • jim warner's avatar
      top: standardize PgUp/PgDn management within task area · ac83617d
      jim warner authored
      
      
      This commit standardizes the behavior of the PgUp/PgDn
      keys when on the main top display. With PgDn, the last
      process will become the first process. With PgUp, that
      first task will now appear as the last task displayed.
      
      [ this also eliminates some quirks that were evident ]
      [ when paging at or near the end of the process list ]
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      ac83617d
    • jim warner's avatar
      top: attempt to provide missing xterm vim keys support · e7aa90a8
      jim warner authored
      A recent issue (and merge request) reminded me of gaps
      in top's alternate 'vim' navigation keys support. Some
      xterm emulators do not pass the customary strings when
      keys were used with the <Ctrl> and/or <Alt> modifiers.
      
      While it was a known problem, this issue/merge request
      prompted research into the root cause. As it turns out
      the problem is traceable to an X resource known by the
      name 'eightBitInput'. When 'true' (the default), a key
      pressed in combination with <Alt> will not be preceded
      by the <Esc> character. Rather, a single character was
      presented (modified via an 'eightBitMeta' X resource).
      
      The following approaches would eliminate this problem:
      
      . start xterm thus: xterm -xrm '*eightBitInput: false'
      
      . use: ~/.Xresources with 'Xterm*eightBitInput: false'
      
      . build xterm with 'configure --enable-meta-sends-esc'
      ( apparently used for CentOS, Fedora, openSUSE, etc. )
      
      . enable xterm's menu via 'configure --enable-toolbar'
      ( so the user can set the 'Meta Sends Escape' option )
      
      Of course, none of the above steps is desirable from a
      user's perspective. So, this patch will add additional
      entries to the iokey function's tinfo_tab to represent
      strings passed when the <Alt> key does not send <Esc>.
      
      [ hopefully they'll be the same across all platforms ]
      
      Lastly, this patch will also eliminate those redundant
      <Atl> + '\', '/', '<' & '>' provisions, which now seem
      like overkill and suffer from that same 'eightBitMeta'
      xterm problem. And we might as well say goodbye to the
      4 '<Alt> + arrow key' table entries (which do not seem
      to currently work with any emulator which I can find).
      
      [ what in the world was I thinking way back in 2011? ]
      
      Reference(s):
      . issue
      #135
      . merge request
      !84
      
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      e7aa90a8
  12. 26 Mar, 2019 2 commits
    • jim warner's avatar
      library: tweak that lxc container support a final time · 2e7f3870
      jim warner authored
      Since the patch referenced below traded a compile-time
      'sizeof' directive for a run-time 'strlen' call, there
      is no need to declare lxc patterns as explicit arrays.
      
      We'll also use the actual lxc patterns by omitting the
      beginning slashes ('/') for both of those definitions.
      
      And, looking to the future when most/all lxc users are
      using the most recent lxc release, we will make things
      slightly more efficient by reversing those two pattern
      literals so the most recent pattern was checked first.
      
      Of course, such a change only benefits tasks which are
      running in a container. For the majority of processes,
      both literals will be compared in that 'if' statement,
      assuming the 'LXC' field is currently being displayed.
      
      [ plus, a leftover parenthesis pair has been removed ]
      
      Reference(s):
      commit f67127e7
      
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      2e7f3870
    • jim warner's avatar
  13. 04 Mar, 2019 8 commits
  14. 22 Jan, 2019 2 commits
    • jim warner's avatar
      top: improve logic surrounding 'smp_num_cpus' variable · 893793a8
      jim warner authored
      I thank Guido Jäkel for raising the issue cited in the
      merge request referenced below. While restoring 1 line
      of code would produce the desired results, it does not
      address the root cause of that problem he experienced.
      
      The variable 'smp_num_cpus' was set by libprocps via a
      sysconf(_SC_NPROCESSORS_ONLN) call. It was supposed to
      represent total number of processors currently online.
      It also served as the position in the Cpu_tics[] array
      where the /proc/stat line #1 (cpu summary) was stored.
      
      The variable 'Cpu_faux_tot' was valued by top based on
      total individual cpus parsed from the /proc/stat file.
      It serves as a fence post for Cpu_tics[] array access.
      
      The problem Guido experienced results from a disparity
      between those 2 variables, plus one instance where the
      wrong variable was used in the summary_show() routine.
      
      . Here is the real culprit, the actual incorrect code:
      . summary_hlp(&Cpu_tics[Cpu_faux_tot], N_txt(WORD_a...
      
      Which always should have been represented in this way:
      . summary_hlp(&Cpu_tics[smp_num_cpus], N_txt(WORD_a...
      
      ------------------------------------------------------
      The above 'disparity' might arise in any system when a
      cpu is taken offline since there's a 3 second delay in
      cpu and memory refreshes in an effort to reduce costs.
      Usually this particular condition will be short lived.
      
      However, there is a more persistent problem under lxc.
      
      If a host cpu is taken offline and then brought online
      again, within the container sysconf returns the proper
      number of online processors. But, /proc/stat does not!
      Sadly, I've yet to find a way to coax a container into
      refreshing its /proc/stat, short of reboting the host.
      
      [ might that represent a potential bug in lxc logic? ]
      
      Reference(s):
      !82
      
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      With-thanks-to: Guido Jäkel <G.Jaekel@DNB.DE>
      893793a8
    • jim warner's avatar
      library: adapt readproc for the latest lxc conventions · f67127e7
      jim warner authored
      The merge request shown below prompted (thankfully) an
      examination of our lxc containers logic in readproc.c.
      
      As it turns out, the lxc folks changed that eyecatcher
      used to identify containers within a task cgroup file.
      
      So this patch, with little extra cost, will enable the
      libprocps lxc_containers() guy to handle both strings.
      
      [ additionally, I was shocked to find lxc allows the ]
      [ eyecatcher to be changed at ./configure time. such ]
      [ a provision has always existed. unfortunately, the ]
      [ changed value was only available to root, assuming ]
      [ one wished to tackle that undocumented liblxc api. ]
      
      Reference(s):
      . what prompted lxc support reevaluation
      !82
      . original lxc support introduced
      commit 0557504f
      
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      f67127e7
  15. 02 Jan, 2019 2 commits
    • jim warner's avatar
      top: harden management of 'Hide_pid' array allocations · dbe12b54
      jim warner authored
      
      
      While setting the size of that Hide_pid array to equal
      total pids high water mark was probably safe, in truth
      there is no real relationship. At some point one could
      exceed that HWM if the 'v' toggle was used extensively
      and at least 1 of those entries remained non-negative.
      
      This commit simply divorces Hide_tot from the pids HWM
      and bases Hide_pid array size on actual run-time need.
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      dbe12b54
    • jim warner's avatar
      top: enable alternate '+' placement with collapsed pid · d8a0ab8b
      jim warner authored
      
      
      Currently, except for tasks that have no parents, when
      a process' children are collapsed the '+' indicator is
      shown in the first position within that COMMAND field.
      
      This commit simply provides for indenting the '+' char
      so it displays next to that program name/command line.
      Signed-off-by: jim warner's avatarJim Warner <james.warner@comcast.net>
      d8a0ab8b