deviceinfo_bootimg_qcdt incorrectly inferred from Google Pixel 3 XL (crosshatch) boot image
To reproduce:
- download the September 1 factory image for Google Pixel 3 XL (crosshatch)
- extract the boot.img
- start a new port and ask pmbootstrap to analyze the boot.img
Expected: deviceinfo and kernel package generated without qcdt step
Actual: qcdt step is generated
I manually unpacked the boot.img and it shows that there's a 1 byte dummy qcdt file, which seems to confuse pmbootstrap:
~/bootout # ls -l
total 30040
-rw-r--r-- 1 root root 9 Nov 27 07:05 boot_crosshatch.img-base
-rw-r--r-- 1 root root 1 Nov 27 07:05 boot_crosshatch.img-board
-rw-r--r-- 1 root root 259 Nov 27 07:05 boot_crosshatch.img-cmdline
-rw-r--r-- 1 root root 1 Nov 27 07:05 boot_crosshatch.img-dtb
-rw-r--r-- 1 root root 5 Nov 27 07:05 boot_crosshatch.img-hash
-rw-r--r-- 1 root root 9 Nov 27 07:05 boot_crosshatch.img-kerneloff
-rw-r--r-- 1 root root 8 Nov 27 07:05 boot_crosshatch.img-oslevel
-rw-r--r-- 1 root root 6 Nov 27 07:05 boot_crosshatch.img-osversion
-rw-r--r-- 1 root root 5 Nov 27 07:05 boot_crosshatch.img-pagesize
-rw-r--r-- 1 root root 10592931 Nov 27 07:05 boot_crosshatch.img-ramdisk.gz
-rw-r--r-- 1 root root 9 Nov 27 07:05 boot_crosshatch.img-ramdiskoff
-rw-r--r-- 1 root root 9 Nov 27 07:05 boot_crosshatch.img-secondoff
-rw-r--r-- 1 root root 9 Nov 27 07:05 boot_crosshatch.img-tagsoff
-rw-r--r-- 1 root root 20111558 Nov 27 07:05 boot_crosshatch.img-zImage
Maybe we need to add a minimum length check for qcdt files?