[samsung-kminilte] Mounting /system before flashing pmOS via recovery makes the install fail

Seems like it can be remain mounted by TWRP on doing a format. (or when you manually mount it)

https://gitlab.com/postmarketOS/pmbootstrap/blob/master/aports/main/postmarketos-android-recovery-installer/pmos_install#L65

+ export CHROOT=/tmp/postmarketos/chroot
+ unzip -o /sdcard/pmos-samsung-kminilte.zip chroot/* -d /tmp/postmarketos
Archive:  /sdcard/pmos-samsung-kminilte.zip
   creating: chroot/
  inflating: chroot/install_options
   creating: chroot/bin/
  inflating: chroot/bin/partprobe
  inflating: chroot/bin/umount
  inflating: chroot/bin/mkfs.ext2
  inflating: chroot/bin/cryptsetup
  inflating: chroot/bin/pmos_install_functions
  inflating: chroot/bin/findfs
  inflating: chroot/bin/tar
  inflating: chroot/bin/mkfs.ext4
  inflating: chroot/bin/kpartx
  inflating: chroot/bin/pmos_setpw
  inflating: chroot/bin/parted
  inflating: chroot/bin/busybox
  inflating: chroot/bin/pmos_install
   creating: chroot/lib/
  inflating: chroot/lib/libcrypto.so.43
  inflating: chroot/lib/libext2fs.so.2.4
  inflating: chroot/lib/libmount.so.1.1.0
  inflating: chroot/lib/libncursesw.so.6.1
  inflating: chroot/lib/libncursesw.so.6
  inflating: chroot/lib/libparted.so.2.0.1
  inflating: chroot/lib/libblkid.so.1.1.0
  inflating: chroot/lib/libjson-c.so.4
  inflating: chroot/lib/libreadline.so.7.0
  inflating: chroot/lib/libuuid.so.1.3.0
  inflating: chroot/lib/libdevmapper.so.1.02
  inflating: chroot/lib/libcryptsetup.so.12
  inflating: chroot/lib/libcryptsetup.so.12.2.0
  inflating: chroot/lib/libreadline.so.7
  inflating: chroot/lib/libext2fs.so.2
  inflating: chroot/lib/libe2p.so.2.3
  inflating: chroot/lib/libpopt.so.0
  inflating: chroot/lib/libjson-c.so.4.0.0
  inflating: chroot/lib/libuuid.so.1
  inflating: chroot/lib/ld-musl-armhf.so.1
  inflating: chroot/lib/libe2p.so.2
  inflating: chroot/lib/libblkid.so.1
  inflating: chroot/lib/libparted.so.2
  inflating: chroot/lib/libcom_err.so.2
  inflating: chroot/lib/libcom_err.so.2.1
  inflating: chroot/lib/libmount.so.1
  inflating: chroot/lib/libargon2.so.1
  inflating: chroot/lib/libc.musl-armhf.so.1
  inflating: chroot/lib/libcrypto.so.43.0.1
  inflating: chroot/lib/libpopt.so.0.0.0
+ . /tmp/postmarketos/chroot/install_options
+ DEVICE=samsung-kminilte
+ FLAVOR=samsung-kminilte
+ FLASH_KERNEL=true
+ ISOREC=false
+ KERNEL_PARTLABEL=BOOT
+ INITFS_PARTLABEL=RECOVERY
+ SYSTEM_PARTLABEL=SYSTEM
+ INSTALL_PARTITION=system
+ CIPHER=aes-cbc-plain64
+ FDE=true
+ [ true = true ]
+ echo #!/sbin/sh
+ echo chroot /tmp/postmarketos/chroot /bin/pmos_setpw
+ chmod 755 /sbin/pmos_setpw
+ umount /tmp/postmarketos/chroot/pmos.log
umount: can't umount /tmp/postmarketos/chroot/pmos.log: No such file or directory
+ rm /tmp/postmarketos/chroot/pmos.log
rm: can't remove '/tmp/postmarketos/chroot/pmos.log': No such file or directory
+ :
+ touch /tmp/postmarketos/chroot/pmos.log
+ umount /tmp/postmarketos/chroot/pmos.zip
umount: can't umount /tmp/postmarketos/chroot/pmos.zip: No such file or directory
+ rm /tmp/postmarketos/chroot/pmos.zip
rm: can't remove '/tmp/postmarketos/chroot/pmos.zip': No such file or directory
+ :
+ touch /tmp/postmarketos/chroot/pmos.zip
+ mount --bind /tmp/postmarketos/pmos.log /tmp/postmarketos/chroot/pmos.log
+ mount --bind /sdcard/pmos-samsung-kminilte.zip /tmp/postmarketos/chroot/pmos.zip
+ fstab_recovery=recovery.fstab
+ [ ! -e /etc/recovery.fstab ]
+ fstab_recovery=twrp.fstab
+ cp /etc/twrp.fstab /tmp/postmarketos/chroot/twrp.fstab
+ mkdir -p /tmp/postmarketos/chroot/dev
+ mount --bind /dev /tmp/postmarketos/chroot/dev
+ mkdir -p /tmp/postmarketos/chroot/proc
+ mount --bind /proc /tmp/postmarketos/chroot/proc
+ mkdir -p /tmp/postmarketos/chroot/sys
+ mount --bind /sys /tmp/postmarketos/chroot/sys
+ chmod 755 /tmp/postmarketos/chroot/bin/busybox /tmp/postmarketos/chroot/bin/cryptsetup /tmp/postmarketos/chroot/bin/findfs /tmp/postmarketos/chroot/bin/kpartx /tmp/postmarketos/chroot/bin/mkfs.ext2 /tmp/postmarketos/chroot/bin/mkfs.ext4 /tmp/postmarketos/chroot/bin/parted /tmp/postmarketos/chroot/bin/partprobe /tmp/postmarketos/chroot/bin/pmos_install /tmp/postmarketos/chroot/bin/pmos_install_functions /tmp/postmarketos/chroot/bin/pmos_setpw /tmp/postmarketos/chroot/bin/tar /tmp/postmarketos/chroot/bin/umount
+ chmod 755 /tmp/postmarketos/chroot/lib/ld-musl-armhf.so.1 /tmp/postmarketos/chroot/lib/libargon2.so.1 /tmp/postmarketos/chroot/lib/libblkid.so.1 /tmp/postmarketos/chroot/lib/libblkid.so.1.1.0 /tmp/postmarketos/chroot/lib/libc.musl-armhf.so.1 /tmp/postmarketos/chroot/lib/libcom_err.so.2 /tmp/postmarketos/chroot/lib/libcom_err.so.2.1 /tmp/postmarketos/chroot/lib/libcrypto.so.43 /tmp/postmarketos/chroot/lib/libcrypto.so.43.0.1 /tmp/postmarketos/chroot/lib/libcryptsetup.so.12 /tmp/postmarketos/chroot/lib/libcryptsetup.so.12.2.0 /tmp/postmarketos/chroot/lib/libdevmapper.so.1.02 /tmp/postmarketos/chroot/lib/libe2p.so.2 /tmp/postmarketos/chroot/lib/libe2p.so.2.3 /tmp/postmarketos/chroot/lib/libext2fs.so.2 /tmp/postmarketos/chroot/lib/libext2fs.so.2.4 /tmp/postmarketos/chroot/lib/libjson-c.so.4 /tmp/postmarketos/chroot/lib/libjson-c.so.4.0.0 /tmp/postmarketos/chroot/lib/libmount.so.1 /tmp/postmarketos/chroot/lib/libmount.so.1.1.0 /tmp/postmarketos/chroot/lib/libncursesw.so.6 /tmp/postmarketos/chroot/lib/libncursesw.so.6.1 /tmp/postmarketos/chroot/lib/libparted.so.2 /tmp/postmarketos/chroot/lib/libparted.so.2.0.1 /tmp/postmarketos/chroot/lib/libpopt.so.0 /tmp/postmarketos/chroot/lib/libpopt.so.0.0.0 /tmp/postmarketos/chroot/lib/libreadline.so.7 /tmp/postmarketos/chroot/lib/libreadline.so.7.0 /tmp/postmarketos/chroot/lib/libuuid.so.1 /tmp/postmarketos/chroot/lib/libuuid.so.1.3.0
+ chroot /tmp/postmarketos/chroot /bin/pmos_install
+ /bin/busybox --install /bin
+ . /bin/pmos_install_functions
+ export 'PATH=/bin'
+ export 'LD_LIBRARY_PATH=/lib'
+ . /install_options
+ DEVICE=samsung-kminilte
+ FLAVOR=samsung-kminilte
+ FLASH_KERNEL=true
+ ISOREC=false
+ KERNEL_PARTLABEL=BOOT
+ INITFS_PARTLABEL=RECOVERY
+ SYSTEM_PARTLABEL=SYSTEM
+ INSTALL_PARTITION=system
+ CIPHER=aes-cbc-plain64
+ FDE=true
+ ui_print '                                         '
+ echo 'ui_print                                          '
+ echo ui_print
+ ui_print '                    8                    '
+ echo 'ui_print                     8                    '
+ echo ui_print
+ ui_print '                   888                   '
+ echo 'ui_print                    888                   '
+ echo ui_print
+ ui_print '                  88888                  '
+ echo 'ui_print                   88888                  '
+ echo ui_print
+ ui_print '                 8888888                 '
+ echo 'ui_print                  8888888                 '
+ echo ui_print
+ ui_print '                888888888                '
+ echo 'ui_print                 888888888                '
+ echo ui_print
+ ui_print '               88888888888               '
+ echo 'ui_print                88888888888               '
+ echo ui_print
+ ui_print '               888888888888              '
+ echo 'ui_print                888888888888              '
+ echo ui_print
+ ui_print '             8  888888888888             '
+ echo 'ui_print              8  888888888888             '
+ echo ui_print
+ ui_print '            888      88888888            '
+ echo 'ui_print             888      88888888            '
+ echo ui_print
+ ui_print '           88888888   88888888           '
+ echo 'ui_print            88888888   88888888           '
+ echo ui_print
+ ui_print '          88888888     88888888          '
+ echo 'ui_print           88888888     88888888          '
+ echo ui_print
+ ui_print '         88888888       88888888         '
+ echo 'ui_print          88888888       88888888         '
+ echo ui_print
+ ui_print '        88888888         88888888        '
+ echo 'ui_print         88888888         88888888        '
+ echo ui_print
+ ui_print '       88888888           888            '
+ echo 'ui_print        88888888           888            '
+ echo ui_print
+ ui_print '      88888888             8  88888      '
+ echo 'ui_print       88888888             8  88888      '
+ echo ui_print
+ ui_print '     88888888                8888888     '
+ echo 'ui_print      88888888                8888888     '
+ echo ui_print
+ ui_print '    88888888                 88888888    '
+ echo 'ui_print     88888888                 88888888    '
+ echo ui_print
+ ui_print '   88888888888  8888888888888888888888   '
+ echo 'ui_print    88888888888  8888888888888888888888   '
+ echo ui_print
+ ui_print '  8888888888888  8888888888888888888888  '
+ echo 'ui_print   8888888888888  8888888888888888888888  '
+ echo ui_print
+ ui_print ' 8888888888888  888888888888888888888888 '
+ echo 'ui_print  8888888888888  888888888888888888888888 '
+ echo ui_print
+ ui_print '8888888888888  88888888888888888888888888'
+ echo 'ui_print 8888888888888  88888888888888888888888888'
+ echo ui_print
+ ui_print '                                         '
+ echo 'ui_print                                          '
+ echo ui_print
+ ui_print 'postmarketOS recovery installer          '
+ echo 'ui_print postmarketOS recovery installer          '
+ echo ui_print
+ ui_print '                                         '
+ echo 'ui_print                                          '
+ echo ui_print
+ mountpoint -q /mnt/pmOS
+ '[' -e /dev/mapper/pm_crypt ]
+ ui_print 'Symlinking block devices...'
+ echo 'ui_print Symlinking block devices...'
+ echo ui_print
+ ln -sf /dev/block/loop0 /dev/block/loop1 /dev/block/loop2 /dev/block/loop3 /dev/block/loop4 /dev/block/loop5 /dev/block/loop6 /dev/block/loop7 /dev/block/mmcblk0 /dev/block/mmcblk0boot0 /dev/block/mmcblk0boot1 /dev/block/mmcblk0p1 /dev/block/mmcblk0p10 /dev/block/mmcblk0p11 /dev/block/mmcblk0p12 /dev/block/mmcblk0p13 /dev/block/mmcblk0p14 /dev/block/mmcblk0p15 /dev/block/mmcblk0p16 /dev/block/mmcblk0p17 /dev/block/mmcblk0p18 /dev/block/mmcblk0p19 /dev/block/mmcblk0p2 /dev/block/mmcblk0p20 /dev/block/mmcblk0p21 /dev/block/mmcblk0p3 /dev/block/mmcblk0p4 /dev/block/mmcblk0p5 /dev/block/mmcblk0p6 /dev/block/mmcblk0p7 /dev/block/mmcblk0p8 /dev/block/mmcblk0p9 /dev/block/mmcblk1 /dev/block/mmcblk1p1 /dev/block/platform /dev/block/ram0 /dev/block/ram1 /dev/block/ram10 /dev/block/ram11 /dev/block/ram12 /dev/block/ram13 /dev/block/ram14 /dev/block/ram15 /dev/block/ram2 /dev/block/ram3 /dev/block/ram4 /dev/block/ram5 /dev/block/ram6 /dev/block/ram7 /dev/block/ram8 /dev/block/ram9 /dev/block/vnswap0 /dev/
+ ui_print 'Extracting partition table...'
+ echo 'ui_print Extracting partition table...'
+ echo ui_print
+ extract_partition_table
+ fstab_recovery=recovery.fstab
+ '[' '!' -e /recovery.fstab ]
+ fstab_recovery=twrp.fstab
+ findfs 'PARTLABEL=SYSTEM'
+ _INSTALL_DEVICE=/dev/block/mmcblk0p18
+ '[' '!' -z /dev/block/mmcblk0p18 ]
+ echo 'install device found at /dev/block/mmcblk0p18'
install device found at /dev/block/mmcblk0p18
+ export 'INSTALL_DEVICE=/dev/block/mmcblk0p18'
+ '[' false '=' true ]
+ findfs 'PARTLABEL=boot'
findfs: unable to resolve 'PARTLABEL=boot'
+ _BOOT_PARTITION=
+ awk '$1 == "/boot" {print $3; exit;}' /twrp.fstab
+ _BOOT_PARTITION=/dev/block/mmcblk0p9
+ '[' '!' -z /dev/block/mmcblk0p9 ]
+ echo 'boot partition found at /dev/block/mmcblk0p9'
boot partition found at /dev/block/mmcblk0p9
+ export 'BOOT_PARTITION=/dev/block/mmcblk0p9'
+ ui_print 'Unmounting /system...'
+ echo 'ui_print Unmounting /system...'
+ echo ui_print
+ umount_install_partition
+ awk '$1 == install_part' 'install_part=/dev/block/mmcblk0p18' /proc/mounts
+ '[' -n '/dev/block/mmcblk0p18 /system ext4 rw,seclabel,relatime,data=ordered 0 0' ]
+ umount /dev/block/mmcblk0p18
umount: /dev/block/mmcblk0p18: not mounted.