Notification LED is always blinking during inhibit

Describe your issue

What's the expected behaviour?

When device is suspended, the notification LED only blinks if there is a relevant notification (e.g. SMS).

What's the current behaviour?

The device always has a blinking notification LED when it is suspended.

Right before suspending, a notification gets displayed in phosh, that the device is going to sleep. The LED starts blinking because of that notification until the device wakes up again.

(EDIT: actually the notification gets stopped when suspend starts as @dylanvanassche explained below. However, if an application is inhibiting suspend (e.g. music player does play music), the notification is active and the LED blinks. See below for details.)

So we need to disable this notification, it's not really useful on phones.

How to reproduce your issue?

Set suspend time to 1 minute in postmarketos-tweaks makes it apparent quickly.

What device are you using?

pine64-pinephone

On what postmarketOS version did you encounter the issue?

  • edge (master branch)
  • v21.03
  • v20.05

On what environment did you encounter the issue?

Phone environments

  • Phosh

How did you get postmarketOS image?

(EDIT: removed release label, as it is for all releases)

Edited by Oliver Smith