Commit 66215664 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe

block: don't drain in-progress dispatch in blk_cleanup_queue()

Now freeing hw queue resource is moved to hctx's release handler,
we don't need to worry about the race between blk_cleanup_queue and
run queue any more.

So don't drain in-progress dispatch in blk_cleanup_queue().

This is basically revert of c2856ae2 ("blk-mq: quiesce queue before
freeing queue").

Cc: Dongli Zhang <[email protected]>
Cc: James Smart <[email protected]>
Cc: Bart Van Assche <[email protected]>
Cc: [email protected],
Cc: Martin K . Petersen <[email protected]>,
Cc: Christoph Hellwig <[email protected]>,
Cc: James E . J . Bottomley <[email protected]>,
Reviewed-by: default avatarBart Van Assche <[email protected]>
Reviewed-by: default avatarHannes Reinecke <[email protected]>
Tested-by: default avatarJames Smart <[email protected]>
Signed-off-by: default avatarMing Lei <[email protected]>
Signed-off-by: default avatarJens Axboe <[email protected]>
parent 1b97871b
......@@ -339,18 +339,6 @@ void blk_cleanup_queue(struct request_queue *q)
blk_queue_flag_set(QUEUE_FLAG_DEAD, q);
* make sure all in-progress dispatch are completed because
* blk_freeze_queue() can only complete all requests, and
* dispatch may still be in-progress since we dispatch requests
* from more than one contexts.
* We rely on driver to deal with the race in case that queue
* initialization isn't done.
if (queue_is_mq(q) && blk_queue_init_done(q))
/* for synchronous bio-based driver finish in-flight integrity i/o */
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment