Commit 2149da07 authored by Balbir Singh's avatar Balbir Singh Committed by Jens Axboe

block: add cmd_flags to print_req_error

I ran into a bug where after hibernation due to incompatible
backends, the block driver returned BLK_STS_NOTSUPP, with the
current message it's hard to find out what the command flags
were. Adding req->cmd_flags help make the problem easier to
diagnose.
Reviewed-by: default avatarEduardo Valentin <[email protected]>
Reviewed-by: default avatarMing Lei <[email protected]>
Signed-off-by: default avatarBalbir Singh <[email protected]>
Signed-off-by: default avatarJens Axboe <[email protected]>
parent 5d2ee712
......@@ -173,10 +173,11 @@ static void print_req_error(struct request *req, blk_status_t status)
if (WARN_ON_ONCE(idx >= ARRAY_SIZE(blk_errors)))
return;
printk_ratelimited(KERN_ERR "%s: %s error, dev %s, sector %llu\n",
__func__, blk_errors[idx].name, req->rq_disk ?
req->rq_disk->disk_name : "?",
(unsigned long long)blk_rq_pos(req));
printk_ratelimited(KERN_ERR "%s: %s error, dev %s, sector %llu flags %x\n",
__func__, blk_errors[idx].name,
req->rq_disk ? req->rq_disk->disk_name : "?",
(unsigned long long)blk_rq_pos(req),
req->cmd_flags);
}
static void req_bio_endio(struct request *rq, struct bio *bio,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment