In the "relation sizes" report, L001, there is no LIMIT – if we have 10-100k tables, the report is huge and checkup process
take ages.
We need a LIMIT, but also we need to make sure that total numbers are not affected (this, we need to count all those tables that are beyond limit as "other")
Nikolay Samokhvalov (208738b5) at 16 Dec 07:26
Improve code style in L003
that being said, one particular change – replacing spaces with tables – I think we won't be able to accept, since we use the spaces for bash code, historically (and tabs for Go).
thank you so much – as I see, a lot of code style fixes, this is great, apprecate it, @cgwillz
Nikolay Samokhvalov (a6c8b6ae) at 12 Dec 06:47
polish H004
Nikolay Samokhvalov (7f5c45b1) at 11 Dec 02:46
Missing spaces
Nikolay Samokhvalov (3a04db57) at 11 Dec 02:40
Apply 2 suggestion(s) to 1 file(s)
else idx_scan::numeric / writes
else idx_scan::numeric / all_scans * 100
Nikolay Samokhvalov (6e48d0dd) at 11 Dec 02:37
polish
Nikolay Samokhvalov (0122f020) at 11 Dec 02:33
Cleanup formatting for H002
--argfile
was removed in jq 1.7
Slurpfile has been a valid alternative for a few years so this drop in should not need to change scripts where the version is pinned
Nikolay Samokhvalov (d5a4bc1b) at 03 Oct 16:04
Merge branch '512-support-total-time' into 'master'
Artyom Kartasov (97c903e7) at 03 Oct 16:02
Nikolay Samokhvalov (6dcb0eb0) at 03 Oct 16:02
Merge branch '512-support-total-time' into 'master'
... and 1 more commit
[2023-09-28T19:43:39+0000] === Run on 'host': resources/checks/K000_query_analysis.sh ===
psql:<stdin>:45: ERROR: column "total_time" does not exist
LINE 9: total_time,
^
since pg13 pg_stat_statements changed it's format https://www.postgresql.org/docs/13/pgstatstatements.html
there is no filed total_time
anymore, it was replaced by total_plan_time
and total_exec_time
.
So sql query should be updated for versions pg13+
instead of total_time
total_plan_time + total_exec_time as total_time
Closes #512
Closes #512
Closes #512