K001, K002, K003: do not round() values of main metrics (calls, total_time, rows); use integers when float is not needed.
Calls
:
-
1.14K
– important info is hidden. We must not round the value here, we need exact value of the integer number.
Total time
:
-
1ms/sec
or0s/sec
– important info is hidden. We must not round the value here, we need exact value of the float number. (1.23 ms/sec
or0.23 ms/sec
)
Rows
:
-
19.77K
– important info is hidden. We must not round the value here, we need exact value of the integer number.
shared_blks_hit
, shared_blks_read
, etc
-
52.84M blks
– important info is hidden. We must not round the value here, we need exact value of the integer number. As for differentiated values, it is okay to have non-exact value like392.18K blks/sec
.
Acceptance criteria
- in
Calls
column, instead of1.14K
I see1140256
(better:1,140,256
) - in
Total time
(andkcache_user_time_ms
,kcache_system_time
), instead of1ms/sec
I see1.51 ms/sec
. Instead of0s/sec
I see0.23 ms/sec
. - instead of
7.00 blks
I see7 blks
- in
Rows
: instead of19.77K
I see19774012
(better:19,774,012
) - in
shared_blks_hit
and others: instead of52.84M blks
I see52840656 blks
(better:52,840,656 blks
)
Edited by Nikolay Samokhvalov