• Dave Martin's avatar
    arm64/sve: Fix missing SVE/FPSIMD endianness conversions · 41040cf7
    Dave Martin authored
    The in-memory representation of SVE and FPSIMD registers is
    different: the FPSIMD V-registers are stored as single 128-bit
    host-endian values, whereas SVE registers are stored in an
    endianness-invariant byte order.
    This means that the two representations differ when running on a
    big-endian host.  But we blindly copy data from one representation
    to another when converting between the two, resulting in the
    register contents being unintentionally byteswapped in certain
    situations.  Currently this can be triggered by the first SVE
    instruction after a syscall, for example (though the potential
    trigger points may vary in future).
    So, fix the conversion functions fpsimd_to_sve(), sve_to_fpsimd()
    and sve_sync_from_fpsimd_zeropad() to swab where appropriate.
    There is no common swahl128() or swab128() that we could use here.
    Maybe it would be worth making this generic, but for now add a
    simple local hack.
    Since the byte order differences are exposed in ABI, also clarify
    the documentation.
    Cc: Alex Bennée <alex.bennee@linaro.org>
    Cc: Peter Maydell <peter.maydell@linaro.org>
    Cc: Alan Hayward <alan.hayward@arm.com>
    Cc: Julien Grall <julien.grall@arm.com>
    Fixes: bc0ee476 ("arm64/sve: Core task context handling")
    Fixes: 8cd969d2 ("arm64/sve: Signal handling support")
    Fixes: 43d4da2c ("arm64/sve: ptrace and ELF coredump support")
    Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
    [will: Fix typos in comments and docs spotted by Julien]
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
Last commit
Last update
acpi_object_usage.txt Loading commit data...
arm-acpi.txt Loading commit data...
booting.txt Loading commit data...
cpu-feature-registers.txt Loading commit data...
elf_hwcaps.txt Loading commit data...
hugetlbpage.txt Loading commit data...
legacy_instructions.txt Loading commit data...
memory.txt Loading commit data...
perf.txt Loading commit data...
pointer-authentication.txt Loading commit data...
silicon-errata.txt Loading commit data...
sve.txt Loading commit data...
tagged-pointers.txt Loading commit data...