• Christian Lamparter's avatar
    pinctrl: msm: fix gpio-hog related boot issues · a86caa9b
    Christian Lamparter authored
    Sven Eckelmann reported an issue with the current IPQ4019 pinctrl.
    Setting up any gpio-hog in the device-tree for his device would
    "kill the bootup completely":
    
    | [    0.477838] msm_serial 78af000.serial: could not find pctldev for node /soc/pinctrl@1000000/serial_pinmux, deferring probe
    | [    0.499828] spi_qup 78b5000.spi: could not find pctldev for node /soc/pinctrl@1000000/spi_0_pinmux, deferring probe
    | [    1.298883] requesting hog GPIO enable USB2 power (chip 1000000.pinctrl, offset 58) failed, -517
    | [    1.299609] gpiochip_add_data: GPIOs 0..99 (1000000.pinctrl) failed to register
    | [    1.308589] ipq4019-pinctrl 1000000.pinctrl: Failed register gpiochip
    | [    1.316586] msm_serial 78af000.serial: could not find pctldev for node /soc/pinctrl@1000000/serial_pinmux, deferring probe
    | [    1.322415] spi_qup 78b5000.spi: could not find pctldev for node /soc/pinctrl@1000000/spi_0_pinmux, deferri
    
    This was also verified on a RT-AC58U (IPQ4018) which would
    no longer boot, if a gpio-hog was specified. (Tried forcing
    the USB LED PIN (GPIO0) to high.).
    
    The problem is that Pinctrl+GPIO registration is currently
    peformed in the following order in pinctrl-msm.c:
    	1. pinctrl_register()
    	2. gpiochip_add()
    	3. gpiochip_add_pin_range()
    
    The actual error code -517 == -EPROBE_DEFER is coming from
    pinctrl_get_device_gpio_range(), which is called through:
            gpiochip_add
                of_gpiochip_add
                    of_gpiochip_scan_gpios
                        gpiod_hog
                            gpiochip_request_own_desc
                                __gpiod_request
                                    chip->request
                                        gpiochip_generic_request
                                           pinctrl_gpio_request
                                              pinctrl_get_device_gpio_range
    
    pinctrl_get_device_gpio_range() is unable to find any valid
    pin ranges, since nothing has been added to the pinctrldev_list yet.
    so the range can't be found, and the operation fails with -EPROBE_DEFER.
    
    This patch fixes the issue by adding the "gpio-ranges" property to
    the pinctrl device node of all upstream Qcom SoC. The pin ranges are
    then added by the gpio core.
    
    In order to remain compatible with older, existing DTs (and ACPI)
    a check for the "gpio-ranges" property has been added to
    msm_gpio_init(). This prevents the driver of adding the same entry
    to the pinctrldev_list twice.
    Reported-by: Sven Eckelmann's avatarSven Eckelmann <sven.eckelmann@openmesh.com>
    Tested-by: Sven Eckelmann <sven.eckelmann@openmesh.com> [ipq4019]
    Reviewed-by: Bjorn Andersson's avatarBjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: default avatarChristian Lamparter <chunkeey@gmail.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    a86caa9b
Name
Last commit
Last update
..
Kconfig Loading commit data...
Makefile Loading commit data...
pinctrl-apq8064.c Loading commit data...
pinctrl-apq8084.c Loading commit data...
pinctrl-ipq4019.c Loading commit data...
pinctrl-ipq8064.c Loading commit data...
pinctrl-ipq8074.c Loading commit data...
pinctrl-mdm9615.c Loading commit data...
pinctrl-msm.c Loading commit data...
pinctrl-msm.h Loading commit data...
pinctrl-msm8660.c Loading commit data...
pinctrl-msm8916.c Loading commit data...
pinctrl-msm8960.c Loading commit data...
pinctrl-msm8994.c Loading commit data...
pinctrl-msm8996.c Loading commit data...
pinctrl-msm8998.c Loading commit data...
pinctrl-msm8x74.c Loading commit data...
pinctrl-qdf2xxx.c Loading commit data...
pinctrl-sdm845.c Loading commit data...
pinctrl-spmi-gpio.c Loading commit data...
pinctrl-spmi-mpp.c Loading commit data...
pinctrl-ssbi-gpio.c Loading commit data...
pinctrl-ssbi-mpp.c Loading commit data...