• Denys Vlasenko's avatar
    net: make getname() functions return length rather than use int* parameter · 9b2c45d4
    Denys Vlasenko authored
    Changes since v1:
    Added changes in these files:
        drivers/infiniband/hw/usnic/usnic_transport.c
        drivers/staging/lustre/lnet/lnet/lib-socket.c
        drivers/target/iscsi/iscsi_target_login.c
        drivers/vhost/net.c
        fs/dlm/lowcomms.c
        fs/ocfs2/cluster/tcp.c
        security/tomoyo/network.c
    
    Before:
    All these functions either return a negative error indicator,
    or store length of sockaddr into "int *socklen" parameter
    and return zero on success.
    
    "int *socklen" parameter is awkward. For example, if caller does not
    care, it still needs to provide on-stack storage for the value
    it does not need.
    
    None of the many FOO_getname() functions of various protocols
    ever used old value of *socklen. They always just overwrite it.
    
    This change drops this parameter, and makes all these functions, on success,
    return length of sockaddr. It's always >= 0 and can be differentiated
    from an error.
    
    Tests in callers are changed from "if (err)" to "if (err < 0)", where needed.
    
    rpc_sockname() lost "int buflen" parameter, since its only use was
    to be passed to kernel_getsockname() as &buflen and subsequently
    not used in any way.
    
    Userspace API is not changed.
    
        text    data     bss      dec     hex filename
    30108430 2633624  873672 33615726 200ef6e vmlinux.before.o
    30108109 2633612  873672 33615393 200ee21 vmlinux.o
    Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
    CC: David S. Miller <davem@davemloft.net>
    CC: linux-kernel@vger.kernel.org
    CC: netdev@vger.kernel.org
    CC: linux-bluetooth@vger.kernel.org
    CC: linux-decnet-user@lists.sourceforge.net
    CC: linux-wireless@vger.kernel.org
    CC: linux-rdma@vger.kernel.org
    CC: linux-sctp@vger.kernel.org
    CC: linux-nfs@vger.kernel.org
    CC: linux-x25@vger.kernel.org
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9b2c45d4
Name
Last commit
Last update
..
policy Loading commit data...
.gitignore Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...
audit.c Loading commit data...
common.c Loading commit data...
common.h Loading commit data...
condition.c Loading commit data...
domain.c Loading commit data...
environ.c Loading commit data...
file.c Loading commit data...
gc.c Loading commit data...
group.c Loading commit data...
load_policy.c Loading commit data...
memory.c Loading commit data...
mount.c Loading commit data...
network.c Loading commit data...
realpath.c Loading commit data...
securityfs_if.c Loading commit data...
tomoyo.c Loading commit data...
util.c Loading commit data...