• Arnd Bergmann's avatar
    ASoC: wm97xx: fix uninitialized regmap pointer problem · 47b6173b
    Arnd Bergmann authored
    [ Upstream commit 576ce407 ]
    
    gcc notices that without either the ac97 bus or the pdata, we never
    initialize the regmap pointer, which leads to an uninitialized variable
    access:
    
    sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe':
    sound/soc/codecs/wm9712.c:666:2: error: 'regmap' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    Since that configuration is invalid, it's better to return an error
    here. I tried to avoid adding complexity to the conditions, and turned
    the #ifdef into a regular if(IS_ENABLED()) check for readability.
    This in turn requires moving some header file declarations out of
    an #ifdef.
    
    The same code is used in three drivers, all of which I'm changing
    the same way.
    
    Fixes: 2ed1a8e0 ("ASoC: wm9712: add ac97 new bus support")
    Signed-off-by: 's avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: 's avatarMark Brown <broonie@kernel.org>
    Signed-off-by: 's avatarSasha Levin <sashal@kernel.org>
    47b6173b
Name
Last commit
Last update
..
ac97 Loading commit data...
ac97_codec.h Loading commit data...
aci.h Loading commit data...
ad1816a.h Loading commit data...
ad1843.h Loading commit data...
adau1373.h Loading commit data...
aess.h Loading commit data...
ak4113.h Loading commit data...
ak4114.h Loading commit data...
ak4117.h Loading commit data...
ak4531_codec.h Loading commit data...
ak4641.h Loading commit data...
ak4xxx-adda.h Loading commit data...
alc5623.h Loading commit data...
asequencer.h Loading commit data...
asound.h Loading commit data...
asoundef.h Loading commit data...
compress_driver.h Loading commit data...
control.h Loading commit data...
core.h Loading commit data...
cs35l33.h Loading commit data...
cs35l34.h Loading commit data...
cs35l35.h Loading commit data...
cs4231-regs.h Loading commit data...
cs4271.h Loading commit data...
cs42l52.h Loading commit data...
cs42l56.h Loading commit data...
cs42l73.h Loading commit data...
cs8403.h Loading commit data...
cs8427.h Loading commit data...
da7213.h Loading commit data...
da7218.h Loading commit data...
da7219-aad.h Loading commit data...
da7219.h Loading commit data...
da9055.h Loading commit data...
designware_i2s.h Loading commit data...
dmaengine_pcm.h Loading commit data...
emu10k1.h Loading commit data...
emu10k1_synth.h Loading commit data...
emu8000.h Loading commit data...
emu8000_reg.h Loading commit data...
emux_legacy.h Loading commit data...
emux_synth.h Loading commit data...
es1688.h Loading commit data...
gus.h Loading commit data...
hda_chmap.h Loading commit data...
hda_codec.h Loading commit data...
hda_component.h Loading commit data...
hda_hwdep.h Loading commit data...
hda_i915.h Loading commit data...
hda_register.h Loading commit data...
hda_regmap.h Loading commit data...
hda_verbs.h Loading commit data...
hdaudio.h Loading commit data...
hdaudio_ext.h Loading commit data...
hdmi-codec.h Loading commit data...
hwdep.h Loading commit data...
i2c.h Loading commit data...
info.h Loading commit data...
initval.h Loading commit data...
jack.h Loading commit data...
l3.h Loading commit data...
max9768.h Loading commit data...
max98088.h Loading commit data...
max98090.h Loading commit data...
max98095.h Loading commit data...
memalloc.h Loading commit data...
minors.h Loading commit data...
mixer_oss.h Loading commit data...
mpu401.h Loading commit data...
omap-hdmi-audio.h Loading commit data...
opl3.h Loading commit data...
opl4.h Loading commit data...
pcm-indirect.h Loading commit data...
pcm.h Loading commit data...
pcm_drm_eld.h Loading commit data...
pcm_iec958.h Loading commit data...
pcm_oss.h Loading commit data...
pcm_params.h Loading commit data...
pt2258.h Loading commit data...
pxa2xx-lib.h Loading commit data...
rawmidi.h Loading commit data...
rt286.h Loading commit data...
rt298.h Loading commit data...
rt5514.h Loading commit data...
rt5645.h Loading commit data...
rt5659.h Loading commit data...
rt5660.h Loading commit data...
rt5663.h Loading commit data...
rt5665.h Loading commit data...
rt5668.h Loading commit data...
rt5670.h Loading commit data...
rt5682.h Loading commit data...
s3c24xx_uda134x.h Loading commit data...
sb.h Loading commit data...
sb16_csp.h Loading commit data...
seq_device.h Loading commit data...
seq_kernel.h Loading commit data...
seq_midi_emul.h Loading commit data...
seq_midi_event.h Loading commit data...
seq_oss.h Loading commit data...
seq_oss_legacy.h Loading commit data...
seq_virmidi.h Loading commit data...
sh_dac_audio.h Loading commit data...
sh_fsi.h Loading commit data...
simple_card.h Loading commit data...
simple_card_utils.h Loading commit data...
snd_wavefront.h Loading commit data...
soc-acpi-intel-match.h Loading commit data...
soc-acpi.h Loading commit data...
soc-dai.h Loading commit data...
soc-dapm.h Loading commit data...
soc-dpcm.h Loading commit data...
soc-topology.h Loading commit data...
soc.h Loading commit data...
soundfont.h Loading commit data...
spear_dma.h Loading commit data...
spear_spdif.h Loading commit data...
sta32x.h Loading commit data...
sta350.h Loading commit data...
tas2552-plat.h Loading commit data...
tas5086.h Loading commit data...
tea6330t.h Loading commit data...
timer.h Loading commit data...
tlv.h Loading commit data...
tlv320aic32x4.h Loading commit data...
tlv320aic3x.h Loading commit data...
tlv320dac33-plat.h Loading commit data...
tpa6130a2-plat.h Loading commit data...
uda134x.h Loading commit data...
uda1380.h Loading commit data...
util_mem.h Loading commit data...
vx_core.h Loading commit data...
wavefront.h Loading commit data...
wm0010.h Loading commit data...
wm1250-ev1.h Loading commit data...
wm2000.h Loading commit data...
wm2200.h Loading commit data...
wm5100.h Loading commit data...
wm8903.h Loading commit data...
wm8904.h Loading commit data...
wm8955.h Loading commit data...
wm8960.h Loading commit data...
wm8962.h Loading commit data...
wm8993.h Loading commit data...
wm8996.h Loading commit data...
wm9081.h Loading commit data...
wm9090.h Loading commit data...
wss.h Loading commit data...